Patchwork [U-Boot,1/2] env_callback: Mark find_env_callback as static

login
register
mail settings
Submitter Tom Rini
Date March 12, 2013, 4:16 p.m.
Message ID <1363105011-24891-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/227071/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Tom Rini - March 12, 2013, 4:16 p.m.
This is not called outside of env_callback.c so mark static, remove from
<env_callback.h>

Cc: Joe Hershberger <joe.hershberger@ni.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 common/env_callback.c  |    2 +-
 include/env_callback.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
Joe Hershberger - March 12, 2013, 6:16 p.m.
Hi Tom,


On Tue, Mar 12, 2013 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
> This is not called outside of env_callback.c so mark static, remove from
> <env_callback.h>
>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---

> http://lists.denx.de/mailman/listinfo/u-boot

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini - March 27, 2013, 6:48 p.m.
On Tue, Mar 12, 2013 at 06:16:50AM -0000, Tom Rini wrote:

> This is not called outside of env_callback.c so mark static, remove from
> <env_callback.h>
> 
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!

Patch

diff --git a/common/env_callback.c b/common/env_callback.c
index 78ca367..78aafb4 100644
--- a/common/env_callback.c
+++ b/common/env_callback.c
@@ -31,7 +31,7 @@  DECLARE_GLOBAL_DATA_PTR;
 /*
  * Look up a callback function pointer by name
  */
-struct env_clbk_tbl *find_env_callback(const char *name)
+static struct env_clbk_tbl *find_env_callback(const char *name)
 {
 	struct env_clbk_tbl *clbkp;
 	int i;
diff --git a/include/env_callback.h b/include/env_callback.h
index 62428d1..dfc41ae 100644
--- a/include/env_callback.h
+++ b/include/env_callback.h
@@ -67,7 +67,6 @@  struct env_clbk_tbl {
 		int flags);
 };
 
-struct env_clbk_tbl *find_env_callback(const char *);
 void env_callback_init(ENTRY *var_entry);
 
 /*