Patchwork [U-Boot,v2,2/4] NET: macb: support sama5d3x devices

login
register
mail settings
Submitter Bo Shen
Date March 12, 2013, 6:15 a.m.
Message ID <1363068932-2485-3-git-send-email-voice.shen@atmel.com>
Download mbox | patch
Permalink /patch/226793/
State Changes Requested
Delegated to: Andreas Bießmann
Headers show

Comments

Bo Shen - March 12, 2013, 6:15 a.m.
Add macb support for sama5d3x devices

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
change in v2:
  No change
---
 drivers/net/macb.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Andreas Bießmann - May 12, 2013, 11:33 a.m.
Dear Bo Shen,

On 12.03.2013 07:15, Bo Shen wrote:
> Add macb support for sama5d3x devices
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> change in v2:
>    No change
> ---
>   drivers/net/macb.c |    6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 8bacbda..9e7fbc6 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
>   #if	defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>   	defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \
>   	defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
> -	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
> +	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
> +	defined(CONFIG_SAMA5D3)

I would like to apply http://patchwork.ozlabs.org/patch/239064/ instead 
of this one.
Joe, do you have any objections?

Best regards

Andreas Bießmann
Joe Hershberger - May 13, 2013, 9:31 p.m.
On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
<andreas.devel@googlemail.com> wrote:
> Dear Bo Shen,
>
>
> On 12.03.2013 07:15, Bo Shen wrote:
>>
>> Add macb support for sama5d3x devices
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> change in v2:
>>    No change
>> ---
>>   drivers/net/macb.c |    6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>> index 8bacbda..9e7fbc6 100644
>> --- a/drivers/net/macb.c
>> +++ b/drivers/net/macb.c
>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev, bd_t
>> *bd)
>>   #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>         defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \
>>         defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>> +       defined(CONFIG_SAMA5D3)
>
>
> I would like to apply http://patchwork.ozlabs.org/patch/239064/ instead of
> this one.
> Joe, do you have any objections?

Agreed.

-Joe
Bo Shen - May 22, 2013, 8:45 a.m.
Hi Andreas,

On 5/14/2013 05:31, Joe Hershberger wrote:
> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
> <andreas.devel@googlemail.com> wrote:
>> Dear Bo Shen,
>>
>>
>> On 12.03.2013 07:15, Bo Shen wrote:
>>>
>>> Add macb support for sama5d3x devices
>>>
>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>> ---
>>> change in v2:
>>>     No change
>>> ---
>>>    drivers/net/macb.c |    6 ++++--
>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>> index 8bacbda..9e7fbc6 100644
>>> --- a/drivers/net/macb.c
>>> +++ b/drivers/net/macb.c
>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev, bd_t
>>> *bd)
>>>    #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>>          defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \
>>>          defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>> +       defined(CONFIG_SAMA5D3)
>>
>>
>> I would like to apply http://patchwork.ozlabs.org/patch/239064/ instead of
>> this one.
>> Joe, do you have any objections?
>
> Agreed.

Just remind to take this patch: net: macb: using AT91FAMILY replace 
#ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb 
won't work with sama5d3xek board.

> -Joe
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Best Regards,
Bo Shen
Andreas Bießmann - May 23, 2013, 6:51 a.m.
Hi Bo,

On 22.05.13 10:45, Bo Shen wrote:
> Hi Andreas,
> 
> On 5/14/2013 05:31, Joe Hershberger wrote:
>> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
>> <andreas.devel@googlemail.com> wrote:
>>> Dear Bo Shen,
>>>
>>>
>>> On 12.03.2013 07:15, Bo Shen wrote:
>>>>
>>>> Add macb support for sama5d3x devices
>>>>
>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>> ---
>>>> change in v2:
>>>>     No change
>>>> ---
>>>>    drivers/net/macb.c |    6 ++++--
>>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>>> index 8bacbda..9e7fbc6 100644
>>>> --- a/drivers/net/macb.c
>>>> +++ b/drivers/net/macb.c
>>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev,
>>>> bd_t
>>>> *bd)
>>>>    #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>>>          defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>>>> || \
>>>>          defined(CONFIG_AT91SAM9G45) ||
>>>> defined(CONFIG_AT91SAM9M10G45) || \
>>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>>> +       defined(CONFIG_SAMA5D3)
>>>
>>>
>>> I would like to apply http://patchwork.ozlabs.org/patch/239064/
>>> instead of
>>> this one.
>>> Joe, do you have any objections?
>>
>> Agreed.
> 
> Just remind to take this patch: net: macb: using AT91FAMILY replace
> #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb
> won't work with sama5d3xek board.

I thought this would go through Joe's tree. There are some patches
delegated to him regarding sama5 network too (gmac). I could pick up
this single patch however, lets wait some days for Joe to work on the
whole series.

Best regards

Andreas Bießmann
Joe Hershberger - May 23, 2013, 9:58 p.m.
Hi,

On Thu, May 23, 2013 at 1:51 AM, Andreas Bießmann
<andreas.devel@googlemail.com> wrote:
> Hi Bo,
>
> On 22.05.13 10:45, Bo Shen wrote:
>> Hi Andreas,
>>
>> On 5/14/2013 05:31, Joe Hershberger wrote:
>>> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
>>> <andreas.devel@googlemail.com> wrote:
>>>> Dear Bo Shen,
>>>>
>>>>
>>>> On 12.03.2013 07:15, Bo Shen wrote:
>>>>>
>>>>> Add macb support for sama5d3x devices
>>>>>
>>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>>> ---
>>>>> change in v2:
>>>>>     No change
>>>>> ---
>>>>>    drivers/net/macb.c |    6 ++++--
>>>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>>>> index 8bacbda..9e7fbc6 100644
>>>>> --- a/drivers/net/macb.c
>>>>> +++ b/drivers/net/macb.c
>>>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev,
>>>>> bd_t
>>>>> *bd)
>>>>>    #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>>>>          defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>>>>> || \
>>>>>          defined(CONFIG_AT91SAM9G45) ||
>>>>> defined(CONFIG_AT91SAM9M10G45) || \
>>>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>>>> +       defined(CONFIG_SAMA5D3)
>>>>
>>>>
>>>> I would like to apply http://patchwork.ozlabs.org/patch/239064/
>>>> instead of
>>>> this one.
>>>> Joe, do you have any objections?
>>>
>>> Agreed.
>>
>> Just remind to take this patch: net: macb: using AT91FAMILY replace
>> #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb
>> won't work with sama5d3xek board.
>
> I thought this would go through Joe's tree. There are some patches
> delegated to him regarding sama5 network too (gmac). I could pick up
> this single patch however, lets wait some days for Joe to work on the
> whole series.


Yes, I hope to be getting to patches assigned to me in patchwork in
the next week or so.

-Joe
Bo Shen - May 24, 2013, 1:11 a.m.
Hi Andreas,

On 5/23/2013 14:51, Andreas Bießmann wrote:
> Hi Bo,
>
> On 22.05.13 10:45, Bo Shen wrote:
>> Hi Andreas,
>>
>> On 5/14/2013 05:31, Joe Hershberger wrote:
>>> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
>>> <andreas.devel@googlemail.com> wrote:
>>>> Dear Bo Shen,
>>>>
>>>>
>>>> On 12.03.2013 07:15, Bo Shen wrote:
>>>>>
>>>>> Add macb support for sama5d3x devices
>>>>>
>>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>>> ---
>>>>> change in v2:
>>>>>      No change
>>>>> ---
>>>>>     drivers/net/macb.c |    6 ++++--
>>>>>     1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>>>> index 8bacbda..9e7fbc6 100644
>>>>> --- a/drivers/net/macb.c
>>>>> +++ b/drivers/net/macb.c
>>>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev,
>>>>> bd_t
>>>>> *bd)
>>>>>     #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>>>>           defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>>>>> || \
>>>>>           defined(CONFIG_AT91SAM9G45) ||
>>>>> defined(CONFIG_AT91SAM9M10G45) || \
>>>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>>>> +       defined(CONFIG_SAMA5D3)
>>>>
>>>>
>>>> I would like to apply http://patchwork.ozlabs.org/patch/239064/
>>>> instead of
>>>> this one.
>>>> Joe, do you have any objections?
>>>
>>> Agreed.
>>
>> Just remind to take this patch: net: macb: using AT91FAMILY replace
>> #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb
>> won't work with sama5d3xek board.
>
> I thought this would go through Joe's tree. There are some patches
> delegated to him regarding sama5 network too (gmac). I could pick up
> this single patch however, lets wait some days for Joe to work on the
> whole series.

OK, I will wait Joe to take these patches.
Thanks.

> Best regards
>
> Andreas Bießmann

Best Regards,
Bo Shen
Bo Shen - June 17, 2013, 1:11 a.m.
Hi Joe,

On 5/24/2013 05:58, Joe Hershberger wrote:
> Hi,
>
> On Thu, May 23, 2013 at 1:51 AM, Andreas Bießmann
> <andreas.devel@googlemail.com> wrote:
>> Hi Bo,
>>
>> On 22.05.13 10:45, Bo Shen wrote:
>>> Hi Andreas,
>>>
>>> On 5/14/2013 05:31, Joe Hershberger wrote:
>>>> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
>>>> <andreas.devel@googlemail.com> wrote:
>>>>> Dear Bo Shen,
>>>>>
>>>>>
>>>>> On 12.03.2013 07:15, Bo Shen wrote:
>>>>>>
>>>>>> Add macb support for sama5d3x devices
>>>>>>
>>>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>>>> ---
>>>>>> change in v2:
>>>>>>      No change
>>>>>> ---
>>>>>>     drivers/net/macb.c |    6 ++++--
>>>>>>     1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>>>>> index 8bacbda..9e7fbc6 100644
>>>>>> --- a/drivers/net/macb.c
>>>>>> +++ b/drivers/net/macb.c
>>>>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev,
>>>>>> bd_t
>>>>>> *bd)
>>>>>>     #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
>>>>>>           defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>>>>>> || \
>>>>>>           defined(CONFIG_AT91SAM9G45) ||
>>>>>> defined(CONFIG_AT91SAM9M10G45) || \
>>>>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>>>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>>>>> +       defined(CONFIG_SAMA5D3)
>>>>>
>>>>>
>>>>> I would like to apply http://patchwork.ozlabs.org/patch/239064/
>>>>> instead of
>>>>> this one.
>>>>> Joe, do you have any objections?
>>>>
>>>> Agreed.
>>>
>>> Just remind to take this patch: net: macb: using AT91FAMILY replace
>>> #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb
>>> won't work with sama5d3xek board.
>>
>> I thought this would go through Joe's tree. There are some patches
>> delegated to him regarding sama5 network too (gmac). I could pick up
>> this single patch however, lets wait some days for Joe to work on the
>> whole series.
>
>
> Yes, I hope to be getting to patches assigned to me in patchwork in
> the next week or so.

When will these patches will be dealt.

> -Joe
>

Best Regards,
Bo Shen
Joe Hershberger - June 17, 2013, 2:27 a.m.
Hi Bo,

On Sun, Jun 16, 2013 at 8:11 PM, Bo Shen <bard.shen@gmail.com> wrote:
> Hi Joe,
>
>
> On 5/24/2013 05:58, Joe Hershberger wrote:
>>
>> Hi,
>>
>> On Thu, May 23, 2013 at 1:51 AM, Andreas Bießmann
>> <andreas.devel@googlemail.com> wrote:
>>>
>>> Hi Bo,
>>>
>>> On 22.05.13 10:45, Bo Shen wrote:
>>>>
>>>> Hi Andreas,
>>>>
>>>> On 5/14/2013 05:31, Joe Hershberger wrote:
>>>>>
>>>>> On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann
>>>>> <andreas.devel@googlemail.com> wrote:
>>>>>>
>>>>>> Dear Bo Shen,
>>>>>>
>>>>>>
>>>>>> On 12.03.2013 07:15, Bo Shen wrote:
>>>>>>>
>>>>>>>
>>>>>>> Add macb support for sama5d3x devices
>>>>>>>
>>>>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>>>>> ---
>>>>>>> change in v2:
>>>>>>>      No change
>>>>>>> ---
>>>>>>>     drivers/net/macb.c |    6 ++++--
>>>>>>>     1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>>>>>>> index 8bacbda..9e7fbc6 100644
>>>>>>> --- a/drivers/net/macb.c
>>>>>>> +++ b/drivers/net/macb.c
>>>>>>> @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev,
>>>>>>> bd_t
>>>>>>> *bd)
>>>>>>>     #if   defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) ||
>>>>>>> \
>>>>>>>           defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>>>>>>> || \
>>>>>>>           defined(CONFIG_AT91SAM9G45) ||
>>>>>>> defined(CONFIG_AT91SAM9M10G45) || \
>>>>>>> -       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
>>>>>>> +       defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
>>>>>>> +       defined(CONFIG_SAMA5D3)
>>>>>>
>>>>>>
>>>>>>
>>>>>> I would like to apply http://patchwork.ozlabs.org/patch/239064/
>>>>>> instead of
>>>>>> this one.
>>>>>> Joe, do you have any objections?
>>>>>
>>>>>
>>>>> Agreed.
>>>>
>>>>
>>>> Just remind to take this patch: net: macb: using AT91FAMILY replace
>>>> #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb
>>>> won't work with sama5d3xek board.
>>>
>>>
>>> I thought this would go through Joe's tree. There are some patches
>>> delegated to him regarding sama5 network too (gmac). I could pick up
>>> this single patch however, lets wait some days for Joe to work on the
>>> whole series.
>>
>>
>>
>> Yes, I hope to be getting to patches assigned to me in patchwork in
>> the next week or so.
>
>
> When will these patches will be dealt.

I've got all the patches in my local repo and I'm build testing them.
I'll likely send a PR by the end of today or tomorrow.

Thanks,
-Joe

Patch

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 8bacbda..9e7fbc6 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -469,7 +469,8 @@  static int macb_init(struct eth_device *netdev, bd_t *bd)
 #if	defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
 	defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \
 	defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
-	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
+	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
+	defined(CONFIG_SAMA5D3)
 	macb_writel(macb, USRIO, MACB_BIT(RMII) | MACB_BIT(CLKEN));
 #else
 	macb_writel(macb, USRIO, 0);
@@ -478,7 +479,8 @@  static int macb_init(struct eth_device *netdev, bd_t *bd)
 #if	defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
 	defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \
 	defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
-	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5)
+	defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \
+	defined(CONFIG_SAMA5D3)
 	macb_writel(macb, USRIO, MACB_BIT(CLKEN));
 #else
 	macb_writel(macb, USRIO, MACB_BIT(MII));