From patchwork Tue Mar 12 00:21:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jing Yu X-Patchwork-Id: 226725 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 27C892C0294 for ; Tue, 12 Mar 2013 11:21:43 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1363652504; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:Date:Message-ID: Subject:From:To:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=NcnEAwLBrpYkRH5l9lZV 8SgTVis=; b=RUkueTZL+OGEWti/9eblDeqejSt9bN9vb1W84OO608i9GoqQQRAy gx7uMtkhz6AmJCMy2YOLCRibsaJvn0tVt8GV3NZwVCW2vUu4kEKNlxRmb9eaFpTb xoJ0FKLrVzxIlophhVwgvub1/H/r1aBjRfClCMhCommgw3n+MsCZfMk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:X-Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Content-Type:Content-Transfer-Encoding:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=tHUgA+K6SMR5MXk1zGYhqhJuLqde1wOHZ/IScPPViKjdujRsez6zjj60dRTFGx D4oV2YiOHmOYpXjj8AUS9/t+jIYn4lP/miiR2Yhi+Ta+p/ajEUc0QhhD93dO4tz4 8rNoriFSg4WYVc79C7N8FqW7v2TgtME7HImhqHtLpm3uA=; Received: (qmail 20112 invoked by alias); 12 Mar 2013 00:21:34 -0000 Received: (qmail 20098 invoked by uid 22791); 12 Mar 2013 00:21:33 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_GR X-Spam-Check-By: sourceware.org Received: from mail-lb0-f173.google.com (HELO mail-lb0-f173.google.com) (209.85.217.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 00:21:16 +0000 Received: by mail-lb0-f173.google.com with SMTP id gf7so3639331lbb.18 for ; Mon, 11 Mar 2013 17:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding :x-gm-message-state; bh=MJO0Ds4RPLqA8s2HQIUhv42i99wUoE4jwFhFeboxhMw=; b=O31OwVcYguojSYg1XRwNqSWQPgQxmW7lC5yVaGU/X6wenSZw8O9O69hLxStWQrwgP/ uEycB3egGw/ruwCWHlMhvk/bNYq7LpSzEruJdp10yROtcGY/cnrGvOQu9B1LI0QHy3LP cAghB9PQK5t2ts2cAoAKj47kA5JqZm4Vlh5YhDyuu3EvmNAXNfG25wPlnGTcERtQ3uGl RgBmKwwUx9mYOFwoDtRWdT6STCojpTU2rbIwU87PL+3DSwiBwViCKIxSkrgAy2vwzB8e yImJjN3YNYbhbtg2WoT9yBtkYp3Z+t569BYJQ72QCV5m6nSwzsAl7XChymYuTsPOru8v YdGQ== MIME-Version: 1.0 X-Received: by 10.152.133.67 with SMTP id pa3mr11766257lab.44.1363047674408; Mon, 11 Mar 2013 17:21:14 -0700 (PDT) Received: by 10.112.135.10 with HTTP; Mon, 11 Mar 2013 17:21:14 -0700 (PDT) In-Reply-To: <20130312000627.DC9C660488@jingyu.mtv.corp.google.com> References: <20130312000627.DC9C660488@jingyu.mtv.corp.google.com> Date: Mon, 11 Mar 2013 17:21:14 -0700 Message-ID: Subject: Re: [trunk][google/gcc47]Add dependence of configure-target-libmudflap on configure-target-libstdc++-v3 (issue7740043) From: Jing Yu To: gcc-patches , reply@codereview.appspotmail.com X-Gm-Message-State: ALoCoQmeNeT/Kc8HgmvvQgEd9fxZ138u1JI/cZuaimVojDFBZI5a8YuRXg0nZNeRyalDOvlrsckodbiP8d9FtZ7Xx1CtJM7bsygG0JmYqF919K0rwfG7hNCUdjZ0TfXFogJ2KLClGwjOHvipBD97P1ltPcCQHhREpQ0F8qwuv0f2JCOwQk5dEQmHbtVLlW4x4UJkf8CsxEGD X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Don't know why the email body became attachment. Sent it again. The review link is https://codereview.appspot.com/7740043 Hi Diego, The nightly build of gcc-4.7 based ppc64 and ppc32 crosstools have failed since the build server upgraded to gPrecise one week ago. Log shows a configuration fa ilure on libmudflap. checking for suffix of object files... /lib/cpp configure: error: in `/g/nightly/build/work/gcc-4.7.x-grtev3-powerpc32-8540/rpmbuild/BUILD/.../powerpc-grtev3-linux-gnu/libmudflap': configure: error: C++ preprocessor "/lib/cpp" fails sanity check See `config.log' for more details. There is no /lib/cpp on gprecise server, though it should not be used here. What happened was that libmudflap configure looks for a preprocessor by trying $CXX -E and then backing off to /lib/cpp. $CXX -E is failing with "unrecognized command line option ‘-funconfigured-libstdc++’", and the /lib/cpp backstop then fails also. The -funconfigured-libstdc++ is because configure can't find libstdc++/scripts/testsuite_flags. This is a so-far undiagnosed race in gcc make, masked where /lib/cpp is available. And that's absent because in this build, for whatever reason, libstdc++ loses a race with libmudflap. The theory is confirmed by: 1) if we force --job=1, build can succeed 2) If we apply the following patch to build-gcc/Makefile, build can succeed. After removing this dependency, build fails with the same error again. Is this patch ok for google/gcc-4_7? If the same issue exists on upstream trunk, how does the patch sound to trunk? Thanks, Jing 2013-03-11 Jing Yu * Makefile.in: (maybe-configure-target-libmudflap): Add dependence on configure-target-libstdc++-v3. Index: Makefile.in =================================================================== --- Makefile.in (revision 196604) +++ Makefile.in (working copy) @@ -31879,6 +31879,9 @@ maybe-configure-target-libmudflap: @if gcc-bootstrap configure-target-libmudflap: stage_current @endif gcc-bootstrap +@if target-libstdc++-v3 +configure-target-libmudflap: configure-target-libstdc++-v3 +@endif target-libstdc++-v3 @if target-libmudflap maybe-configure-target-libmudflap: configure-target-libmudflap configure-target-libmudflap: