Patchwork [3.5.y.z,extended,stable] Patch "hwmon: (sht15) Check return value of regulator_enable()" has been added to staging queue

mail settings
Submitter Luis Henriques
Date March 11, 2013, 12:07 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/226548/
State New
Headers show


Luis Henriques - March 11, 2013, 12:07 p.m.
This is a note to let you know that I have just added a patch titled

    hwmon: (sht15) Check return value of regulator_enable()

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From b759601033bf8191e89df1c162fd142545914b11 Mon Sep 17 00:00:00 2001
From: Mark Brown <>
Date: Sat, 2 Mar 2013 15:33:30 +0800
Subject: [PATCH] hwmon: (sht15) Check return value of regulator_enable()

commit 3e78080f81481aa8340374d5a37ae033c1cf4272 upstream.

Not having power is a pretty serious error so check that we are able to
enable the supply and error out if we can't.

Signed-off-by: Mark Brown <>
Signed-off-by: Guenter Roeck <>
Signed-off-by: Luis Henriques <>
 drivers/hwmon/sht15.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)



diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c
index 8b011d0..eb01802 100644
--- a/drivers/hwmon/sht15.c
+++ b/drivers/hwmon/sht15.c
@@ -926,7 +926,13 @@  static int __devinit sht15_probe(struct platform_device *pdev)
 		if (voltage)
 			data->supply_uV = voltage;

-		regulator_enable(data->reg);
+		ret = regulator_enable(data->reg);
+		if (ret != 0) {
+			dev_err(&pdev->dev,
+				"failed to enable regulator: %d\n", ret);
+			return ret;
+		}
 		 * Setup a notifier block to update this if another device
 		 * causes the voltage to change