Patchwork [1/3] Revert "block: complete all IOs before .bdrv_truncate"

login
register
mail settings
Submitter Peter Lieven
Date March 11, 2013, 10:03 a.m.
Message ID <513DABF0.7010906@dlhnet.de>
Download mbox | patch
Permalink /patch/226509/
State New
Headers show

Comments

Peter Lieven - March 11, 2013, 10:03 a.m.
brdv_truncate() is also called from readv/writev commands on self-
growing file based storage. this will result in requests waiting
for theirselves to complete.

This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33.
---
  block.c |    4 ----
  1 file changed, 4 deletions(-)
Kevin Wolf - March 19, 2013, 1:10 p.m.
Am 11.03.2013 um 11:03 hat Peter Lieven geschrieben:
> brdv_truncate() is also called from readv/writev commands on self-
> growing file based storage. this will result in requests waiting
> for theirselves to complete.
> 
> This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33.

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/block.c b/block.c
index 124a9eb..60c246a 100644
--- a/block.c
+++ b/block.c
@@ -2449,10 +2449,6 @@  int bdrv_truncate(BlockDriverState *bs, int64_t offset)
          return -EACCES;
      if (bdrv_in_use(bs))
          return -EBUSY;
-
-    /* There better not be any in-flight IOs when we truncate the device. */
-    bdrv_drain_all();
-
      ret = drv->bdrv_truncate(bs, offset);
      if (ret == 0) {
          ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);