From patchwork Mon Mar 11 08:44:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laxman Dewangan X-Patchwork-Id: 226492 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-x23a.google.com (mail-vb0-x23a.google.com [IPv6:2607:f8b0:400c:c02::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4A14E2C02A3 for ; Mon, 11 Mar 2013 19:47:32 +1100 (EST) Received: by mail-vb0-f58.google.com with SMTP id fa15sf1376228vbb.13 for ; Mon, 11 Mar 2013 01:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-pgp-universal:from :to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=F1FOhS1AnANmickImPrNbzQ+u72lcI0E8Rqr1Fga8Ak=; b=PTzJ9HWUDiapQTh4HdDRa5hNKjQaExo9wF2U7Glt4CXaWgu+wpZxYAjIroRzTzM0IW FtV7TU7/dIM4ygx+5OQ40/HOSKB+zM/HrXNTaSoWeMJGtRSTe84gjDCSOIHIR3E7ccN8 3YEcU/h/289xYYW/37bda2KLuDFlJWpV7Hs2/brqZ5g1C5JRMSsK6UMCvgwAQkHBATV3 2as27v+ezOH3Duh9B3pYAb4UnZHCPLywOVe6FhZlt9ZTJT83gbP4mW5t+lRSBipvSbjO QPZWgJPOCaEE5NHtFnOMYByVXRttVKmqBwoV0HAfFs2SZ0GLBsFqVs4TPe2VaC1DMUWb U2KQ== X-Received: by 10.50.214.36 with SMTP id nx4mr801002igc.6.1362991649353; Mon, 11 Mar 2013 01:47:29 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.6.193 with SMTP id d1ls1095341iga.33.canary; Mon, 11 Mar 2013 01:47:29 -0700 (PDT) X-Received: by 10.68.138.165 with SMTP id qr5mr7297435pbb.8.1362991649006; Mon, 11 Mar 2013 01:47:29 -0700 (PDT) Received: from hqemgate04.nvidia.com (hqemgate04.nvidia.com. [216.228.121.35]) by gmr-mx.google.com with ESMTPS id ka10si4907070pbb.2.2013.03.11.01.47.28 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 11 Mar 2013 01:47:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of ldewangan@nvidia.com designates 216.228.121.35 as permitted sender) client-ip=216.228.121.35; Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate04.nvidia.com id ; Mon, 11 Mar 2013 01:46:37 -0700 Received: from hqemhub02.nvidia.com ([172.17.108.22]) by hqnvupgp08.nvidia.com (PGP Universal service); Mon, 11 Mar 2013 01:40:16 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 11 Mar 2013 01:40:16 -0700 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by hqemhub02.nvidia.com (172.20.150.31) with Microsoft SMTP Server id 8.3.298.1; Mon, 11 Mar 2013 01:46:41 -0700 Received: from thelma.nvidia.com (Not Verified[172.16.212.77]) by hqnvemgw01.nvidia.com with MailMarshal (v7,1,2,5326) id ; Mon, 11 Mar 2013 01:46:41 -0700 Received: from ldewangan-ubuntu.nvidia.com ([10.19.65.30]) by thelma.nvidia.com (8.13.8+Sun/8.8.8) with ESMTP id r2B8kWXu028086; Mon, 11 Mar 2013 01:46:39 -0700 (PDT) From: Laxman Dewangan To: , CC: , , , , , Laxman Dewangan Subject: [rtc-linux] [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management Date: Mon, 11 Mar 2013 14:14:25 +0530 Message-ID: <1362991468-30226-3-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 X-Original-Sender: ldewangan@nvidia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of ldewangan@nvidia.com designates 216.228.121.35 as permitted sender) smtp.mail=ldewangan@nvidia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Make the Tegra RTC controller driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct platform_driver. Signed-off-by: Laxman Dewangan Reviewed-by: Thierry Reding --- Changes from V1: - Use SIMPLE_DEV_PM_OPS drivers/rtc/rtc-tegra.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index d64cde6..6373eb7 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -26,6 +26,7 @@ #include #include #include +#include /* set to 1 = busy every eight 32kHz clocks during copy of sec+msec to AHB */ #define TEGRA_RTC_REG_BUSY 0x004 @@ -391,10 +392,9 @@ static int __exit tegra_rtc_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) +static int tegra_rtc_suspend(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); tegra_rtc_wait_while_busy(dev); @@ -416,10 +416,9 @@ static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int tegra_rtc_resume(struct platform_device *pdev) +static int tegra_rtc_resume(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); dev_vdbg(dev, "Resume (device_may_wakeup=%d)\n", device_may_wakeup(dev)); @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct platform_device *pdev) } #endif +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, tegra_rtc_resume); + static void tegra_rtc_shutdown(struct platform_device *pdev) { dev_vdbg(&pdev->dev, "disabling interrupts.\n"); @@ -445,11 +446,8 @@ static struct platform_driver tegra_rtc_driver = { .name = "tegra_rtc", .owner = THIS_MODULE, .of_match_table = tegra_rtc_dt_match, + .pm = &tegra_rtc_pm_ops, }, -#ifdef CONFIG_PM_SLEEP - .suspend = tegra_rtc_suspend, - .resume = tegra_rtc_resume, -#endif }; static int __init tegra_rtc_init(void)