| Message ID | 1362928719-13532-1-git-send-email-christoph.paasch@uclouvain.be |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 2013-03-10 at 16:18 +0100, Christoph Paasch wrote: > tw_cookie_values is never used in the TCP-stack. > > It was added by 435cf559f (TCPCT part 1d: define TCP cookie option, > extend existing struct's), but already at that time it was not used at > all, nor mentioned in the commit-message. > > Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be> > --- > include/linux/tcp.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index f28408c..515c374 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -361,10 +361,6 @@ struct tcp_timewait_sock { > #ifdef CONFIG_TCP_MD5SIG > struct tcp_md5sig_key *tw_md5_key; > #endif > - /* Few sockets in timewait have cookies; in that case, then this > - * object holds a reference to them (tw_cookie_values->kref). > - */ > - struct tcp_cookie_values *tw_cookie_values; > }; > > static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk) Acked-by: Eric Dumazet <edumazet@google.com> Actually, I am not sure TCPCT is really used... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday 10 March 2013 17:06:10 Eric Dumazet wrote: > Acked-by: Eric Dumazet <edumazet@google.com> > > Actually, I am not sure TCPCT is really used... Yes, while looking through the code it seems to me that it is far from respecting RFC 6013. It uses 253 as option-number and has comments saying "not yet implemented" (e.g., tcp_parse_options). Should it be removed? Christoph
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Sun, 10 Mar 2013 17:06:10 +0100 > On Sun, 2013-03-10 at 16:18 +0100, Christoph Paasch wrote: >> tw_cookie_values is never used in the TCP-stack. >> >> It was added by 435cf559f (TCPCT part 1d: define TCP cookie option, >> extend existing struct's), but already at that time it was not used at >> all, nor mentioned in the commit-message. >> >> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be> ... > Acked-by: Eric Dumazet <edumazet@google.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/tcp.h b/include/linux/tcp.h index f28408c..515c374 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -361,10 +361,6 @@ struct tcp_timewait_sock { #ifdef CONFIG_TCP_MD5SIG struct tcp_md5sig_key *tw_md5_key; #endif - /* Few sockets in timewait have cookies; in that case, then this - * object holds a reference to them (tw_cookie_values->kref). - */ - struct tcp_cookie_values *tw_cookie_values; }; static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk)
tw_cookie_values is never used in the TCP-stack. It was added by 435cf559f (TCPCT part 1d: define TCP cookie option, extend existing struct's), but already at that time it was not used at all, nor mentioned in the commit-message. Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be> --- include/linux/tcp.h | 4 ---- 1 file changed, 4 deletions(-)