diff mbox

wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup

Message ID 1362920987-6679-1-git-send-email-epure.andrei@gmail.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Andrei Epure March 10, 2013, 1:09 p.m. UTC
Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
---
 drivers/net/wireless/rtlwifi/usb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Larry Finger March 11, 2013, 8:46 p.m. UTC | #1
On 03/10/2013 08:09 AM, Andrei Epure wrote:
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
>   drivers/net/wireless/rtlwifi/usb.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
> index 156b527..b5c80b5 100644
> --- a/drivers/net/wireless/rtlwifi/usb.c
> +++ b/drivers/net/wireless/rtlwifi/usb.c
> @@ -224,10 +224,9 @@ static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
>   	u8 *buffer;
>
>   	wvalue = (u16)(addr & 0x0000ffff);
> -	buffer = kmalloc(len, GFP_ATOMIC);
> +	buffer = kmemdup(data, len, GFP_ATOMIC);
>   	if (!buffer)
>   		return;
> -	memcpy(buffer, data, len);
>   	usb_control_msg(udev, pipe, request, reqtype, wvalue,
>   			index, buffer, len, 50);

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks,

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
index 156b527..b5c80b5 100644
--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c
@@ -224,10 +224,9 @@  static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
 	u8 *buffer;
 
 	wvalue = (u16)(addr & 0x0000ffff);
-	buffer = kmalloc(len, GFP_ATOMIC);
+	buffer = kmemdup(data, len, GFP_ATOMIC);
 	if (!buffer)
 		return;
-	memcpy(buffer, data, len);
 	usb_control_msg(udev, pipe, request, reqtype, wvalue,
 			index, buffer, len, 50);