Patchwork [RESEND] dbus: add missing signal description for WPS (7)

login
register
mail settings
Submitter Peter Wu
Date March 10, 2013, 12:05 p.m.
Message ID <2236219.46Qve5pfpc@al>
Download mbox | patch
Permalink /patch/226426/
State Not Applicable
Headers show

Comments

Peter Wu - March 10, 2013, 12:05 p.m.
Commit caff399250311abfea3376b38530a88bb78b957d added a property named "WPS" to
the dbus interface. It did not add the new WPAS_DBUS_BSS_PROP_WPS property to
the function responsible for marking changed properties though. This cause the
following messages to be printed repeatedly to syslog:

    dbus: wpas_dbus_bss_signal_prop_changed: Unknown Property value 7

Signed-hostap: Peter Wu <lekensteyn@gmail.com>
---
Compile-tested, not with WPS hardware.
---
 wpa_supplicant/dbus/dbus_new.c | 3 +++
 1 file changed, 3 insertions(+)

 		break;
Jouni Malinen - March 10, 2013, 1:57 p.m.
On Sun, Mar 10, 2013 at 01:05:56PM +0100, Peter Wu wrote:
> Commit caff399250311abfea3376b38530a88bb78b957d added a property named "WPS" to
> the dbus interface. It did not add the new WPAS_DBUS_BSS_PROP_WPS property to
> the function responsible for marking changed properties though. This cause the
> following messages to be printed repeatedly to syslog:
> 
>     dbus: wpas_dbus_bss_signal_prop_changed: Unknown Property value 7

This was already applied a month ago:
http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=commitdiff;h=a24a5ccb28c2bc7af466e47b84dc346e6c54f062
Peter Wu - March 10, 2013, 2:34 p.m.
On Sunday 10 March 2013 15:57:20 Jouni Malinen wrote:
> On Sun, Mar 10, 2013 at 01:05:56PM +0100, Peter Wu wrote:
> > Commit caff399250311abfea3376b38530a88bb78b957d added a property named
> > "WPS" to the dbus interface. It did not add the new
> > WPAS_DBUS_BSS_PROP_WPS property to the function responsible for marking
> > changed properties though. This cause the>
> > following messages to be printed repeatedly to syslog:
> > 
> >     dbus: wpas_dbus_bss_signal_prop_changed: Unknown Property value 7
> 
> This was already applied a month ago:
> http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=commitdiff;h=a24a5ccb28c2bc7af
> 466e47b84dc346e6c54f062

Oh, I did not check the repo, I thought the mail got lost somehow as I did not 
receive a reply to the previous mail.

Thanks,
Peter

Patch

diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
index 8bc6618..5b4a0a4 100644
--- a/wpa_supplicant/dbus/dbus_new.c
+++ b/wpa_supplicant/dbus/dbus_new.c
@@ -1808,6 +1808,9 @@  void wpas_dbus_bss_signal_prop_changed(struct 
wpa_supplicant *wpa_s,
 	case WPAS_DBUS_BSS_PROP_RSN:
 		prop = "RSN";
 		break;
+	case WPAS_DBUS_BSS_PROP_WPS:
+		prop = "WPS";
+		break;
 	case WPAS_DBUS_BSS_PROP_IES:
 		prop = "IEs";