Patchwork [4/4] directfb: fixing typo in variables

login
register
mail settings
Submitter Carsten Schoenert
Date March 10, 2013, 9:47 a.m.
Message ID <1362908858-6340-5-git-send-email-c.schoenert@gmail.com>
Download mbox | patch
Permalink /patch/226422/
State Accepted
Commit 9bff3c65259911dc075af14d425cd124b7da2ecf
Headers show

Comments

Carsten Schoenert - March 10, 2013, 9:47 a.m.
From: Carsten Schoenert <c.schoenert@gmail.com>

Signed-off-by: Carsten Schoenert <c.schoenert@gmail.com>
---
 package/directfb/Config.in   |    4 ++--
 package/directfb/directfb.mk |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Thomas Petazzoni - March 10, 2013, 10:25 a.m.
Dear Carsten Schoenert,

On Sun, 10 Mar 2013 10:47:38 +0100, Carsten Schoenert wrote:
> From: Carsten Schoenert <c.schoenert@gmail.com>
> 
> Signed-off-by: Carsten Schoenert <c.schoenert@gmail.com>
> ---
>  package/directfb/Config.in   |    4 ++--
>  package/directfb/directfb.mk |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 3d22e15..f5759db 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -115,13 +115,13 @@ config BR2_PACKAGE_DIRECTFB_PNG
>  	default y
>  	select BR2_PACKAGE_LIBPNG
>  
> -config BR2_PACKAGE_DIRECTB_DITHER_RGB16
> +config BR2_PACKAGE_DIRECTFB_DITHER_RGB16
>  	bool "enable advanced dithering of RGB16 surfaces"
>  	help
>  	  Enable dithering when loading images to RGB16 surfaces.
>  	  This increases the data section by 64 KBytes.


This is good, but since you're renaming configuration options, you
should add something to the main Config.in.legacy:

config BR2_PACKAGE_DIRECTB_DITHER_RGB16
	bool "DirectFB RGB16 dithering option has been renamed"
	select BR2_PACKAGE_DIRECTFB_DITHER_RGB16
	select BR2_LEGACY

This way, users who will upgrade will be automatically notified of the
option rename.

Best regards,

Thomas
Carsten Schoenert - March 10, 2013, 12:23 p.m.
Hello Thomas,

Am 10.03.2013 11:25, schrieb Thomas Petazzoni:
> This is good, but since you're renaming configuration options, you
> should add something to the main Config.in.legacy:
> 
> config BR2_PACKAGE_DIRECTB_DITHER_RGB16
> 	bool "DirectFB RGB16 dithering option has been renamed"
> 	select BR2_PACKAGE_DIRECTFB_DITHER_RGB16
> 	select BR2_LEGACY
> 
> This way, users who will upgrade will be automatically notified of the
> option rename.

Ahh, o.k. Don't know about this file, thanks for pointing at it. I take
a look at it and rework it.

Regards
Carsten

Patch

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 3d22e15..f5759db 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -115,13 +115,13 @@  config BR2_PACKAGE_DIRECTFB_PNG
 	default y
 	select BR2_PACKAGE_LIBPNG
 
-config BR2_PACKAGE_DIRECTB_DITHER_RGB16
+config BR2_PACKAGE_DIRECTFB_DITHER_RGB16
 	bool "enable advanced dithering of RGB16 surfaces"
 	help
 	  Enable dithering when loading images to RGB16 surfaces.
 	  This increases the data section by 64 KBytes.
 
-config BR2_PACKAGE_DIRECTB_TESTS
+config BR2_PACKAGE_DIRECTFB_TESTS
 	bool "build directfb tests"
 
 endif # BR2_PACKAGE_DIRECTFB
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 8c701db..5ead084 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -108,13 +108,13 @@  else
 DIRECTFB_CONF_OPT += --disable-jpeg
 endif
 
-ifeq ($(BR2_PACKAGE_DIRECTB_DITHER_RGB16),y)
+ifeq ($(BR2_PACKAGE_DIRECTFB_DITHER_RGB16),y)
 DIRECTFB_CONF_OPT += --with-dither-rgb16=advanced
 else
 DIRECTFB_CONF_OPT += --with-dither-rgb16=none
 endif
 
-ifeq ($(BR2_PACKAGE_DIRECTB_TESTS),y)
+ifeq ($(BR2_PACKAGE_DIRECTFB_TESTS),y)
 DIRECTFB_CONF_OPT += --with-tests
 endif