Patchwork quota: select BR2_PACKAGE_UTIL_LINUX_BINARIES

login
register
mail settings
Submitter Gustavo Zacarias
Date March 10, 2013, 9:27 a.m.
Message ID <1362907622-27511-1-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/226418/
State Superseded
Headers show

Comments

Gustavo Zacarias - March 10, 2013, 9:27 a.m.
Missed this one package that needs a util-linux binary, fixes:
http://autobuild.buildroot.net/results/bc3c75e7c60fe6db54ea56dd7c398ba7878bff83/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/quota/Config.in | 1 +
 1 file changed, 1 insertion(+)
Peter Korsgaard - March 10, 2013, 10:09 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Missed this one package that needs a util-linux binary, fixes:
 Gustavo> http://autobuild.buildroot.net/results/bc3c75e7c60fe6db54ea56dd7c398ba7878bff83/

Ehh, that log rather looks like BR2_PACKAGE_UTIL_LINUX_MOUNT needing to
select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT?


 Gustavo> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 Gustavo> ---
 Gustavo>  package/quota/Config.in | 1 +
 Gustavo>  1 file changed, 1 insertion(+)

 Gustavo> diff --git a/package/quota/Config.in b/package/quota/Config.in
 Gustavo> index f6341d3..9f1704b 100644
 Gustavo> --- a/package/quota/Config.in
 Gustavo> +++ b/package/quota/Config.in
 Gustavo> @@ -4,6 +4,7 @@ config BR2_PACKAGE_QUOTA
 Gustavo>  	depends on BR2_USE_WCHAR
 Gustavo>  	depends on BR2_USE_MMU # fork()
 Gustavo>  	select BR2_PACKAGE_UTIL_LINUX
 Gustavo> +	select BR2_PACKAGE_UTIL_LINUX_BINARIES
 Gustavo>  	select BR2_PACKAGE_UTIL_LINUX_MOUNT
 Gustavo>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 Gustavo>  	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 Gustavo> -- 
 Gustavo> 1.8.1.5

 Gustavo> _______________________________________________
 Gustavo> buildroot mailing list
 Gustavo> buildroot@busybox.net
 Gustavo> http://lists.busybox.net/mailman/listinfo/buildroot
Gustavo Zacarias - March 10, 2013, 11:19 p.m.
On 03/10/2013 07:09 PM, Peter Korsgaard wrote:
> Ehh, that log rather looks like BR2_PACKAGE_UTIL_LINUX_MOUNT needing to
> select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT?

I'd rather get all the libs enabled when any binaries are wanted.
Otherwise for each util-linux bump a full study of those details will
need to be done.
It's not like the libs take that much space....
And otherwise it'll be a hidden option without BINARIES being selected.
Regards.

Patch

diff --git a/package/quota/Config.in b/package/quota/Config.in
index f6341d3..9f1704b 100644
--- a/package/quota/Config.in
+++ b/package/quota/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_QUOTA
 	depends on BR2_USE_WCHAR
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_BINARIES
 	select BR2_PACKAGE_UTIL_LINUX_MOUNT
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC