| Message ID | 1362906925-45308-1-git-send-email-honkiko@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 2013-03-10 at 17:15 +0800, Hong Zhiguo wrote: > in the case of NET_SKBUFF_DATA_USES_OFFSET(on 64-bit arch), > skb->network_header is just offset over skb->head. > > Signed-off-by: Hong Zhiguo <honkiko@gmail.com> > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 90cee5b..378e0b9 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1705,7 +1705,7 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) > skb_reset_mac_header(skb2); > > if (skb_network_header(skb2) < skb2->data || > - skb2->network_header > skb2->tail) { > + skb_network_header(skb2) > skb2->tail) { > net_crit_ratelimited("protocol %04x is buggy, dev %s\n", > ntohs(skb2->protocol), > dev->name); Sorry I dont understand this patch. Could you elaborate ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 90cee5b..378e0b9 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1705,7 +1705,7 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) skb_reset_mac_header(skb2); if (skb_network_header(skb2) < skb2->data || - skb2->network_header > skb2->tail) { + skb_network_header(skb2) > skb2->tail) { net_crit_ratelimited("protocol %04x is buggy, dev %s\n", ntohs(skb2->protocol), dev->name);
in the case of NET_SKBUFF_DATA_USES_OFFSET(on 64-bit arch), skb->network_header is just offset over skb->head. Signed-off-by: Hong Zhiguo <honkiko@gmail.com> --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)