Patchwork [U-Boot] mx28evk: Disable CONFIG_CMD_I2C

login
register
mail settings
Submitter Fabio Estevam
Date March 8, 2013, 2:47 p.m.
Message ID <1362754030-8944-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/226135/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - March 8, 2013, 2:47 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

When loading a Freescale 2.6.35 on a mx28evk the following issue is seen:

sgtl5000_hw_read: read reg error : Reg 0x00
Device with ID register 0 is not a SGTL5000

Disabling CONFIG_CMD_I2C makes the sgtl5000 probe to succeed.

Mainline kernel does not show this problem.

Until the real cause is not identified, disable 'CONFIG_CMD_I2C' for the 
time being.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Stefano,

Since 2013.04 is approaching I prefer to disable this option until the real
cause is identified.

This patch applies on top of http://patchwork.ozlabs.org/patch/225950/

 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)
Stefano Babic - March 20, 2013, 10:41 a.m.
On 08/03/2013 15:47, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> When loading a Freescale 2.6.35 on a mx28evk the following issue is seen:
> 
> sgtl5000_hw_read: read reg error : Reg 0x00
> Device with ID register 0 is not a SGTL5000
> 
> Disabling CONFIG_CMD_I2C makes the sgtl5000 probe to succeed.
> 
> Mainline kernel does not show this problem.
> 
> Until the real cause is not identified, disable 'CONFIG_CMD_I2C' for the 
> time being.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Stefano,
> 
> Since 2013.04 is approaching I prefer to disable this option until the real
> cause is identified.
> 
> This patch applies on top of http://patchwork.ozlabs.org/patch/225950/
> 
>  include/configs/mx28evk.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 9cc236f..cf93ec8 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -68,7 +68,6 @@
>  #define CONFIG_CMD_SPI
>  #define CONFIG_CMD_USB
>  #define CONFIG_CMD_BOOTZ
> -#define CONFIG_CMD_I2C
>  #define CONFIG_CMD_NAND
>  
>  /*
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 9cc236f..cf93ec8 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -68,7 +68,6 @@ 
 #define CONFIG_CMD_SPI
 #define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
-#define CONFIG_CMD_I2C
 #define CONFIG_CMD_NAND
 
 /*