Patchwork ARM: Dove: add RTC device node

login
register
mail settings
Submitter Jean-Francois Moine
Date March 8, 2013, 11:13 a.m.
Message ID <20130308121317.4ee83c0a@armhf>
Download mbox | patch
Permalink /patch/226088/
State New
Headers show

Comments

Jean-Francois Moine - March 8, 2013, 11:13 a.m.
The commit 48be9ac930086f removed the RTC initialization.
This patch re-enables the RTC via the DT.

Signed-off-by: Jean-François Moine <moinejf@free.fr>
---
 arch/arm/boot/dts/dove.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
Sergei Shtylyov - March 8, 2013, 8:53 p.m.
Hello.

On 08-03-2013 15:13, Jean-Francois Moine wrote:

> The commit 48be9ac930086f

    Please also specify the summary line for that commit in parens (or however 
you like).

> removed the RTC initialization.
> This patch re-enables the RTC via the DT.

> Signed-off-by: Jean-François Moine <moinejf@free.fr>

WBR, Sergei
Jason - March 8, 2013, 9:58 p.m.
On Fri, Mar 08, 2013 at 12:13:17PM +0100, Jean-Francois Moine wrote:
> The commit 48be9ac930086f removed the RTC initialization.
> This patch re-enables the RTC via the DT.
> 
> Signed-off-by: Jean-François Moine <moinejf@free.fr>
> ---
>  arch/arm/boot/dts/dove.dtsi |    5 +++++
>  1 file changed, 5 insertions(+)

Applied to mvebu/fixes with the following commit entry:

    ARM: Dove: add RTC device node

    The commit:

      48be9ac ARM: Dove: split legacy and DT setup

    removed the RTC initialization.  This patch re-enables the RTC
    via the DT.


thx,

Jason.
Arnd Bergmann - March 8, 2013, 11:12 p.m.
On Friday 08 March 2013, Jason Cooper wrote:
> Applied to mvebu/fixes with the following commit entry:
> 
>     ARM: Dove: add RTC device node
> 
>     The commit:
> 
>       48be9ac ARM: Dove: split legacy and DT setup
> 
>     removed the RTC initialization.  This patch re-enables the RTC
>     via the DT.

Looks good. FWIW, the style I tend to use is


|ARM: Dove: add RTC device node
|
|The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
|initialization.  This patch re-enables the RTC via the DT.

I don't think that there is a wide agreement on how to refer to other
patches yet, but I do a lot of regression fixes like that, so maybe I
can start a trend here.

	ARnd
Jason - March 9, 2013, 3:12 a.m.
On Fri, Mar 08, 2013 at 11:12:02PM +0000, Arnd Bergmann wrote:
> On Friday 08 March 2013, Jason Cooper wrote:
> > Applied to mvebu/fixes with the following commit entry:
> > 
> >     ARM: Dove: add RTC device node
> > 
> >     The commit:
> > 
> >       48be9ac ARM: Dove: split legacy and DT setup
> > 
> >     removed the RTC initialization.  This patch re-enables the RTC
> >     via the DT.
> 
> Looks good. FWIW, the style I tend to use is
> 
> 
> |ARM: Dove: add RTC device node
> |
> |The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
> |initialization.  This patch re-enables the RTC via the DT.
> 
> I don't think that there is a wide agreement on how to refer to other
> patches yet, but I do a lot of regression fixes like that, so maybe I
> can start a trend here.

Looks good to me.  flows a bit better than what I had.  I'll use that
from now on for anything I come across.

thx,

Jason.

Patch

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 46afade..28ff4dc 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -197,6 +197,11 @@ 
 			status = "disabled";
 		};
 
+		rtc@d8500 {
+			compatible = "marvell,orion-rtc";
+			reg = <0xd8500 0x20>;
+		};
+
 		crypto: crypto@30000 {
 			compatible = "marvell,orion-crypto";
 			reg = <0x30000 0x10000>,