From patchwork Fri Mar 8 09:01:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffen Trumtrar X-Patchwork-Id: 226060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-la0-x23f.google.com (mail-la0-x23f.google.com [IPv6:2a00:1450:4010:c03::23f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 5519B2C03BD for ; Fri, 8 Mar 2013 20:02:21 +1100 (EST) Received: by mail-la0-f63.google.com with SMTP id ec20sf615419lab.28 for ; Fri, 08 Mar 2013 01:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:received-spf:from:to :cc:subject:date:message-id:x-mailer:in-reply-to:references :x-sa-exim-connect-ip:x-sa-exim-mail-from:x-sa-exim-scanned :x-ptx-original-recipient:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=I6bciy5jatbva9KFsJKqHpSVwOlN4qXsjxy5FDK71q0=; b=UVi8sGYZE1B5zgksjmjtArsMf+DhlitfVe+yc887I3kK41SyQhi8rB/1EvYZcdH4uV v6341rP6eFZO5p536BFV25A0JiN8rvanwG+QXm/oCTi8kKFNLF8b9j725L3vS9j14HxY tY+Fv3WEJNnyyqkil0KxZ4rQFxSDgBkdixSXR/jM/Ssdst46f+7PF/NwM2oX7rrAicB6 uYKb+qwRZrQGUB5IFUx03cOuIsrDZpbjtNfz88CmQU0Trbprmm4YcLDqcNXogcX5Nec9 0ZcBWm4fm2swh4KQM7hf0DZ2KPJ0pYzPMnknCJN+jlLHRr+DSnJhYroZDeuq8uDIM4tT N5Pw== X-Received: by 10.180.20.98 with SMTP id m2mr113868wie.0.1362733337352; Fri, 08 Mar 2013 01:02:17 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.20.139 with SMTP id n11ls918053wie.28.canary; Fri, 08 Mar 2013 01:02:16 -0800 (PST) X-Received: by 10.15.21.137 with SMTP id d9mr1404614eeu.1.1362733336729; Fri, 08 Mar 2013 01:02:16 -0800 (PST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de. [2001:6f8:1178:4:290:27ff:fe1d:cc33]) by gmr-mx.google.com with ESMTPS id 47si1436121eeh.1.2013.03.08.01.02.16 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Mar 2013 01:02:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of str@pengutronix.de designates 2001:6f8:1178:4:290:27ff:fe1d:cc33 as permitted sender) client-ip=2001:6f8:1178:4:290:27ff:fe1d:cc33; Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1UDtBv-0000lP-Et; Fri, 08 Mar 2013 10:02:15 +0100 Received: from str by dude.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1UDtBt-0006dJ-DD; Fri, 08 Mar 2013 10:02:13 +0100 From: Steffen Trumtrar To: rtc-linux@googlegroups.com, devicetree-discuss@lists.ozlabs.org Cc: Shawn Guo , Alessandro Zummo , Steffen Trumtrar Subject: [rtc-linux] [PATCH v2 6/9] rtc: stmp3xxx: add sysfs entries for persistent regs Date: Fri, 8 Mar 2013 10:01:41 +0100 Message-Id: <1362733304-23037-7-git-send-email-s.trumtrar@pengutronix.de> X-Mailer: git-send-email 1.8.2.rc2 In-Reply-To: <1362733304-23037-1-git-send-email-s.trumtrar@pengutronix.de> References: <1362733304-23037-1-git-send-email-s.trumtrar@pengutronix.de> X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: str@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: rtc-linux@googlegroups.com X-Original-Sender: s.trumtrar@pengutronix.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of str@pengutronix.de designates 2001:6f8:1178:4:290:27ff:fe1d:cc33 as permitted sender) smtp.mail=str@pengutronix.de Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , The persistent registers 1-5 are completely software defined. To have access from userspace, export them via sysfs. Signed-off-by: Steffen Trumtrar --- drivers/rtc/rtc-stmp3xxx.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index cd844ec..3ca26ac 100644 --- a/drivers/rtc/rtc-stmp3xxx.c +++ b/drivers/rtc/rtc-stmp3xxx.c @@ -67,6 +67,8 @@ /* missing bitmask in headers */ #define STMP3XXX_RTC_PERSISTENT1_FORCE_UPDATER 0x80000000 +#define STMP3XXX_RTC_PERSISTENT_LEN (0xC0 - STMP3XXX_RTC_PERSISTENT1) + enum clock_source { MXS_UNKNOWN, MXS_OSC_24M, @@ -79,6 +81,9 @@ struct stmp3xxx_rtc_data { void __iomem *io; int irq_alarm; enum clock_source clk_src; +#if IS_ENABLED(CONFIG_RTC_INTF_SYSFS) + struct bin_attribute *persist; +#endif }; #if IS_ENABLED(CONFIG_STMP3XXX_RTC_WATCHDOG) @@ -267,6 +272,42 @@ static int stmp3xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) return 0; } +#if IS_ENABLED(CONFIG_RTC_INTF_SYSFS) +static ssize_t stmp3xxx_rtc_persist_read(struct file *filep, + struct kobject *kobj, + struct bin_attribute *bin_attr, + char *buf, loff_t off, size_t size) +{ + struct rtc_device *rtc = container_of(kobj, struct rtc_device, + dev.kobj); + struct device *dev = rtc->dev.parent; + struct stmp3xxx_rtc_data *rtc_data = dev_get_drvdata(dev); + ssize_t count; + + for (count = 0; size; size--, off++, count++) + *buf++ = readl(rtc_data->io + STMP3XXX_RTC_PERSISTENT1 + off); + + return count; +} + +static ssize_t stmp3xxx_rtc_persist_write(struct file *filep, + struct kobject *kobj, + struct bin_attribute *bin_attr, + char *buf, loff_t off, size_t size) +{ + struct rtc_device *rtc = container_of(kobj, struct rtc_device, + dev.kobj); + struct device *dev = rtc->dev.parent; + struct stmp3xxx_rtc_data *rtc_data = dev_get_drvdata(dev); + ssize_t count; + + for (count = 0; size; size--, off++, count++) + writel(*buf++, rtc_data->io + STMP3XXX_RTC_PERSISTENT1 + off); + + return count; +} +#endif + static struct rtc_class_ops stmp3xxx_rtc_ops = { .alarm_irq_enable = stmp3xxx_alarm_irq_enable, @@ -283,6 +324,11 @@ static int stmp3xxx_rtc_remove(struct platform_device *pdev) if (!rtc_data) return 0; +#if IS_ENABLED(CONFIG_RTC_INTF_SYSFS) + sysfs_remove_bin_file(&pdev->dev.kobj, rtc_data->persist); + kfree(rtc_data->persist); +#endif + writel(STMP3XXX_RTC_CTRL_ALARM_IRQ_EN, rtc_data->io + STMP3XXX_RTC_CTRL_CLR); free_irq(rtc_data->irq_alarm, &pdev->dev); @@ -389,8 +435,31 @@ static int stmp3xxx_rtc_probe(struct platform_device *pdev) } stmp3xxx_wdt_register(pdev); + +#if IS_ENABLED(CONFIG_RTC_INTF_SYSFS) + rtc_data->persist = kzalloc(sizeof(struct bin_attribute), GFP_KERNEL); + if (!rtc_data->persist) { + err = -ENOMEM; + goto out_persist; + } + + rtc_data->persist->attr.name = "persistent"; + rtc_data->persist->attr.mode = S_IRUGO | S_IWUSR; + sysfs_bin_attr_init(rtc_data->persist); + rtc_data->persist->read = stmp3xxx_rtc_persist_read; + rtc_data->persist->write = stmp3xxx_rtc_persist_write; + rtc_data->persist->size = STMP3XXX_RTC_PERSISTENT_LEN; + err = sysfs_create_bin_file(&rtc_data->rtc->dev.kobj, + rtc_data->persist); + if (err) { + kfree(rtc_data->persist); + goto out_persist; + } +#endif + return 0; +out_persist: out_irq_alarm: rtc_device_unregister(rtc_data->rtc); out_remap: