Patchwork [4/6] package/genimage: new host-only package

login
register
mail settings
Submitter Yann E. MORIN
Date March 7, 2013, 9:55 p.m.
Message ID <40cdfc7c804704b95c963d3c76852e6d2b82de31.1362693294.git.yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/225974/
State Changes Requested
Headers show

Comments

Yann E. MORIN - March 7, 2013, 9:55 p.m.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/Config.in.host          |    1 +
 package/genimage/Config.in.host |   12 ++++++++++++
 package/genimage/genimage.mk    |   12 ++++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 package/genimage/Config.in.host
 create mode 100644 package/genimage/genimage.mk
Thomas Petazzoni - March 10, 2013, 11:41 a.m.
Dear Yann E. MORIN,

On Thu,  7 Mar 2013 22:55:29 +0100, Yann E. MORIN wrote:

> +GENIMAGE_VERSION        = 4
> +GENIMAGE_SOURCE         = genimage-$(GENIMAGE_VERSION).tar.xz
> +GENIMAGE_SITE           = http://www.pengutronix.de/software/genimage/download/
> +GENIMAGE_DEPENDENCIES   = libconfuse

Even though it is a host package, we could add:

GENIMAGE_LICENSE = GPLv2

Unfortunately, there is no license file.

Thomas
Yann E. MORIN - March 10, 2013, 11:39 p.m.
Thomas, All,

On Sunday 10 March 2013 Thomas Petazzoni wrote:
> On Thu,  7 Mar 2013 22:55:29 +0100, Yann E. MORIN wrote:
> > +GENIMAGE_VERSION        = 4
> > +GENIMAGE_SOURCE         = genimage-$(GENIMAGE_VERSION).tar.xz
> > +GENIMAGE_SITE           = http://www.pengutronix.de/software/genimage/download/
> > +GENIMAGE_DEPENDENCIES   = libconfuse
> 
> Even though it is a host package, we could add:
> 
> GENIMAGE_LICENSE = GPLv2
> 
> Unfortunately, there is no license file.

I am a bit uneasy at adding licensing information for packages that are
purely host packages.

As you said in your other mail, this might confuse a user reviewing the
licensing terms.
But I will add it.

Thank you!

Regards,
Yann E. MORIN.
Thomas Petazzoni - March 11, 2013, 9:30 p.m.
Dear Yann E. MORIN,

On Mon, 11 Mar 2013 00:39:31 +0100, Yann E. MORIN wrote:

> I am a bit uneasy at adding licensing information for packages that are
> purely host packages.
> 
> As you said in your other mail, this might confuse a user reviewing the
> licensing terms.

I think this is not a good reason to not add the license. We already
have it in a number of packages that have a host variant. It should be
something for the licensing infrastructure to handle.

> But I will add it.

Thanks!

Thomas

Patch

diff --git a/package/Config.in.host b/package/Config.in.host
index 43f292c..c456d5d 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -3,6 +3,7 @@  menu "Host utilities"
 source "package/dfu-util/Config.in.host"
 source "package/dosfstools/Config.in.host"
 source "package/e2fsprogs/Config.in.host"
+source "package/genimage/Config.in.host"
 source "package/lpc3250loader/Config.in.host"
 source "package/omap-u-boot-utils/Config.in.host"
 source "package/openocd/Config.in.host"
diff --git a/package/genimage/Config.in.host b/package/genimage/Config.in.host
new file mode 100644
index 0000000..cfa267c
--- /dev/null
+++ b/package/genimage/Config.in.host
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_HOST_GENIMAGE
+	bool "host genimage"
+	help
+	  genimage is a tool to generate multiple filesystem and flash images
+	  from a given root filesystem tree. genimage is intended to be run
+	  in a fakeroot environment.
+	  
+	  Configuration is done is a config file parsed by libconfuse. Options
+	  like the path to tools can be given in environment variables, the config
+	  file or commandline switches.
+	  
+	  http://www.pengutronix.de/software/genimage/
diff --git a/package/genimage/genimage.mk b/package/genimage/genimage.mk
new file mode 100644
index 0000000..8fe9bf7
--- /dev/null
+++ b/package/genimage/genimage.mk
@@ -0,0 +1,12 @@ 
+#############################################################
+#
+# genimage
+#
+##############################################################
+
+GENIMAGE_VERSION        = 4
+GENIMAGE_SOURCE         = genimage-$(GENIMAGE_VERSION).tar.xz
+GENIMAGE_SITE           = http://www.pengutronix.de/software/genimage/download/
+GENIMAGE_DEPENDENCIES   = libconfuse
+
+$(eval $(host-autotools-package))