Patchwork [4/4] Added device tree entries for Legerity SLIC node on various Freescale Platforms

login
register
mail settings
Submitter Sandeep Singh
Date March 7, 2013, 11:27 a.m.
Message ID <1362655668-26721-4-git-send-email-Sandeep@freescale.com>
Download mbox | patch
Permalink /patch/225820/
State Changes Requested
Delegated to: Kumar Gala
Headers show

Comments

Sandeep Singh - March 7, 2013, 11:27 a.m.
SLIC device is connected on SPI bus on these platforms

Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
 arch/powerpc/boot/dts/p1010rdb.dtsi    |   13 ++++++++++++-
 arch/powerpc/boot/dts/p1020mbg-pc.dtsi |   19 +++++++++++++++++++
 arch/powerpc/boot/dts/p1020rdb-pc.dtsi |   18 ++++++++++++++++++
 arch/powerpc/boot/dts/p1020rdb.dtsi    |   17 +++++++++++++++++
 arch/powerpc/boot/dts/p1022ds.dtsi     |   17 +++++++++++++++++
 arch/powerpc/boot/dts/p1024rdb.dtsi    |   18 ++++++++++++++++++
 6 files changed, 101 insertions(+), 1 deletions(-)
Scott Wood - July 30, 2013, 10:40 p.m.
On Thu, Mar 07, 2013 at 04:57:48PM +0530, Sandeep Singh wrote:
> diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
> index b05dcb4..cec36a3 100644
> --- a/arch/powerpc/boot/dts/p1024rdb.dtsi
> +++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
> @@ -164,6 +164,19 @@
>  				label = "SPI JFFS2 RFS";
>  			};
>  		};
> +
> +                tdm_phy_0: slic@0 {
> +                        compatible = "zarlink,le88266", "tdm-phy-slic";
> +			reg = <1>;
> +			spi-max-frequency = <8000000>;
> +		};
> +
> +                tdm_phy_1: slic@1 {
> +                        compatible = "zarlink,le88266", "tdm-phy-slic";
> +			reg = <2>;
> +			spi-max-frequency = <8000000>;
> +		};
> +
>  	};
>  
>  	i2c@3000 {
> @@ -173,6 +186,11 @@
>  		};
>  	};
>  
> +        tdm@16000 {
> +                num-phy = <2>;
> +                phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
> +        };
> +
>  	usb@22000 {
>  		phy_type = "ulpi";
>  	};

Whitespace

What is "tdm-phy-slic"?  "num-phy"?  Document these in the binding and
use proper vendor prefixes.

Why "<&tdm_phy_0>, <&tdm_phy_1>" rather than "<&tdm_phy_0 &tdm_phy_1>"? 
And can you just use the length of phy-handle rather than having a
separate num-phy property?

-Scott

Patch

diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ec7c27a..b0a5908 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -1,7 +1,7 @@ 
 /*
  * P1010 RDB Device Tree Source stub (no addresses or top-level ranges)
  *
- * Copyright 2011 Freescale Semiconductor Inc.
+ * Copyright 2011-2012 Freescale Semiconductor Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
@@ -184,8 +184,19 @@ 
 				label = "SPI Flash JFFS2 RFS";
 			};
 		};
+
+		tdm_phy_0: slic@0 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <0>;
+			spi-max-frequency = <8000000>;
+		};
 	};
 
+        tdm@16000 {
+		num-phy = <1>;
+		phy-handle = <&tdm_phy_0>;
+        };
+
 	usb@22000 {
 		phy_type = "utmi";
 		dr_mode = "host";
diff --git a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
index a24699c..9119387 100644
--- a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
@@ -93,6 +93,25 @@ 
 		};
 	};
 
+	spi@7000 {
+		tdm_phy_0: slic@0 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <1>;
+			spi-max-frequency = <8000000>;
+		};
+
+		tdm_phy_1: slic@1 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <2>;
+			spi-max-frequency = <8000000>;
+		};
+	};
+
+	tdm@16000 {
+		num-phy = <2>;
+		phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+	};
+
 	mdio@24000 {
 		phy0: ethernet-phy@0 {
 			interrupts = <3 1 0 0>;
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
index c952cd3..3a7fdd9 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
@@ -186,6 +186,24 @@ 
 				label = "file system jffs2";
 			};
 		};
+
+		tdm_phy_0: slic@0 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <1>;
+			spi-max-frequency = <8000000>;
+		};
+
+		tdm_phy_1: slic@1 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <2>;
+			spi-max-frequency = <8000000>;
+		};
+
+	};
+
+	tdm@16000 {
+		num-phy = <2>;
+		phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
 	};
 
 	usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb.dtsi b/arch/powerpc/boot/dts/p1020rdb.dtsi
index 1fb7e0e..f1a3431 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb.dtsi
@@ -186,6 +186,23 @@ 
 				label = "file system jffs2";
 			};
 		};
+
+		tdm_phy_0: slic@0 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <1>;
+			spi-max-frequency = <8000000>;
+		};
+
+		tdm_phy_1: slic@1 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <2>;
+			spi-max-frequency = <8000000>;
+		};
+	};
+
+	tdm@16000 {
+		num-phy = <2>;
+		phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
 	};
 
 	usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 873da35..af2d4e1 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi
@@ -183,6 +183,18 @@ 
 				reg = <0x00700000 0x00900000>;
 			};
 		};
+
+		tdm_phy_0: slic@0 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <1>;
+			spi-max-frequency = <8000000>;
+		};
+
+		tdm_phy_1: slic@1 {
+			compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <2>;
+			spi-max-frequency = <8000000>;
+		};
 	};
 
 	ssi@15000 {
@@ -191,6 +203,11 @@ 
 		fsl,ssi-asynchronous;
 	};
 
+	tdm@16000 {
+		num-phy = <2>;
+		phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+	};
+
 	usb@22000 {
 		phy_type = "ulpi";
 	};
diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
index b05dcb4..cec36a3 100644
--- a/arch/powerpc/boot/dts/p1024rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
@@ -164,6 +164,19 @@ 
 				label = "SPI JFFS2 RFS";
 			};
 		};
+
+                tdm_phy_0: slic@0 {
+                        compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <1>;
+			spi-max-frequency = <8000000>;
+		};
+
+                tdm_phy_1: slic@1 {
+                        compatible = "zarlink,le88266", "tdm-phy-slic";
+			reg = <2>;
+			spi-max-frequency = <8000000>;
+		};
+
 	};
 
 	i2c@3000 {
@@ -173,6 +186,11 @@ 
 		};
 	};
 
+        tdm@16000 {
+                num-phy = <2>;
+                phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+        };
+
 	usb@22000 {
 		phy_type = "ulpi";
 	};