Patchwork [2/3] netfilter: xt_AUDIT: only generate audit log when audit enabled

login
register
mail settings
Submitter Pablo Neira
Date March 7, 2013, 11 a.m.
Message ID <1362654002-4405-3-git-send-email-pablo@netfilter.org>
Download mbox | patch
Permalink /patch/225810/
State Accepted
Headers show

Comments

Pablo Neira - March 7, 2013, 11 a.m.
From: Gao feng <gaofeng@cn.fujitsu.com>

We should stop generting audit log if audit is disabled.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/xt_AUDIT.c |    3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/net/netfilter/xt_AUDIT.c b/net/netfilter/xt_AUDIT.c
index ba92824..3228d7f 100644
--- a/net/netfilter/xt_AUDIT.c
+++ b/net/netfilter/xt_AUDIT.c
@@ -124,6 +124,9 @@  audit_tg(struct sk_buff *skb, const struct xt_action_param *par)
 	const struct xt_audit_info *info = par->targinfo;
 	struct audit_buffer *ab;
 
+	if (audit_enabled == 0)
+		goto errout;
+
 	ab = audit_log_start(NULL, GFP_ATOMIC, AUDIT_NETFILTER_PKT);
 	if (ab == NULL)
 		goto errout;