From patchwork Thu Mar 7 10:21:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 225792 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A44462C0383 for ; Thu, 7 Mar 2013 21:24:24 +1100 (EST) Received: from localhost ([::1]:56734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXzq-0006LX-C1 for incoming@patchwork.ozlabs.org; Thu, 07 Mar 2013 05:24:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXxW-0002KT-V3 for qemu-devel@nongnu.org; Thu, 07 Mar 2013 05:22:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDXxT-0003SV-WC for qemu-devel@nongnu.org; Thu, 07 Mar 2013 05:21:58 -0500 Received: from afflict.kos.to ([92.243.29.197]:33626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXxT-0003SG-Ox for qemu-devel@nongnu.org; Thu, 07 Mar 2013 05:21:55 -0500 Received: from localhost.localdomain (unknown [118.143.64.134]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by afflict.kos.to (Postfix) with ESMTPSA id 829F7264BB; Thu, 7 Mar 2013 11:21:53 +0100 (CET) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2013 10:21:31 +0000 Message-Id: <35c4acdb963b9a8188f101d404dc50b47babd7ea.1362651161.git.riku.voipio@linaro.org> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 92.243.29.197 Cc: Dillon Amburgey Subject: [Qemu-devel] [PATCH 6/7] linux-user: Support setgroups syscall with no groups X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Dillon Amburgey Signed-off-by: Dillon Amburgey Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7f12563..e0c71fb 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7694,18 +7694,20 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, { int gidsetsize = arg1; target_id *target_grouplist; - gid_t *grouplist; + gid_t *grouplist = NULL; int i; - - grouplist = alloca(gidsetsize * sizeof(gid_t)); - target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1); - if (!target_grouplist) { - ret = -TARGET_EFAULT; - goto fail; + if (gidsetsize) { + grouplist = alloca(gidsetsize * sizeof(gid_t)); + target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1); + if (!target_grouplist) { + ret = -TARGET_EFAULT; + goto fail; + } + for (i = 0; i < gidsetsize; i++) { + grouplist[i] = low2highgid(tswapid(target_grouplist[i])); + } + unlock_user(target_grouplist, arg2, 0); } - for(i = 0;i < gidsetsize; i++) - grouplist[i] = low2highgid(tswapid(target_grouplist[i])); - unlock_user(target_grouplist, arg2, 0); ret = get_errno(setgroups(gidsetsize, grouplist)); } break;