diff mbox

[V8,05/20] qemu-img: remove unused parameter in collect_image_info()

Message ID 1362636445-7188-6-git-send-email-xiawenc@linux.vnet.ibm.com
State New
Headers show

Commit Message

Wayne Xia March 7, 2013, 6:07 a.m. UTC 
Parameter *fmt was not used, so remove it.

Reviewed-by: Eric Blake <eblake@redhat.com>

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 qemu-img.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Comments

Eric Blake March 8, 2013, 8:34 p.m. UTC | #1 
On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>   Parameter *fmt was not used, so remove it.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

Typically, these annotations should be kept in chronological order.
That is, the first line should always be a Signed-off-by (you have to
write a patch before anyone else can add their Reviewed-by).  Also, we
tend to avoid blank lines in the attribution section.  So, the preferred
way to write this would be:

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>

But that's cosmetic, and my review still stands.
Wayne Xia March 9, 2013, 4:18 a.m. UTC | #2 
于 2013-3-9 4:34, Eric Blake 写道:
> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>>    Parameter *fmt was not used, so remove it.
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>
> Typically, these annotations should be kept in chronological order.
> That is, the first line should always be a Signed-off-by (you have to
> write a patch before anyone else can add their Reviewed-by).  Also, we
> tend to avoid blank lines in the attribution section.  So, the preferred
> way to write this would be:
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> But that's cosmetic, and my review still stands.
>

OK.
diff mbox

Patch

diff --git a/qemu-img.c b/qemu-img.c
index 471de7d..f4e5d90 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1640,8 +1640,7 @@  static void dump_json_image_info(ImageInfo *info)
 
 static void collect_image_info(BlockDriverState *bs,
                    ImageInfo *info,
-                   const char *filename,
-                   const char *fmt)
+                   const char *filename)
 {
     uint64_t total_sectors;
     char backing_filename[1024];
@@ -1815,7 +1814,7 @@  static ImageInfoList *collect_image_info_list(const char *filename,
         }
 
         info = g_new0(ImageInfo, 1);
-        collect_image_info(bs, info, filename, fmt);
+        collect_image_info(bs, info, filename);
         collect_snapshots(bs, info);
 
         elem = g_new0(ImageInfoList, 1);