Patchwork data: klog.json: Improve the advice for AE_AML_BUFFER_LIMIT

login
register
mail settings
Submitter Colin King
Date March 6, 2013, 2:29 p.m.
Message ID <1362580183-9873-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/225508/
State Accepted
Headers show

Comments

Colin King - March 6, 2013, 2:29 p.m.
From: Colin Ian King <colin.king@canonical.com>

The generic AE_AML_BUFFER_LIMIT errors had very vague and poor
advice, this patch more comprehensively covers the root cause.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - March 7, 2013, 5:09 a.m.
On Wed, Mar 6, 2013 at 10:29 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The generic AE_AML_BUFFER_LIMIT errors had very vague and poor
> advice, this patch more comprehensively covers the root cause.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 2eb2b79..0255bea 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2807,7 +2807,7 @@
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>     "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_AML_BUFFER_LIMIT",
> -   "advice": "Method failed: ResourceSourceIndex is present but ResourceSource is not.",
> +   "advice": "Generally this error occurs because of access outside of a buffer.  This occurs for several reasons: a) A field does not fit withing the current length of a buffer, b) an ACPI table load did not fit into a buffer, c) An attempt to convert a buffer into an integer failed because the buffer was zero sized, d) a SMBus/IPMI/GenericSerialBus write failed because the buffer was too small, e) An index into a buffer was too long and fell outside the buffer.",
>     "label": "KlogAcpiBufferLimit"
>    },
>    {
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - March 8, 2013, 9:03 a.m.
On 03/06/2013 10:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The generic AE_AML_BUFFER_LIMIT errors had very vague and poor
> advice, this patch more comprehensively covers the root cause.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 2eb2b79..0255bea 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2807,7 +2807,7 @@
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_AML_BUFFER_LIMIT",
> -   "advice": "Method failed: ResourceSourceIndex is present but ResourceSource is not.",
> +   "advice": "Generally this error occurs because of access outside of a buffer.  This occurs for several reasons: a) A field does not fit withing the current length of a buffer, b) an ACPI table load did not fit into a buffer, c) An attempt to convert a buffer into an integer failed because the buffer was zero sized, d) a SMBus/IPMI/GenericSerialBus write failed because the buffer was too small, e) An index into a buffer was too long and fell outside the buffer.",
>      "label": "KlogAcpiBufferLimit"
>     },
>     {
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 2eb2b79..0255bea 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2807,7 +2807,7 @@ 
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_AML_BUFFER_LIMIT",
-   "advice": "Method failed: ResourceSourceIndex is present but ResourceSource is not.",
+   "advice": "Generally this error occurs because of access outside of a buffer.  This occurs for several reasons: a) A field does not fit withing the current length of a buffer, b) an ACPI table load did not fit into a buffer, c) An attempt to convert a buffer into an integer failed because the buffer was zero sized, d) a SMBus/IPMI/GenericSerialBus write failed because the buffer was too small, e) An index into a buffer was too long and fell outside the buffer.",
    "label": "KlogAcpiBufferLimit"
   },
   {