Patchwork data: klog.json: Add some vague advice for AE_NOT_EXIST

login
register
mail settings
Submitter Colin King
Date March 6, 2013, 1:49 p.m.
Message ID <1362577742-9124-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/225495/
State Accepted
Headers show

Comments

Colin King - March 6, 2013, 1:49 p.m.
From: Colin Ian King <colin.king@canonical.com>

At the moment AE_NOT_EXIST has no advice which isn't great since this
happens frequently.  Add some advice for this condition.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - March 7, 2013, 5:03 a.m.
On Wed, Mar 6, 2013 at 9:49 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> At the moment AE_NOT_EXIST has no advice which isn't great since this
> happens frequently.  Add some advice for this condition.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 92b6fc2..e0a7d01 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2823,7 +2823,7 @@
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>     "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",
> -   "advice": "",
> +   "advice": "The ACPI interpreter failed to execute or parse some AML because a object or control did not exist.  This normally occurs because of buggy firmware and may lead to unexpected behaviour or loss of functionality.",
>     "label": "KlogAcpiObjectDoesNotExist"
>    },
>    {
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - March 8, 2013, 9:03 a.m.
On 03/06/2013 09:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> At the moment AE_NOT_EXIST has no advice which isn't great since this
> happens frequently.  Add some advice for this condition.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 92b6fc2..e0a7d01 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2823,7 +2823,7 @@
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",
> -   "advice": "",
> +   "advice": "The ACPI interpreter failed to execute or parse some AML because a object or control did not exist.  This normally occurs because of buggy firmware and may lead to unexpected behaviour or loss of functionality.",
>      "label": "KlogAcpiObjectDoesNotExist"
>     },
>     {
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 92b6fc2..e0a7d01 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2823,7 +2823,7 @@ 
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",
-   "advice": "",
+   "advice": "The ACPI interpreter failed to execute or parse some AML because a object or control did not exist.  This normally occurs because of buggy firmware and may lead to unexpected behaviour or loss of functionality.",
    "label": "KlogAcpiObjectDoesNotExist"
   },
   {