From patchwork Wed Mar 6 11:46:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 225486 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id DE45F2C03AA for ; Wed, 6 Mar 2013 22:46:19 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UDCnY-0002Xt-UF; Wed, 06 Mar 2013 11:46:16 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UDCnW-0002X6-R3 for fwts-devel@lists.ubuntu.com; Wed, 06 Mar 2013 11:46:14 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UDCnW-00045u-OO for fwts-devel@lists.ubuntu.com; Wed, 06 Mar 2013 11:46:14 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] data: klog.json: cater for CMOS handler errors Date: Wed, 6 Mar 2013 11:46:14 +0000 Message-Id: <1362570374-6468-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King We're seeing some attempts at firmware to access CMOS memory even though the kernel does not (yet) support this. This could be because of implementations of Peak Shift which accesses CMOS memory to figure out the time. Add some better advice to explain this error. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- data/klog.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/data/klog.json b/data/klog.json index 7c99c03..a9477fc 100644 --- a/data/klog.json +++ b/data/klog.json @@ -2654,6 +2654,14 @@ "compare_mode": "regex", "log_level": "LOG_LEVEL_HIGH", "tag": "FWTS_TAG_ACPI_NO_HANDLER", + "pattern": "ACPI Error.*No handler for Region.*SystemCMOS", + "advice": "An attempt to dispatch an address space or operation region access to CMOS memory has failed because the Linux kernel does not yet have a CMOS handler. This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access. For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.", + "label": "KlogAcpiNoHandlerForRegion" + }, + { + "compare_mode": "regex", + "log_level": "LOG_LEVEL_HIGH", + "tag": "FWTS_TAG_ACPI_NO_HANDLER", "pattern": "ACPI Error.*No handler for Region", "advice": "", "label": "KlogAcpiNoHandlerForRegion" @@ -2662,6 +2670,14 @@ "compare_mode": "regex", "log_level": "LOG_LEVEL_HIGH", "tag": "FWTS_TAG_ACPI_NO_HANDLER", + "pattern": "ACPI Error.*Region SystemCMOS.* has no handler", + "advice": "An attempt to read or write a single field to a CMOS Operation Region has failed because the Linux kernel does not yet have a CMOS handler. This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access. For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.", + "label": "KlogAcpiRegionHasNoHandler" + }, + { + "compare_mode": "regex", + "log_level": "LOG_LEVEL_HIGH", + "tag": "FWTS_TAG_ACPI_NO_HANDLER", "pattern": "ACPI Error.*Region .* has no handler", "advice": "", "label": "KlogAcpiRegionHasNoHandler"