Patchwork data: klog.json: cater for CMOS handler errors

login
register
mail settings
Submitter Colin King
Date March 6, 2013, 11:46 a.m.
Message ID <1362570374-6468-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/225486/
State Accepted
Headers show

Comments

Colin King - March 6, 2013, 11:46 a.m.
From: Colin Ian King <colin.king@canonical.com>

We're seeing some attempts at firmware to access CMOS memory
even though the kernel does not (yet) support this.  This could
be because of implementations of Peak Shift which accesses CMOS
memory to figure out the time.  Add some better advice to explain
this error.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - March 7, 2013, 8:29 a.m.
On Wed, Mar 6, 2013 at 7:46 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We're seeing some attempts at firmware to access CMOS memory
> even though the kernel does not (yet) support this.  This could
> be because of implementations of Peak Shift which accesses CMOS
> memory to figure out the time.  Add some better advice to explain
> this error.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 7c99c03..a9477fc 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2654,6 +2654,14 @@
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*No handler for Region.*SystemCMOS",
> +   "advice": "An attempt to dispatch an address space or operation region access to CMOS memory has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiNoHandlerForRegion"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>     "pattern": "ACPI Error.*No handler for Region",
>     "advice": "",
>     "label": "KlogAcpiNoHandlerForRegion"
> @@ -2662,6 +2670,14 @@
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*Region SystemCMOS.* has no handler",
> +   "advice": "An attempt to read or write a single field to a CMOS Operation Region has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiRegionHasNoHandler"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>     "pattern": "ACPI Error.*Region .* has no handler",
>     "advice": "",
>     "label": "KlogAcpiRegionHasNoHandler"
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - March 8, 2013, 8:57 a.m.
On 03/06/2013 07:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We're seeing some attempts at firmware to access CMOS memory
> even though the kernel does not (yet) support this.  This could
> be because of implementations of Peak Shift which accesses CMOS
> memory to figure out the time.  Add some better advice to explain
> this error.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 7c99c03..a9477fc 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2654,6 +2654,14 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*No handler for Region.*SystemCMOS",
> +   "advice": "An attempt to dispatch an address space or operation region access to CMOS memory has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiNoHandlerForRegion"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>      "pattern": "ACPI Error.*No handler for Region",
>      "advice": "",
>      "label": "KlogAcpiNoHandlerForRegion"
> @@ -2662,6 +2670,14 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*Region SystemCMOS.* has no handler",
> +   "advice": "An attempt to read or write a single field to a CMOS Operation Region has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiRegionHasNoHandler"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>      "pattern": "ACPI Error.*Region .* has no handler",
>      "advice": "",
>      "label": "KlogAcpiRegionHasNoHandler"
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung - April 8, 2013, 1:46 a.m.
On 03/06/2013 07:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We're seeing some attempts at firmware to access CMOS memory
> even though the kernel does not (yet) support this.  This could
> be because of implementations of Peak Shift which accesses CMOS
> memory to figure out the time.  Add some better advice to explain
> this error.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 7c99c03..a9477fc 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2654,6 +2654,14 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*No handler for Region.*SystemCMOS",
> +   "advice": "An attempt to dispatch an address space or operation region access to CMOS memory has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiNoHandlerForRegion"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>      "pattern": "ACPI Error.*No handler for Region",
>      "advice": "",
>      "label": "KlogAcpiNoHandlerForRegion"
> @@ -2662,6 +2670,14 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> +   "pattern": "ACPI Error.*Region SystemCMOS.* has no handler",
> +   "advice": "An attempt to read or write a single field to a CMOS Operation Region has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
> +   "label": "KlogAcpiRegionHasNoHandler"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
>      "pattern": "ACPI Error.*Region .* has no handler",
>      "advice": "",
>      "label": "KlogAcpiRegionHasNoHandler"
>

I submitted a patch to upstream and hopefully they will accept it. :).

Patch

diff --git a/data/klog.json b/data/klog.json
index 7c99c03..a9477fc 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2654,6 +2654,14 @@ 
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_NO_HANDLER",
+   "pattern": "ACPI Error.*No handler for Region.*SystemCMOS",
+   "advice": "An attempt to dispatch an address space or operation region access to CMOS memory has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
+   "label": "KlogAcpiNoHandlerForRegion"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
    "pattern": "ACPI Error.*No handler for Region",
    "advice": "",
    "label": "KlogAcpiNoHandlerForRegion"
@@ -2662,6 +2670,14 @@ 
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_NO_HANDLER",
+   "pattern": "ACPI Error.*Region SystemCMOS.* has no handler",
+   "advice": "An attempt to read or write a single field to a CMOS Operation Region has failed because the Linux kernel does not yet have a CMOS handler.  This may have little or no detrimental effect, however it is worth examining the AML to see what kind of access is occurring to see if the firmware really requires CMOS access.  For example, recent firmware may implement Peak Shift, which requires access CMOS memory and this can trigger this error.",
+   "label": "KlogAcpiRegionHasNoHandler"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_NO_HANDLER",
    "pattern": "ACPI Error.*Region .* has no handler",
    "advice": "",
    "label": "KlogAcpiRegionHasNoHandler"