Patchwork data: cater for _PTS not existing

login
register
mail settings
Submitter Colin King
Date March 6, 2013, 11:07 a.m.
Message ID <1362568029-5655-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/225479/
State Accepted
Headers show

Comments

Colin King - March 6, 2013, 11:07 a.m.
From: Colin Ian King <colin.king@canonical.com>

Sometimes _PTS is not implemented and the kernel complains.  It appears
it is a control that helps the firmware do housekeeping before suspend
and for some firmware it is not implemented because it does not need
_PTS. Cater for this by adding some suitable advice and marking this
as not a high level error.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 ++++++++
 1 file changed, 8 insertions(+)
Keng-Yu Lin - March 7, 2013, 4:56 a.m.
On Wed, Mar 6, 2013 at 7:07 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Sometimes _PTS is not implemented and the kernel complains.  It appears
> it is a control that helps the firmware do housekeeping before suspend
> and for some firmware it is not implemented because it does not need
> _PTS. Cater for this by adding some suitable advice and marking this
> as not a high level error.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 2847ce0..7c99c03 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2796,6 +2796,14 @@
>    },
>    {
>     "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_INFO",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*_PTS.*AE_NOT_EXIST",
> +   "advice": "The kernel has attempted to execute the _PTS (Prepare to Suspend) control but it has not been implemented on this platform.  Section 6.1 of the ACPI specification states: 'The _PTS control method provides the BIOS a mechanism for performing some housekeeping, such as writing the sleep type value to the embedded controller, before entering the system sleeping state'.  Hence _PTS is provided for the firmware to do housekeeping and therefore does not appear to be mandatory.  In this case, the platform seems to have omitted _PTS because it may not need it.  Unfortunately the kernel complains about this not existing. This is most probably not an error.",
> +   "label": "KlogAcpiObjectDoesNotExist"
> +  },
> +  {
> +   "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>     "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - March 8, 2013, 8:49 a.m.
On 03/06/2013 07:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Sometimes _PTS is not implemented and the kernel complains.  It appears
> it is a control that helps the firmware do housekeeping before suspend
> and for some firmware it is not implemented because it does not need
> _PTS. Cater for this by adding some suitable advice and marking this
> as not a high level error.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 2847ce0..7c99c03 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2796,6 +2796,14 @@
>     },
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_INFO",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*_PTS.*AE_NOT_EXIST",
> +   "advice": "The kernel has attempted to execute the _PTS (Prepare to Suspend) control but it has not been implemented on this platform.  Section 6.1 of the ACPI specification states: 'The _PTS control method provides the BIOS a mechanism for performing some housekeeping, such as writing the sleep type value to the embedded controller, before entering the system sleeping state'.  Hence _PTS is provided for the firmware to do housekeeping and therefore does not appear to be mandatory.  In this case, the platform seems to have omitted _PTS because it may not need it.  Unfortunately the kernel complains about this not existing. This is most probably not an error.",
> +   "label": "KlogAcpiObjectDoesNotExist"
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 2847ce0..7c99c03 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2796,6 +2796,14 @@ 
   },
   {
    "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_INFO",
+   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
+   "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*_PTS.*AE_NOT_EXIST",
+   "advice": "The kernel has attempted to execute the _PTS (Prepare to Suspend) control but it has not been implemented on this platform.  Section 6.1 of the ACPI specification states: 'The _PTS control method provides the BIOS a mechanism for performing some housekeeping, such as writing the sleep type value to the embedded controller, before entering the system sleeping state'.  Hence _PTS is provided for the firmware to do housekeeping and therefore does not appear to be mandatory.  In this case, the platform seems to have omitted _PTS because it may not need it.  Unfortunately the kernel complains about this not existing. This is most probably not an error.",
+   "label": "KlogAcpiObjectDoesNotExist"
+  },
+  {
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_NOT_EXIST",