From patchwork Wed Mar 6 07:57:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qc0-x23e.google.com (mail-qc0-x23e.google.com [IPv6:2607:f8b0:400d:c01::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E1E812C02EA for ; Wed, 6 Mar 2013 18:57:44 +1100 (EST) Received: by mail-qc0-f190.google.com with SMTP id d10sf1398867qca.27 for ; Tue, 05 Mar 2013 23:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=DL31nTGbU5XTopgoCsC4hIZJIisGJ2ZDDTAk/A2a3mQ=; b=wpr0gfpqZs7kbwKTFIPD5dV/V25cibpqb92CZabYzMCsg8I1OviAYd7GQEDFoYcHDD Zmlya1xi7PfweASUBzjjwlzHIYRGqt+t/H84mmrHoW9p+HEYDqhWOwiYF3i4Ks2ICFjR UIuM10LkAmdihSPDxeJLk6IjV5arkrG8+vaGi+OAFpxQJba1n3OdPm3XXHp++STimm0/ 0B6xXAGXLxOLEbKls1W/wh7FQb9OdL/619KXFEm2aIjzi4aEdGy9XH2DDKcWPlyjQCa2 6SyNRswt7Ds9RqmIju1nA4Mtyv7HMlcYl/96i9plkqO0UtAL6EiQYIo4cwnDGeV/Wd6E UzOA== X-Received: by 10.50.160.132 with SMTP id xk4mr1786757igb.7.1362556662097; Tue, 05 Mar 2013 23:57:42 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.51.193 with SMTP id m1ls351681igo.43.gmail; Tue, 05 Mar 2013 23:57:41 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7427862pbc.2.1362556661814; Tue, 05 Mar 2013 23:57:41 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7427861pbc.2.1362556661805; Tue, 05 Mar 2013 23:57:41 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si7774804pbc.0.2013.03.05.23.57.41; Tue, 05 Mar 2013 23:57:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800A1VBFX6OD0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:57:40 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id A9.A3.23273.4F6F6315; Wed, 06 Mar 2013 16:57:40 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-56-5136f6f4c3ad Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id BC.30.03918.4F6F6315; Wed, 06 Mar 2013 16:57:40 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800MSJBG4HL50@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:57:40 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 30/30] rtc: rtc-wm831x: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:57:37 +0900 Message-id: <009801ce1a40$46b3f130$d41bd390$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAWkzQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zQ90v38wCDZbOMrHY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujMafk9kKtnBUHJnTy9zA+Juti5GTQ0LAROL/rGcsELaYxIV7 68HiQgLLGCVWPAuFqZn1YwVQnAsovohR4sz8L1DOTCaJtffbWEGq2ATUJL58OczexcjBISKg L9HWogFSwyzQC9TQuxssLiRgK9EzjweknFPATmLKxMfsILawgKfEwc/zmUBsFgFVidkLj4LF eYHKjxzdwwRhC0r8mHwP7FBmAS2J9TuPM0HY8hKb17xlBhkvIaAu8eivLkhYRMBI4s3rGYwQ JSIS+168YwQ5R0JgGbvEuck7mCF2CUh8m3yIBaJXVmLTAWaIfyUlDq64wTKBUWIWks2zkGye hWTzLCQrFjCyrGIUTS1ILihOSi8y1StOzC0uzUvXS87P3cQIiayJOxjvH7A+xJgMtH4is5Ro cj4wMvNK4g2NjU3MTExNzC1NzU1JE1YS55W/JBMoJJCeWJKanZpakFoUX1Sak1p8iJGJg1Oq gZHd6bR9QA6L6evKGxcquL21d78U3t70dd9ZcZmqgvNlNVW/Twht/nGpxjRUsr7/9hKxXTv2 8N68uuqDeNehgOk9k6269EvP3Niv3eej0sVqfEl75iOJ1Lk71+nPnCxyeNIdjRIPkZIDuke6 ZXJP1uUp9hjM64p9I9eyw2HbNomHBw8d6vow/YsSS3FGoqEWc1FxIgCQKTVgwgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgO6Xb2aBBu9WG1js7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY0bjz8lsBVs4Ko7M6WVu YPzN1sXIySEhYCIx68cKKFtM4sK99UA2F4eQwCJGiTPzv0A5M5kk1t5vYwWpYhNQk/jy5TB7 FyMHh4iAvkRbiwZIDbNAL1BD726wuJCArUTPPB6Qck4BO4kpEx+zg9jCAp4SBz/PZwKxWQRU JWYvPAoW5wUqP3J0DxOELSjxY/I9FhCbWUBLYv3O40wQtrzE5jVvmUHGSwioSzz6qwsSFhEw knjzegYjRImIxL4X7xgnMArNQjJpFpJJs5BMmoWkZQEjyypG0dSC5ILipPRcQ73ixNzi0rx0 veT83E2M4Mh9JrWDcWWDxSFGAQ5GJR5eCyWzQCHWxLLiytxDjBIczEoivFxngEK8KYmVValF +fFFpTmpxYcYk4EencgsJZqcD0wqeSXxhsYmZkaWRmYWRibm5qQJK4nzMp56EiAkkJ5Ykpqd mlqQWgSzhYmDU6qBsXH/RN4+bXatw/tq934/fdcjsfHQtomvFRdtm/tUJm+qedyztBilybO9 oj0mTG5vsfiV5lP+wLLn+aEdiSc+5FStem8ryGc7ze9QR+KB3OUrv/95bH8u8GuIce+Gkq+7 k7celHj/X255iY1W/f2djzi16zlWXpiYe1y+4CH32ho2hXesx8WW2CuxFGckGmoxFxUnAgAx ViiqIAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-wm831x.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c index 2f0ac7b..8d65b94 100644 --- a/drivers/rtc/rtc-wm831x.c +++ b/drivers/rtc/rtc-wm831x.c @@ -436,7 +436,7 @@ static int wm831x_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - wm831x_rtc->rtc = rtc_device_register("wm831x", &pdev->dev, + wm831x_rtc->rtc = devm_rtc_device_register(&pdev->dev, "wm831x", &wm831x_rtc_ops, THIS_MODULE); if (IS_ERR(wm831x_rtc->rtc)) { ret = PTR_ERR(wm831x_rtc->rtc); @@ -462,10 +462,6 @@ err: static int wm831x_rtc_remove(struct platform_device *pdev) { - struct wm831x_rtc *wm831x_rtc = platform_get_drvdata(pdev); - - rtc_device_unregister(wm831x_rtc->rtc); - return 0; }