From patchwork Wed Mar 6 07:56:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pb0-f64.google.com (mail-pb0-f64.google.com [209.85.160.64]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A7A9A2C0384 for ; Wed, 6 Mar 2013 18:56:36 +1100 (EST) Received: by mail-pb0-f64.google.com with SMTP id un1sf3841871pbc.19 for ; Tue, 05 Mar 2013 23:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=8WeKpTpDKlUWe6k0YdBbzyEBiu5SKMXtY3UlOVrV2lw=; b=MGjQHLYeQzhMh0ssv+RsFaDDxJuQ3nbyJnQJecx34ldusj/r7RCJ8E2uoS2+6AL1Zv +W7DhzlZwH1gawLIzl9v7w8nd0FEGUfaZxFLX0Abmb8kPCIYeKDbUVhURi9bK/Grlrhk liqW+XDvUNo+tKrKi4h1HceMFMiJmHo/bcslvlSMs0yddx13TgcEm88KKh1KAjRwknTs gbZsCtuen7KOMfRDtYdiWeE7XwYjnBwn3Dj57WBSnKZIbNT8WF0aMlP9d3wbn1MFSqGe dUZVVmpBJdAIHxVH2FcI0iArfuQN5aP1UcG3FY5yk2xOamUlz5cGkLusjwhQLEe5Ok89 0Yjw== X-Received: by 10.50.185.200 with SMTP id fe8mr1767242igc.0.1362556594073; Tue, 05 Mar 2013 23:56:34 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.208.41 with SMTP id mb9ls227261igc.26.gmail; Tue, 05 Mar 2013 23:56:33 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr7422693pbb.4.1362556593567; Tue, 05 Mar 2013 23:56:33 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr7422692pbb.4.1362556593557; Tue, 05 Mar 2013 23:56:33 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ka10si7772711pbb.2.2013.03.05.23.56.33; Tue, 05 Mar 2013 23:56:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8005BGBCRLGG0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:56:32 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 33.8C.25214.0B6F6315; Wed, 06 Mar 2013 16:56:32 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-4a-5136f6b05f0a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 93.DF.03918.0B6F6315; Wed, 06 Mar 2013 16:56:32 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800B3UBE8KN00@mmp2.samsung.com>; Wed, 06 Mar 2013 16:56:32 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 27/30] rtc: rtc-tps80031: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:56:32 +0900 Message-id: <009501ce1a40$1e005350$5a00f9f0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAULzw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zQ90N38wCDaZeV7ZYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANYrLJiU1J7Ms tUjfLoErY92vN8wFt7kqti98w9jA+Jyji5GDQ0LAROLCG9UuRk4gU0ziwr31bF2MXBxCAssY JRZO7mCHSJhI7LzyngUiMZ1R4sCKW4wQzi9GibbOK2BVbAJqEl++HGYHmSoioC/R1qIBUsMs 0MsocaZ3N1hcSMBWomceD0g5p4CdxJSJj8FahQW8Jbp65rCC2CwCqhJP13Yygdi8QOW3Ln5k hrAFJX5MvscCYjMLaEms33mcCcKWl9i85i0zxDPqEo/+6oKERQSMJPrftrFClIhI7HvxDuxk CYF77BLr+vYyQuwSkPg2+RALRK+sxKYDzBD/SkocXHGDZQKjxCwkm2ch2TwLyeZZSFYsYGRZ xSiaWpBcUJyUXmSkV5yYW1yal66XnJ+7iRESp307GG8esD7EmAy0fiKzlGhyPjDO80riDY2N TcxMTE3MLU3NTUkTVhLnlb8kEygkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB0dHx1KUdnm1K Rnr37vpUvpg+s3bl+nPqTozeylk31nsV19fP8J3G+1gvrpjpwNxdbk6aSltinvLcFWTI9Pu7 /m2etbr0bv+VM974KR/fkvKz+OfHO9dWMTzNVsplt1HIt+oJ0vQSuHYwc+K2BUkZbkKzQ9OZ Obxvf7fd/6x5h4px44XAF2yrlViKMxINtZiLihMBvF16dekCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQd0N38wCDQ71y1ssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLHu1xvmgttcFdsXvmFsYHzO0cXIySEhYCKx 88p7FghbTOLCvfVsXYxcHEIC0xklDqy4xQjh/GKUaOu8wg5SxSagJvHly2Egm4NDREBfoq1F A6SGWaCXUeJM726wuJCArUTPPB6Qck4BO4kpEx+DtQoLeEt09cxhBbFZBFQlnq7tZAKxeYHK b138yAxhC0r8mHwP7CBmAS2J9TuPM0HY8hKb17xlBhkvIaAu8eivLkhYRMBIov9tGytEiYjE vhfvGCcwCs1CMmkWkkmzkEyahaRlASPLKkbR1ILkguKk9FxDveLE3OLSvHS95PzcTYzgNPBM agfjygaLQ4wCHIxKPLwWSmaBQqyJZcWVuYcYJTiYlUR4uc4AhXhTEiurUovy44tKc1KLDzEm Az06kVlKNDkfmKLySuINjU3MjCyNzCyMTMzNSRNWEudlPPUkQEggPbEkNTs1tSC1CGYLEwen VAPjNo+HDmxlF45eadISN6v6P+2jydOLN56f7fGN4uVOvWuRsolBPY/3yIwF8/fpsnO9e666 8LdrQ96MogvKT9czyFRbyb2for1euoO5+OHO+HC/CR3fWN/y87Qz9HzImKlpfT2ivkDE+0Oa hERi+fZnEv+6y/8rnmPblLmET1Mp9cjUiOmndXOUWIozEg21mIuKEwErMD0lRwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-tps80031.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-tps80031.c b/drivers/rtc/rtc-tps80031.c index 9aaf8aa..dc62d5f 100644 --- a/drivers/rtc/rtc-tps80031.c +++ b/drivers/rtc/rtc-tps80031.c @@ -277,7 +277,7 @@ static int tps80031_rtc_probe(struct platform_device *pdev) return ret; } - rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &tps80031_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { ret = PTR_ERR(rtc->rtc); @@ -292,7 +292,6 @@ static int tps80031_rtc_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "request IRQ:%d failed, err = %d\n", rtc->irq, ret); - rtc_device_unregister(rtc->rtc); return ret; } device_set_wakeup_capable(&pdev->dev, 1); @@ -301,9 +300,6 @@ static int tps80031_rtc_probe(struct platform_device *pdev) static int tps80031_rtc_remove(struct platform_device *pdev) { - struct tps80031_rtc *rtc = platform_get_drvdata(pdev); - - rtc_device_unregister(rtc->rtc); return 0; }