From patchwork Wed Mar 6 07:56:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x239.google.com (mail-ie0-x239.google.com [IPv6:2607:f8b0:4001:c03::239]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id BB5402C03A1 for ; Wed, 6 Mar 2013 18:56:11 +1100 (EST) Received: by mail-ie0-f185.google.com with SMTP id c11sf3764699ieb.2 for ; Tue, 05 Mar 2013 23:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=7MVZt5iEEdReJchxvWTUgbbEIGjRy9TS64HqwMB/DT8=; b=cpbbTVO2d9wXfxhF+a0Aat+D9qeZSKnEQxZXPrZ+oqK3q9MiE60n2yzrnVVaWY7HLI qAvbVWnJP3WbLmb2lKlX8zGSi9G0l/MP90El+qT+lwLH1fmXwJkQDzfhoaiXQcLumKvT OvTkuf0ZdFzf7W1KoKZlIpxREFYRsfCcoJa6odVBiEdASAgwRFa5+uc3bERoIXzSa5+4 qh++1JxAFBEVYPCPX6dBz+thTlXhFfJ0prfWdFd3QH79BKAiP2Jncwwdfas1GLtq0DO1 6d1er1hxzLND1Xq6n5rWEcoPLy3JEnpddUMJR6C4+xjg5eVAstqAptmMKRuJun2SBdLu 09YQ== X-Received: by 10.50.151.205 with SMTP id us13mr1766551igb.2.1362556569722; Tue, 05 Mar 2013 23:56:09 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.213.42 with SMTP id np10ls223828igc.32.gmail; Tue, 05 Mar 2013 23:56:09 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7425349pbc.2.1362556569339; Tue, 05 Mar 2013 23:56:09 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7425348pbc.2.1362556569329; Tue, 05 Mar 2013 23:56:09 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id tj3si7772329pbc.0.2013.03.05.23.56.09; Tue, 05 Mar 2013 23:56:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8002MNBBEJHJ0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:56:08 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 91.F6.02494.896F6315; Wed, 06 Mar 2013 16:56:08 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-3e-5136f69868e5 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A7.27.03880.896F6315; Wed, 06 Mar 2013 16:56:08 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800M43BDKSM30@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:56:08 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 26/30] rtc: rtc-tps65910: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:56:08 +0900 Message-id: <009401ce1a40$0f91de10$2eb59a30$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAThnQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zA90Z38wCDZ53iFvs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxuFjBQWPOCvOdc5gbmCcxdHFyMkhIWAi8ePJB3YIW0ziwr31 bF2MXBxCAssYJXqmPGaEKfrUtZEJxBYSWMQocb/JBKJoJpPEhZ0LwbrZBNQkvnw5DGRzcIgI 6Eu0tWiA1DAL9DJKnOndDRYXErCV6JnHA1LOKWAnMWXiY7BWYQFviRnfvoPNZxFQlXi34hGY zQtUfvPhG0YIW1Dix+R7LCA2s4CWxPqdx5kgbHmJzWveMoOMlxBQl3j0VxckLCJgJLH613Nm iBIRiX0v3jGCnCMhsIhd4s/ys2wQuwQkvk0+xALRKyux6QAzxLuSEgdX3GCZwCgxC8nmWUg2 z0KyeRaSFQsYWVYxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525ihMRV7w7G2wesDzEmA62fyCwl mpwPjMu8knhDY2MTMxNTE3NLU3NT0oSVxHnlLskECgmkJ5akZqemFqQWxReV5qQWH2Jk4uCU amCcun9rvsfJiWvKJkg8S5M6/99xjrnng98iJipfxRZOWPI48uuO5dsPVFb/kih0CLNkXLtT b2aEltWu5Qd81c5uX+F9dvEL8T7OwI6OTyvs/DrnPFINOca9ZdvRR/Zs8p43OP5ExF40ba19 yBZeLeLhKX/t2CQvLnYfcfPL5UGLT9X+Er5gL2KmxFKckWioxVxUnAgAXUKYHMECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgO6Mb2aBBk/6hS32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePwsYKCR5wV5zpnMDcw zuLoYuTkkBAwkfjUtZEJwhaTuHBvPRuILSSwiFHifpNJFyMXkD2TSeLCzoXsIAk2ATWJL18O A9kcHCIC+hJtLRogNcwCvYwSZ3p3g8WFBGwleubxgJRzCthJTJn4GKxVWMBbYsa372C7WARU Jd6teARm8wKV33z4hhHCFpT4MfkeC4jNLKAlsX7ncSYIW15i85q3zCDjJQTUJR791QUJiwgY Saz+9ZwZokREYt+Ld4wTGIVmIZk0C8mkWUgmzULSsoCRZRWjaGpBckFxUnqukV5xYm5xaV66 XnJ+7iZGcNQ+k97BuKrB4hCjAAejEg/vBBWzQCHWxLLiytxDjBIczEoivFxngEK8KYmVValF +fFFpTmpxYcYk4EencgsJZqcD0woeSXxhsYmZkaWRmYWRibm5qQJK4nzMp56EiAkkJ5Ykpqd mlqQWgSzhYmDU6qBUWnSrc8JTSp9K7asXMe1fAbXjwdT3rWL8GjMDzE2L7r+e0JyyXO5C+lJ B2d6GPl4Lbjbyuhd4NL3TPnJpxNrj7dOSbrTueik4+nktPQyxQM2c0O/iKUVOz1lP/D1WOiF G3p8FjKq7ZNcvWSXRYpfKX7ov+f186dSH79eX/x90+2QKP9VjxO5UpRYijMSDbWYi4oTAcSt pBseAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-tps65910.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c index 8bd8115..ef5d199 100644 --- a/drivers/rtc/rtc-tps65910.c +++ b/drivers/rtc/rtc-tps65910.c @@ -276,7 +276,7 @@ static int tps65910_rtc_probe(struct platform_device *pdev) tps_rtc->irq = irq; device_set_wakeup_capable(&pdev->dev, 1); - tps_rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + tps_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &tps65910_rtc_ops, THIS_MODULE); if (IS_ERR(tps_rtc->rtc)) { ret = PTR_ERR(tps_rtc->rtc); @@ -295,12 +295,8 @@ static int tps65910_rtc_probe(struct platform_device *pdev) */ static int tps65910_rtc_remove(struct platform_device *pdev) { - /* leave rtc running, but disable irqs */ - struct tps65910_rtc *tps_rtc = platform_get_drvdata(pdev); - tps65910_rtc_alarm_irq_enable(&pdev->dev, 0); - rtc_device_unregister(tps_rtc->rtc); return 0; }