From patchwork Wed Mar 6 07:55:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ye0-f186.google.com (mail-ye0-f186.google.com [209.85.213.186]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 3AFC02C036B for ; Wed, 6 Mar 2013 18:55:55 +1100 (EST) Received: by mail-ye0-f186.google.com with SMTP id l2sf3841250yen.3 for ; Tue, 05 Mar 2013 23:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=hb3HMpQ4qY+9CCOk2xW3knXfYjpCO3PNH7L7OQF/Kj8=; b=RvVwMA5aQ1iYS6DS3jHSYeJNnTs++4JuMFqyIizLd9g77ZQL02jOCc1Ac/KnZ3JfzA f3cPBEfNrJ+bmKAJ3RdRF1B1qhljCeopJqqZpCyAX5h4/TpK3v2Z17a1opf0VgfIanSR +Casp2pkXDuEta8XGu4OJwj6j7NBoJRbxUKKc9B4tzip+9fFCYYaZSrKKChEE5KNyM16 0yBQXp9/kpsmt7Jk8VkPRwXR8fWrqC7MKboMsTPbYvPh7sgrkccNRUUTQg0vBYw+FSvo +4YqU3bnYqjOsLxpqHj0fgFIcP4CD7dKEp/ao5iLTQZ5lYx31782FA7NB3ZUHj0e+U5v daNA== X-Received: by 10.50.170.68 with SMTP id ak4mr1759164igc.1.1362556553342; Tue, 05 Mar 2013 23:55:53 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.94.229 with SMTP id df5ls219454igb.8.canary; Tue, 05 Mar 2013 23:55:53 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7424944pbb.8.1362556552954; Tue, 05 Mar 2013 23:55:52 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7424943pbb.8.1362556552945; Tue, 05 Mar 2013 23:55:52 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ka10si7771791pbb.2.2013.03.05.23.55.52; Tue, 05 Mar 2013 23:55:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800H2VBD410O0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:55:52 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 05.1C.25214.786F6315; Wed, 06 Mar 2013 16:55:52 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-c9-5136f6870cb2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 68.AF.03918.786F6315; Wed, 06 Mar 2013 16:55:51 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800AJNBD3LS50@mmp2.samsung.com>; Wed, 06 Mar 2013 16:55:51 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 25/30] rtc: rtc-tps6586x: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:55:50 +0900 Message-id: <009301ce1a40$0566b7d0$10342770$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAS2xw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zA92Ob2aBBpvFLZZcvMpuMWf9GjaL ywsvsVpc3jWHzWJ/ZwejA6vHnokn2TxOzPjN4tG3ZRWjx/R5P5k8Pm+SC2CN4rJJSc3JLEst 0rdL4MpYs3UdY8Etzopj3esYGxg7OLoYOTkkBEwkHp1ayQJhi0lcuLeerYuRi0NIYBmjRNPR rSwwRSf2dLNAJKYzStzc0gTl/GKUOH76HjtIFZuAmsSXL4eBbA4OEQF9ibYWDZAaZoFeRokz vbvB4kICthI983hAyjkF7CSmTHwM1ios4C3xfGIzE4jNIqAqsfDKLbDFvCDlDxewQ9iCEj8m 3wOLMwtoSazfeZwJwpaX2LzmLTPIeAkBdYlHf3VBwiICRhKzbv9khigRkdj34h0jyDkSAvfY JZoa90PtEpD4NvkQC0SvrMSmA8wQ/0pKHFxxg2UCo8QsJJtnIdk8C8nmWUhWLGBkWcUomlqQ XFCclF5kpFecmFtcmpeul5yfu4kREqd9OxhvHrA+xJgMtH4is5Rocj4wzvNK4g2NjU3MTExN zC1NzU1JE1YS55W/JBMoJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgTE/6iiTBzuvo8X15F4p 72hVuaLFz8NuB+xqfbn9JGvvp/U3Qxbdf+usb7jUzZ2xo2izWt88Z0tTTafVhmvd1T52vHhU tc2H14LvfkFmduDvi+83zNfrKVA66cX5bvv+I9feLeeU8xSc/01XU/hWxy4BcRGZxEWZKjKJ ue8scxbVr4yQOyD1SImlOCPRUIu5qDgRAG7a00LpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQd32b2aBBoevWVgsuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLFm6zrGglucFce61zE2MHZwdDFyckgImEic 2NPNAmGLSVy4t56ti5GLQ0hgOqPEzS1NLBDOL0aJ46fvsYNUsQmoSXz5chjI5uAQEdCXaGvR AKlhFuhllDjTuxssLiRgK9EzjweknFPATmLKxMdgrcIC3hLPJzYzgdgsAqoSC6/cAlvMC1L+ cAE7hC0o8WPyPbA4s4CWxPqdx5kgbHmJzWveMoOMlxBQl3j0VxckLCJgJDHr9k9miBIRiX0v 3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYwWngmdQO xpUNFocYBTgYlXh4LZTMAoVYE8uKK3MPMUpwMCuJ8HKdAQrxpiRWVqUW5ccXleakFh9iTAZ6 dCKzlGhyPjBF5ZXEGxqbmBlZGplZGJmYm5MmrCTOy3jqSYCQQHpiSWp2ampBahHMFiYOTqkG xsOOp69Hl4hZ/l55rff7TD8t/0VcEe8z2IyWi7+ddOAh/1Px3zcq1OrcK9Y6nJq3LnTWgyVf ljueZC2889nrjEmpse3aJV6GGye/V/l5itW/XqI65OWkbZ8/Saw9p/9tO6v94dnJMzWMmr/z XK1av22C1r4PIRIKOwTdTe8eMF3bv124sozPu0qJpTgj0VCLuag4EQDEzb4ARwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-tps6586x.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index aab4e8c..b6aab9f 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -274,7 +274,7 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, rtc); - rtc->rtc = rtc_device_register(dev_name(&pdev->dev), &pdev->dev, + rtc->rtc = devm_rtc_device_register(&pdev->dev, dev_name(&pdev->dev), &tps6586x_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { ret = PTR_ERR(rtc->rtc); @@ -306,12 +306,10 @@ fail_rtc_register: static int tps6586x_rtc_remove(struct platform_device *pdev) { - struct tps6586x_rtc *rtc = platform_get_drvdata(pdev); struct device *tps_dev = to_tps6586x_dev(&pdev->dev); tps6586x_update(tps_dev, RTC_CTRL, 0, RTC_ENABLE | OSC_SRC_SEL | PRE_BYPASS | CL_SEL_MASK); - rtc_device_unregister(rtc->rtc); return 0; }