From patchwork Wed Mar 6 07:55:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225418 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qe0-f59.google.com (mail-qe0-f59.google.com [209.85.128.59]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 5D3212C036B for ; Wed, 6 Mar 2013 18:55:47 +1100 (EST) Received: by mail-qe0-f59.google.com with SMTP id 6sf3761973qeb.4 for ; Tue, 05 Mar 2013 23:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=r+7q3c8iWuj6W/r5Q0GOKnkqq51ksb0RfCXzEfKvaVI=; b=sj8ZTtxQYS8Ud8GIDKXliypd2+3XhTikbMGFV4yJoVV/tUM5DEWDSs2HcZfRjrolSG h5OyrZmI2PBxXSmes6Na0THC3xtaW06flH+bVQjdP+oXksmFxt3Nwnz191PGh+9i8FAn O1LkQfujvv0i4Kj6oGZOuDKh5mRP/Hq5c3/WZSF8sCvdM2kr+klzpExW4wv4NxbmUCbw cC7gRsNW8O08nMdYS2SFpvomy3swSPgvYeP7m44XWsL0onoj9+bQSxQ2ipfp0qR0It7S QZU+i4zhpMxOF0UhNx5i2KY9kPy+SdLbuHqRtJdkWRRokssvd42d13M4juZL3CrjnIbJ pkWw== X-Received: by 10.50.149.132 with SMTP id ua4mr1774556igb.8.1362556544579; Tue, 05 Mar 2013 23:55:44 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.17.198 with SMTP id q6ls214772igd.44.gmail; Tue, 05 Mar 2013 23:55:44 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7424396pbc.0.1362556544124; Tue, 05 Mar 2013 23:55:44 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7424395pbc.0.1362556544115; Tue, 05 Mar 2013 23:55:44 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ka10si7772011pbb.2.2013.03.05.23.55.43; Tue, 05 Mar 2013 23:55:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8002MNBBEJHJ0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:55:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 09.96.02494.576F6315; Wed, 06 Mar 2013 16:55:33 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-36-5136f675e7c2 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 51.9F.03918.576F6315; Wed, 06 Mar 2013 16:55:33 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800MXLBCKSM20@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:55:33 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 24/30] rtc: rtc-tegra: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:55:32 +0900 Message-id: <009201ce1a3f$fabdd610$f0398230$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAASHSA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zQ93Sb2aBBmsuS1ns7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxqn+R6wFK7gq2o42sTUwnuboYuTkkBAwkbg1/RcThC0mceHe erYuRi4OIYFljBJHFv1hhSlaO/MxI0RiEaNEx7lbUM5MJolvi66wgVSxCahJfPlymL2LkYND REBfoq1FA6SGWaCXUeJM726wuJCArUTPPB6Qck4BO4kpEx+zg9jCAh4S1461gI1hEVCVWHbq CthiXqDyj5M+QdmCEj8m32MBsZkFtCTW7zzOBGHLS2xe85YZZLyEgLrEo7+6IGERASOJqT++ QJWISOx78Q7sZAmBZewSv35ehNolIPFt8iEWiF5ZiU0HmCH+lZQ4uOIGywRGiVlINs9CsnkW ks2zkKxYwMiyilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMktnp3MN4+YH2IMRlo/URmKdHk fGBs5pXEGxobm5iZmJqYW5qam5ImrCTOK3dJJlBIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QD 416Rf46Gu2xjLt5uOd4Txtux80Vo46/ptiufsrbobw+38fmweQfnwf1sdwuajurrqspu7H/A UvfhZf/O1Hnf37kYqqyeNOmnhNS2699b9zkky5wtcwpkWrwwn2Ohqe3HDIYuvuo3x15Ida9Y WMh31OsCl45osueF3k9T7uU4vvURNFlq2dl9UomlOCPRUIu5qDgRAF9b8hvDAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgG7pN7NAg9n3xSz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMeNU/yPWghVcFW1Hm9ga GE9zdDFyckgImEisnfmYEcIWk7hwbz1bFyMXh5DAIkaJjnO3GCGcmUwS3xZdYQOpYhNQk/jy 5TB7FyMHh4iAvkRbiwZIDbNAL6PEmd7dYHEhAVuJnnk8IOWcAnYSUyY+ZgexhQU8JK4dawEb wyKgKrHs1BVWEJsXqPzjpE9QtqDEj8n3WEBsZgEtifU7jzNB2PISm9e8ZQYZLyGgLvHory5I WETASGLqjy9QJSIS+168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nMN9YoTc4tL 89L1kvNzNzGCI/eZ1A7GlQ0WhxgFOBiVeHgtlMwChVgTy4orcw8xSnAwK4nwcp0BCvGmJFZW pRblxxeV5qQWH2JMBnp0IrOUaHI+MKnklcQbGpuYGVkamVkYmZibkyasJM7LeOpJgJBAemJJ anZqakFqEcwWJg5OqQbGbf7JP5b+Pmh86GP63oW59Sb/Xy2Zw/izKnXBxuXNe/fWv05836gq uc4u/pe1ZN2E5fpmG7/ebuEWubqmQKT08a+7Sko7zTympO8/caYqtO9h4WLrxblnE9/XTkuz VEsxPyG9fWrc5qX3/0vG7wt4fa1KdZd5j1RPYe2DowedTjAeKe9YvWzJQyWW4oxEQy3mouJE AFutuNQgAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-tegra.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index 0020bab..8dbf2dc 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -348,8 +348,8 @@ static int __init tegra_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - info->rtc_dev = rtc_device_register( - pdev->name, &pdev->dev, &tegra_rtc_ops, THIS_MODULE); + info->rtc_dev = devm_rtc_device_register( + &pdev->dev, pdev->name, &tegra_rtc_ops, THIS_MODULE); if (IS_ERR(info->rtc_dev)) { ret = PTR_ERR(info->rtc_dev); info->rtc_dev = NULL; @@ -374,17 +374,11 @@ static int __init tegra_rtc_probe(struct platform_device *pdev) return 0; err_dev_unreg: - rtc_device_unregister(info->rtc_dev); - return ret; } static int __exit tegra_rtc_remove(struct platform_device *pdev) { - struct tegra_rtc_info *info = platform_get_drvdata(pdev); - - rtc_device_unregister(info->rtc_dev); - platform_set_drvdata(pdev, NULL); return 0;