From patchwork Wed Mar 6 07:54:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225414 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x23b.google.com (mail-ie0-x23b.google.com [IPv6:2607:f8b0:4001:c03::23b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 721BC2C03A2 for ; Wed, 6 Mar 2013 18:54:20 +1100 (EST) Received: by mail-ie0-f187.google.com with SMTP id k11sf3837886iea.24 for ; Tue, 05 Mar 2013 23:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=9wMOimdo2T/CkeXOKYywccOaIz3mI2d0UoD4Yz4vULk=; b=rcBQs+UkF8T4cLjyLZhjO0/eZIhIxvN/KGkG1CRhfql4/fqogCxKpl+akRsuThV2Pl hUV+eg13Qu7UGsFzANY+HQbygdFIX9s8JwFzKj9UMxxzKtM+R/grzYylK4Z0tjVHiF8B SdOWyzr5R3gKy29ZcW4KnfuRmzXAn7fsiZWOe9xK1T3qfQF5IIJDxzHrEtdqoIAGSRXQ zYkBMX+fzw+DbVHfXyMfoHpNZPZvQy/fikBa8dBwOyCcyw2CVkpQ2K4LTHgXFa+HsZh4 1To00EvcYWuZY0HAvYbY/C4ciihD7bcTL3I2Trjcrj8QIsi+VTGrjig1vOSREJ0+wZK+ xjXA== X-Received: by 10.50.163.41 with SMTP id yf9mr1765065igb.3.1362556457912; Tue, 05 Mar 2013 23:54:17 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.169.3 with SMTP id aa3ls217078igc.41.canary; Tue, 05 Mar 2013 23:54:17 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7422555pbc.2.1362556457164; Tue, 05 Mar 2013 23:54:17 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr7422554pbc.2.1362556457156; Tue, 05 Mar 2013 23:54:17 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ka10si7770388pbb.2.2013.03.05.23.54.16; Tue, 05 Mar 2013 23:54:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800HX2BAG10N0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:54:16 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 40.02.23273.826F6315; Wed, 06 Mar 2013 16:54:16 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-6a-5136f62806d0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1F.96.03880.826F6315; Wed, 06 Mar 2013 16:54:16 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800A11BAFLS50@mmp2.samsung.com>; Wed, 06 Mar 2013 16:54:15 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 20/30] rtc: rtc-s3c: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:54:15 +0900 Message-id: <008e01ce1a3f$cc967f80$65c37e80$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAPUiw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zfV2Nb2aBBm2ruC2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKmPfiMlvBP86KC1cfszQwzuboYuTkkBAwkfjV+JsZwhaTuHBvPVsXIxeHkMAyRolT c/axwBTdWbuaHSIxnVFix41NrBDOL0aJ1jenwNrZBNQkvnw5DFTFwSEioC/R1qIBUsMs0Mso caZ3N1hcSMBWomceD0g5p4CdxJSJj9lBbGEBN4k3Rw8wgdgsAqoSr2c1gsV5gcovL/3KDGEL SvyYfA/sIGYBLYn1O48zQdjyEpvXvGUGGS8hoC7x6K8uSFhEwEii4eUCZogSEYl9L94xQvxy j12ieZs/xCoBiW+TD7FAtMpKbDoADQdJiYMrbrBMYJSYhWTxLCSLZyFZPAvJhgWMLKsYRVML kguKk9KLTPWKE3OLS/PS9ZLzczcxQuJ04g7G+wesDzEmA62fyCwlmpwPjPO8knhDY2MTMxNT E3NLU3NT0oSVxHnlL8kECgmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamAslNn2KnsWc0229g6B AwybGDSd2SaKHpqycM6EGfrN98ITqp++vl1RWRX066zYvY6C9eUmy5VuVwlIyVadTDq3cdH9 GwkOJ4NEtHuF4pZNmaF36YvGqu3V6pavQ/5ulQnw3S976txuPb7rGpnsCxM2cunzKEpvaZih wGyi/WPZ7ilr6larTVqvxFKckWioxVxUnAgAoIfRKukCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV2Nb2aBBh872C2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzJj34jJbwT/OigtXH7M0MM7m6GLk5JAQMJG4 s3Y1O4QtJnHh3nq2LkYuDiGB6YwSO25sYoVwfjFKtL45xQxSxSagJvHly2GgDg4OEQF9ibYW DZAaZoFeRokzvbvB4kICthI983hAyjkF7CSmTHwMtkBYwE3izdEDTCA2i4CqxOtZjWBxXqDy y0u/MkPYghI/Jt9jAbGZBbQk1u88zgRhy0tsXvOWGWS8hIC6xKO/uiBhEQEjiYaXC5ghSkQk 9r14xziBUWgWkkmzkEyahWTSLCQtCxhZVjGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEp4Fn 0jsYVzVYHGIU4GBU4uGdoGIWKMSaWFZcmXuIUYKDWUmEl+sMUIg3JbGyKrUoP76oNCe1+BBj MtCjE5mlRJPzgSkqryTe0NjEzMjSyMzCyMTcnDRhJXFexlNPAoQE0hNLUrNTUwtSi2C2MHFw SjUwKgv7fm0Vkd0/JUTH6+b3K+96PrWs/Lr0UNGd0sVCt3Rkrlbvua7/8OsUNV2DoAcG5Vwp fW8MhQ/ffJjmYRMuc//4L4WZh04e2cqwexq7WvXRxRPj8zMnHeuQN2fvsZENNsxZc/dI5CyV AMnE2ZcO736yS6qZ94Dq3+XKd3c+SJhVGD4/7dmNX0osxRmJhlrMRcWJAD5njJtHAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-s3c.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index fb994e9..7dcf719 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -423,10 +423,7 @@ static void s3c_rtc_enable(struct platform_device *pdev, int en) static int s3c_rtc_remove(struct platform_device *dev) { - struct rtc_device *rtc = platform_get_drvdata(dev); - platform_set_drvdata(dev, NULL); - rtc_device_unregister(rtc); s3c_rtc_setaie(&dev->dev, 0); @@ -511,7 +508,7 @@ static int s3c_rtc_probe(struct platform_device *pdev) /* register RTC and exit */ - rtc = rtc_device_register("s3c", &pdev->dev, &s3c_rtcops, + rtc = devm_rtc_device_register(&pdev->dev, "s3c", &s3c_rtcops, THIS_MODULE); if (IS_ERR(rtc)) { @@ -574,7 +571,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) err_alarm_irq: platform_set_drvdata(pdev, NULL); - rtc_device_unregister(rtc); err_nortc: s3c_rtc_enable(pdev, 0);