From patchwork Wed Mar 6 07:53:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qa0-f57.google.com (mail-qa0-f57.google.com [209.85.216.57]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 6B0022C03A1 for ; Wed, 6 Mar 2013 18:53:44 +1100 (EST) Received: by mail-qa0-f57.google.com with SMTP id hg5sf2365458qab.2 for ; Tue, 05 Mar 2013 23:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=E8Xo0pu6uthjVmD4r+nBeozaUctuCZWH6XX5p/J6XFA=; b=sgF4mvfEbblNitfw8rvMkYFCKwovU87yB5sIe6L7RSFkigmpQlI8DdlcfgjKssV92Q 61JUkqlCB9PzShEWfq39iAoP6vMNO8oPGKGi55IX8wF31KfBqYcYIfSE9aoMdzFqO50v 4ZDIS2WscgHFMO5PA6/VTrtbgAEsMZfJWMZItYlq+J/5w6Tm8pIu/8ffiscypl+RaF4L Tjz5ijeoFX3r8FtX1ECzrmGRwTNkQQhy0eKFi99Z6SZkkEfVE34SU5Y7XnAOVPq2lg/R ESzr6IaH+1wA4gD4WRK/P812u9VEFQB8PXaRA58HZfQ8fkB4TlTjWjNt7WvIolPAsJk4 92Rw== X-Received: by 10.50.236.101 with SMTP id ut5mr1790618igc.17.1362556421844; Tue, 05 Mar 2013 23:53:41 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.57.134 with SMTP id i6ls234044igq.12.canary; Tue, 05 Mar 2013 23:53:41 -0800 (PST) X-Received: by 10.69.3.161 with SMTP id bx1mr7421629pbd.1.1362556421476; Tue, 05 Mar 2013 23:53:41 -0800 (PST) X-Received: by 10.69.3.161 with SMTP id bx1mr7421628pbd.1.1362556421466; Tue, 05 Mar 2013 23:53:41 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id tj3si7770436pbc.0.2013.03.05.23.53.41; Tue, 05 Mar 2013 23:53:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8002K9B9FJHJ0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:53:40 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id FA.F7.17763.406F6315; Wed, 06 Mar 2013 16:53:40 +0900 (KST) X-AuditID: cbfee690-b7f6b6d000004563-7e-5136f604fdcd Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9D.56.03880.406F6315; Wed, 06 Mar 2013 16:53:40 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800AZAB9GLS40@mmp2.samsung.com>; Wed, 06 Mar 2013 16:53:40 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 18/30] rtc: rtc-palmas: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:53:40 +0900 Message-id: <008c01ce1a3f$b76c8f50$2645adf0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAOBiA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zQ12Wb2aBBotvyVssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVsfHlMbaCVdwVT5v2MTcw7uTsYuTkkBAwkZg3ezUThC0mceHeerYuRi4OIYFljBLT d59lgSm69XUtI0RiOqPElClL2SGcX4wSK29sZwWpYhNQk/jy5TBQgoNDREBfoq1FA6SGWaCX UeJM726wuJCArUTPPB6Qck4BO4kpEx+zg9jCAp4Sj/a8AruCRUBVYuOTfrA4L1D5/I3TGSFs QYkfk++BHcQsoCWxfudxJghbXmLzmrfMIOMlBNQlHv3VhbjASGLzTTeIChGJfS/egZ0vIXCL XeLDwdmMEKsEJL5NPsQC0SorsekAM8S7khIHV9xgmcAoMQvJ4llIFs9CsngWkhULGFlWMYqm FiQXFCelF5noFSfmFpfmpesl5+duYoTE6YQdjPcOWB9iTAZaP5FZSjQ5HxjneSXxhsbGJmYm pibmlqbmpqQJK4nzyl+SCRQSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAuPgD2/4/X08Ezih8 ZTSPlesxx9zgg34LT51a+32T7UH7SVue5uVyvTOofbQ9Ud5be0bbxL+txq15ygf9nrblrd73 Mzey+TJXRMVcjpvLaxh5hFqWnet9sNXyrHpJH8e2lfe2WOSfVrs1ySUz3787W/bWdZ4FtVVy +3QV0+YusLnh2nnULX+RqhJLcUaioRZzUXEiAMpGKRnpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQV2Wb2aBBltmSVssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLHx5TG2glXcFU+b9jE3MO7k7GLk5JAQMJG4 9XUtI4QtJnHh3nq2LkYuDiGB6YwSU6YsZYdwfjFKrLyxnRWkik1ATeLLl8NACQ4OEQF9ibYW DZAaZoFeRokzvbvB4kICthI983hAyjkF7CSmTHzMDmILC3hKPNrzignEZhFQldj4pB8szgtU Pn/jdEYIW1Dix+R7LCA2s4CWxPqdx5kgbHmJzWveMoOMlxBQl3j0VxfiAiOJzTfdICpEJPa9 eMc4gVFoFpJBs5AMmoVk0CwkLQsYWVYxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBCeBZ9I7 GFc1WBxiFOBgVOLhnaBiFijEmlhWXJl7iFGCg1lJhJfrDFCINyWxsiq1KD++qDQntfgQYzLQ nxOZpUST84EJKq8k3tDYxMzI0sjMwsjE3Jw0YSVxXsZTTwKEBNITS1KzU1MLUotgtjBxcEo1 MC5aybh3U96cdFuPa+4y4l6x9bbnKhmvfbq+U9X7roONCOesQsZFM2ZzeSq9zX9RnWHz5J5E a1dP4K7LJ49U/3G8v/BX/vTgCxd2Xf/z3cxHYuHKeN4injzpcP+4rrMF/z7PPZvU2/aMm+XK k9BE1XA9Sdas/gdJ/+6/Ul61+nbHJ18Vk2hLGyWW4oxEQy3mouJEAItyqqdGAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-palmas.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index df9359c..bbc3b9ef 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -264,7 +264,7 @@ static int palmas_rtc_probe(struct platform_device *pdev) palmas_rtc->irq = platform_get_irq(pdev, 0); - palmas_rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + palmas_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &palmas_rtc_ops, THIS_MODULE); if (IS_ERR(palmas_rtc->rtc)) { ret = PTR_ERR(palmas_rtc->rtc); @@ -279,7 +279,6 @@ static int palmas_rtc_probe(struct platform_device *pdev) dev_name(&pdev->dev), palmas_rtc); if (ret < 0) { dev_err(&pdev->dev, "IRQ request failed, err = %d\n", ret); - rtc_device_unregister(palmas_rtc->rtc); return ret; } @@ -289,10 +288,7 @@ static int palmas_rtc_probe(struct platform_device *pdev) static int palmas_rtc_remove(struct platform_device *pdev) { - struct palmas_rtc *palmas_rtc = platform_get_drvdata(pdev); - palmas_rtc_alarm_irq_enable(&pdev->dev, 0); - rtc_device_unregister(palmas_rtc->rtc); return 0; }