| Submitter | Jingoo Han |
|---|---|
| Date | March 6, 2013, 7:53 a.m. |
| Message ID | <008b01ce1a3f$ad40f3e0$07c2dba0$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/225410/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBB5HL3OEQKGQEWWNAP7Y@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-x240.google.com (mail-ob0-x240.google.com [IPv6:2607:f8b0:4003:c01::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 987902C0398 for <incoming@patchwork.ozlabs.org>; Wed, 6 Mar 2013 18:53:27 +1100 (EST) Received: by mail-ob0-f192.google.com with SMTP id ta14sf1384037obb.9 for <incoming@patchwork.ozlabs.org>; Tue, 05 Mar 2013 23:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=TVa3VSVKr3ef9aPvnxcXhRIOElixMD/3hHN0S8ziTxU=; b=GbtwmoawCUQVaQIOnK3wWyXF119wgUS8MjpkHXMHyYJysDyj/QYK3HYJxCtpCBCy7U TLHtzyxFEA4mzaxrvLl3hhGfj0CJicPrCj1yvZWwNzs3YslFiajJVqqBrGRVQmPevs/1 Rn8reLT+GmFjqQ/GC0QU0/zoxqlk19Ae1Jl0HCYVhUbYCveidrs3FWP4HXMOwzd+pxRp leLKxZyWR+5V7/q3/erRvJe6kINclIxIf96oc/PByQ9SdCN4IQ5xaieO3TKcAukmDoqa wfbkzkBE2HZkcdt/VJQ2jQ+chDjNRv9tdoIP2W/uCRtWmGTM94mzN0a4T5W5aWN4vdlV Ak1g== X-Received: by 10.50.186.133 with SMTP id fk5mr1768978igc.0.1362556405017; Tue, 05 Mar 2013 23:53:25 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.140.102 with SMTP id rf6ls222926igb.10.canary; Tue, 05 Mar 2013 23:53:24 -0800 (PST) X-Received: by 10.68.234.202 with SMTP id ug10mr5361379pbc.6.1362556404551; Tue, 05 Mar 2013 23:53:24 -0800 (PST) X-Received: by 10.68.234.202 with SMTP id ug10mr5361378pbc.6.1362556404543; Tue, 05 Mar 2013 23:53:24 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ka10si7769207pbb.2.2013.03.05.23.53.24; Tue, 05 Mar 2013 23:53:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ80021DB8ZTGI0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:53:23 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 9F.91.23273.3F5F6315; Wed, 06 Mar 2013 16:53:23 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-ab-5136f5f399ba Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 5E.FE.03918.3F5F6315; Wed, 06 Mar 2013 16:53:23 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ80098HB8ZY7A0@mmp2.samsung.com>; Wed, 06 Mar 2013 16:53:23 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 17/30] rtc: rtc-mxc: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:53:23 +0900 Message-id: <008b01ce1a3f$ad40f3e0$07c2dba0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAANVpQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zY93PX80CDR7el7JYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANYrLJiU1J7Ms tUjfLoEr48a834wFWzgqFn+5xtjA+I+ti5GTQ0LARGLx6k1QtpjEhXvrgWwuDiGBZYwSPa9/ scAUrVuxASoxnVFi8tk7LBDOL0aJ/udrwarYBNQkvnw5zN7FyMEhIqAv0daiAVLDLNDLKHGm dzdYXEjAVqJnHg9IOaeAncSUiY/ZQWxhATeJZ78egI1hEVCV+Lf9NBOIzQtU/m3eZhYIW1Di x+R7YDazgJbE+p3HmSBseYnNa94yg4yXEFCXePRXFyQsImAkcfHoTDaIEhGJfS/eMYKcIyFw j13i57IZzBC7BCS+TT7EAtErK7HpADPEv5ISB1fcYJnAKDELyeZZSDbPQrJ5FpIVCxhZVjGK phYkFxQnpReZ6hUn5haX5qXrJefnbmKEROrEHYz3D1gfYkwGWj+RWUo0OR8Y6Xkl8YbGxiZm JqYm5pam5qakCSuJ88pfkgkUEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwLjO6f2eVFuR6JOp 4iKsqvUFzo+/PvcNDEu9tkj/Ek/0J1/Bze4pD2R4nWcICjVbqr6YJR7If2ndzbtMS+fdfOIl 4va0nMvxkfid0ocumyfblKhaX5Se6NH+s4fPYuoxpb9qe0/nFlw3vxq5Zf63YLn379bwGkTr PPwlO0VmovjaGnNpUds+HyWW4oxEQy3mouJEALcDe63qAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQd3PX80CDY7OFbNYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePGvN+MBVs4KhZ/ucbYwPiPrYuRk0NCwERi 3YoNULaYxIV764FsLg4hgemMEpPP3mGBcH4xSvQ/X8sCUsUmoCbx5cth9i5GDg4RAX2JthYN kBpmgV5GiTO9u8HiQgK2Ej3zeEDKOQXsJKZMfMwOYgsLuEk8+/UAbAyLgKrEv+2nmUBsXqDy b/M2s0DYghI/Jt8Ds5kFtCTW7zzOBGHLS2xe85YZZLyEgLrEo7+6IGERASOJi0dnskGUiEjs e/GOcQKj0Cwkk2YhmTQLyaRZSFoWMLKsYhRNLUguKE5KzzXUK07MLS7NS9dLzs/dxAhOA8+k djCubLA4xCjAwajEw2uhZBYoxJpYVlyZe4hRgoNZSYSX6wxQiDclsbIqtSg/vqg0J7X4EGMy 0KMTmaVEk/OBKSqvJN7Q2MTMyNLIzMLIxNycNGElcV7GU08ChATSE0tSs1NTC1KLYLYwcXBK NTAu5Vq91EJ84myt8PmflnUy3HjFeSTK6JbRdOafel9d0n8rCxzn2bxlYZR/9ezT1oHZf53e zj3cebJB5J6p4q7A3sZ7Zsp+Xs072LyiZBYw1Tku8jBMnihgyHJHotH6y8rZB0oit7ibPv+W MS23pE7S7t29N5GKzU3/ToUEcXc92OxaUfBC6b4SS3FGoqEWc1FxIgBgChLNRwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index 1c3ef72..13380ca 100644 --- a/drivers/rtc/rtc-mxc.c +++ b/drivers/rtc/rtc-mxc.c @@ -439,7 +439,7 @@ static int mxc_rtc_probe(struct platform_device *pdev) if (pdata->irq >=0) device_init_wakeup(&pdev->dev, 1); - rtc = rtc_device_register(pdev->name, &pdev->dev, &mxc_rtc_ops, + rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &mxc_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) { ret = PTR_ERR(rtc); @@ -464,8 +464,6 @@ static int mxc_rtc_remove(struct platform_device *pdev) { struct rtc_plat_data *pdata = platform_get_drvdata(pdev); - rtc_device_unregister(pdata->rtc); - clk_disable_unprepare(pdata->clk); platform_set_drvdata(pdev, NULL);
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-mxc.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)