From patchwork Wed Mar 6 07:51:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f192.google.com (mail-gh0-f192.google.com [209.85.160.192]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 120702C02EA for ; Wed, 6 Mar 2013 18:51:54 +1100 (EST) Received: by mail-gh0-f192.google.com with SMTP id r20sf3686480ghr.29 for ; Tue, 05 Mar 2013 23:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=Ip5hs0oo6ow3qv0t26yyvGdiVi8gnhW3bYFwd3mPE9g=; b=ZslhkReYTb1BUZ9XWBBtDsFij05P0b2xcTFhX6IOGFvhxc+gXRNmr9eCb2A3Cg3eCz aZQ/fC7csoOqX5XYYBg4PciCL8PiNnxAZcgXGC74Z+OSk2wVYDpXh7twg5ZTgxnBpaVs ARDfvmfOtOqvCAjXdRhNRf9xRSaJK9Dz4DYm99T0TSnPDeW1penCziX83H1EoM1Yca+j U5541Rp7tNTolYNKImwI4y6vjtL9trqDYZC56wKGWwvEO8mouW6Cto+RKvhvevdnwLBc YqS9sdARQfzIPsDnQR7yVdYFkkTQbAwFNwOcHj3yudCU1GCfAajvpqGAfrjHJ05wZByy DUTA== X-Received: by 10.50.149.132 with SMTP id ua4mr1773411igb.8.1362556312301; Tue, 05 Mar 2013 23:51:52 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.33.226 with SMTP id u2ls249097igi.0.canary; Tue, 05 Mar 2013 23:51:52 -0800 (PST) X-Received: by 10.69.3.161 with SMTP id bx1mr7418556pbd.1.1362556311886; Tue, 05 Mar 2013 23:51:51 -0800 (PST) X-Received: by 10.69.3.161 with SMTP id bx1mr7418554pbd.1.1362556311875; Tue, 05 Mar 2013 23:51:51 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ir9si6164860pbc.1.2013.03.05.23.51.51; Tue, 05 Mar 2013 23:51:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800FDWB6EO9P0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:51:50 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 6F.01.23273.695F6315; Wed, 06 Mar 2013 16:51:50 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-97-5136f596b9d0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1D.D5.03880.695F6315; Wed, 06 Mar 2013 16:51:50 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800A03B6ETI50@mmp2.samsung.com>; Wed, 06 Mar 2013 16:51:50 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 13/30] rtc: rtc-max77686: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:51:47 +0900 Message-id: <008701ce1a3f$75e903b0$61bb0b10$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAJvnw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zA91pX80CDRr7LCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKWPtlM2vBMt6K/St/sDcwtnF3MXJySAiYSDw8OI8VwhaTuHBvPVsXIxeHkMAyRokX Z3pYYYqO3fjECJGYzihxff8mdgjnF6PErgcH2EGq2ATUJL58OQxkc3CICOhLtLVogNQwC/Qy Spzp3Q0WFxKwleiZxwNSzilgJzFl4mOwVmEBb4mPL56CLWMRUJVonb6LBcTmBSpvufyOFcIW lPgx+R5YnFlAS2L9zuNMELa8xOY1b5lBxksIqEs8+qsLEhYRMJLonX2GFaJERGLfi3dg90sI 3GOX2Di5lQ1il4DEt8mHWCB6ZSU2HWCG+FdS4uCKGywTGCVmIdk8C8nmWUg2z0KyYgEjyypG 0dSC5ILipPQiU73ixNzi0rx0veT83E2MkEiduIPx/gHrQ4zJQOsnMkuJJucDIz2vJN7Q2NjE zMTUxNzS1NyUNGElcV75SzKBQgLpiSWp2ampBalF8UWlOanFhxiZODilGhh3nzO4/ve2a3zv pzNcH06U95TM1r/9+O7UmbPOBp7N3DbhBMc95aMsQYYvjxftjN2rZNSWwOxwwLS0gmk9W/DL QxevLBM/dufs098hX0O8BXaGrTC0m7s444SmoFPSSueD65SnKeXOWSZ+oshy5u19131OdBl9 E/11zSp648zUDzvWnFszpfjICiWW4oxEQy3mouJEAOOVzWjqAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQd1pX80CDT7tMrZYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPtl82sBct4K/av/MHewNjG3cXIySEhYCJx 7MYnRghbTOLCvfVsXYxcHEIC0xklru/fxA7h/GKU2PXgADtIFZuAmsSXL4eBbA4OEQF9ibYW DZAaZoFeRokzvbvB4kICthI983hAyjkF7CSmTHwM1ios4C3x8cVTVhCbRUBVonX6LhYQmxeo vOXyO1YIW1Dix+R7YHFmAS2J9TuPM0HY8hKb17xlBhkvIaAu8eivLkhYRMBIonf2GVaIEhGJ fS/eMU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6blGesWJucWleel6yfm5mxjBaeCZ 9A7GVQ0WhxgFOBiVeHgnqJgFCrEmlhVX5h5ilOBgVhLh5ToDFOJNSaysSi3Kjy8qzUktPsSY DPToRGYp0eR8YIrKK4k3NDYxM7I0MrMwMjE3J01YSZyX8dSTACGB9MSS1OzU1ILUIpgtTByc Ug2Mm5QCzrir1xzpyBA7fUp4+haFvv+X3104sb3RvSjE+mzFHhdT7y9xxfoPrt0JjVlS8dR0 WfFt3TdRHnOVZwaFv1hf5P/z9ZbyJXNC1u1QnXa9f8/KmX+j+1/e0XG+sqknpzNE3CbyVWQu c8cxI5s3hUt4Wi9YVTnIuPYzbRRoS3mwZvGM6N/zlViKMxINtZiLihMBPc1dGEcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Also, this patch uses devm_request_threaded_irq(). Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-max77686.c | 15 ++++----------- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index df66bab..5a12b32 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -538,8 +538,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - info->rtc_dev = rtc_device_register("max77686-rtc", &pdev->dev, - &max77686_rtc_ops, THIS_MODULE); + info->rtc_dev = devm_rtc_device_register(&pdev->dev, "max77686-rtc", + &max77686_rtc_ops, THIS_MODULE); if (IS_ERR(info->rtc_dev)) { dev_info(&pdev->dev, "%s: fail\n", __func__); @@ -555,8 +555,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) goto err_rtc; info->virq = virq; - ret = request_threaded_irq(virq, NULL, max77686_rtc_alarm_irq, 0, - "rtc-alarm0", info); + ret = devm_request_threaded_irq(&pdev->dev, virq, NULL, + max77686_rtc_alarm_irq, 0, "rtc-alarm0", info); if (ret < 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); @@ -569,13 +569,6 @@ err_rtc: static int max77686_rtc_remove(struct platform_device *pdev) { - struct max77686_rtc_info *info = platform_get_drvdata(pdev); - - if (info) { - free_irq(info->virq, info); - rtc_device_unregister(info->rtc_dev); - } - return 0; }