From patchwork Wed Mar 6 07:51:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x23e.google.com (mail-yh0-x23e.google.com [IPv6:2607:f8b0:4002:c01::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 85FCC2C0348 for ; Wed, 6 Mar 2013 18:51:19 +1100 (EST) Received: by mail-yh0-f62.google.com with SMTP id w49sf3832191yhw.27 for ; Tue, 05 Mar 2013 23:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=u0Q0+dijlCb5kAJ1BcNwmLqJMCnsUn/Qwja2DATEKUo=; b=ovxjDx6srCfc+//xlsn2KoNfnbLnb3LAq9nEcDppBWPS1lg7pM5hyGGDr1tf9KDHlR 5kdKWnzJTGvN9fxS0l3Hdr6oX/g36Q4Wo9E3ANtzDXbJ8s9o/uDSKzQne/0T+sfF5kX2 m74lq5y8tS4J4TcmVv6nRB8kAhW33c6nSy8zD7rTGB7a8p4YcL3suw1KdHowSfZsgFXT 4j/R/AMhOxbazBE0580NfTWvpxalglDTzbofAD1xA9b7oS6vU5w4jRG8eSNT6tU7ZJ7/ n8wuGUpXAatDBpaI0i2jnPemunUZ99cMF4UZJKaNWRWhM475qAeAwwjo+xtU0xNZ8evf DTXA== X-Received: by 10.50.51.129 with SMTP id k1mr1758789igo.4.1362556276795; Tue, 05 Mar 2013 23:51:16 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.216.130 with SMTP id oq2ls212262igc.34.canary; Tue, 05 Mar 2013 23:51:16 -0800 (PST) X-Received: by 10.68.234.202 with SMTP id ug10mr5357655pbc.6.1362556276276; Tue, 05 Mar 2013 23:51:16 -0800 (PST) X-Received: by 10.68.234.202 with SMTP id ug10mr5357654pbc.6.1362556276267; Tue, 05 Mar 2013 23:51:16 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ir9si6163843pbc.1.2013.03.05.23.51.16; Tue, 05 Mar 2013 23:51:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ80053TB4ULGG0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:51:09 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 69.B0.23273.D65F6315; Wed, 06 Mar 2013 16:51:09 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-82-5136f56db585 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 26.B5.03880.D65F6315; Wed, 06 Mar 2013 16:51:09 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800MEBB59LD30@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:51:09 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 11/30] rtc: rtc-lp8788: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:51:09 +0900 Message-id: <008501ce1a3f$5da6fe10$18f4fa30$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAIXQg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zfd3cr2aBBgeuWFjs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxvEXO9gLHnFUbNsym62BcQV7FyMnh4SAicSlyU+ZIGwxiQv3 1rOB2EICyxgl5r82han5d243axcjF1B8EaPEqtbnjBDOTCaJL5tes4BUsQmoSXz5chhoKgeH iIC+RFuLBkgNs0Avo8SZ3t1gcSEBW4meeTwg5ZwCdhJTJj4GO0JYwFNi7btPzCA2i4CqxMdr 38CO4AUq//31BTuELSjxY/I9sFXMAloS63ceZ4Kw5SU2r3nLDDJeQkBd4tFfXZCwiICRRM+D XqhyEYl9L96BnSwhsIxdYs+tbywQuwQkvk0+xALRKyux6QAzxL+SEgdX3GCZwCgxC8nmWUg2 z0KyeRaSFQsYWVYxiqYWJBcUJ6UXmeoVJ+YWl+al6yXn525ihETWxB2M9w9YH2JMBlo/kVlK NDkfGJl5JfGGxsYmZiamJuaWpuampAkrifPKX5IJFBJITyxJzU5NLUgtii8qzUktPsTIxMEp 1cC4b9U+Rd35K5JCWU93rt6f277OQ7V6+ezWZFa+Y8/T1V90TMnjrVx8745hY+f/X+drwk+9 6uK3E9U//zq4QImr9Zf70qcC80LWeCXbrTFbGcu8Ie/x7CUf9nx9x1GdwxaV/vGTdfjWy3W6 htYsJYsPzGdkeNLWJb000dC1TEbk4Ffdq4fD33gqsRRnJBpqMRcVJwIA1VILrsICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgG7uV7NAg+a3Rhb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHH8xQ72gkccFdu2zGZr YFzB3sXIySEhYCLx79xuVghbTOLCvfVsXYxcHEICixglVrU+Z4RwZjJJfNn0mgWkik1ATeLL l8NA3RwcIgL6Em0tGiA1zAK9jBJneneDxYUEbCV65vGAlHMK2ElMmfgYbJmwgKfE2nefmEFs FgFViY/XvrGB2LxA5b+/vmCHsAUlfky+B7aKWUBLYv3O40wQtrzE5jVvmUHGSwioSzz6qwsS FhEwkuh50AtVLiKx78U7xgmMQrOQTJqFZNIsJJNmIWlZwMiyilE0tSC5oDgpPddIrzgxt7g0 L10vOT93EyM4cp9J72Bc1WBxiFGAg1GJh3eCilmgEGtiWXFl7iFGCQ5mJRFerjNAId6UxMqq 1KL8+KLSnNTiQ4zJQI9OZJYSTc4HJpW8knhDYxMzI0sjMwsjE3Nz0oSVxHkZTz0JEBJITyxJ zU5NLUgtgtnCxMEp1cAY/8LOUW3FtH1/5kxbfHPSAbeK5ctmHKic/nfrNuUprd9e6ZpHb3DY HHFRoOZA/sUpXkKRvHbLjknrvuZe0JzNab6gsL5wolZ011/tmD3P7726/a0lSMPG6ZPckZtT 4u3PH/js8VNXv3jmsy1MH3U1pDW2OVhqGEj57N70v89jjvzjZYVdDf2MSizFGYmGWsxFxYkA Ah/LnyADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-lp8788.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-lp8788.c b/drivers/rtc/rtc-lp8788.c index 9a46312..9853ac1 100644 --- a/drivers/rtc/rtc-lp8788.c +++ b/drivers/rtc/rtc-lp8788.c @@ -299,7 +299,7 @@ static int lp8788_rtc_probe(struct platform_device *pdev) device_init_wakeup(dev, 1); - rtc->rdev = rtc_device_register("lp8788_rtc", dev, + rtc->rdev = devm_rtc_device_register(dev, "lp8788_rtc", &lp8788_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rdev)) { dev_err(dev, "can not register rtc device\n"); @@ -314,9 +314,6 @@ static int lp8788_rtc_probe(struct platform_device *pdev) static int lp8788_rtc_remove(struct platform_device *pdev) { - struct lp8788_rtc *rtc = platform_get_drvdata(pdev); - - rtc_device_unregister(rtc->rdev); platform_set_drvdata(pdev, NULL); return 0;