| Submitter | Jingoo Han |
|---|---|
| Date | March 6, 2013, 7:50 a.m. |
| Message ID | <008401ce1a3f$4f7e1d50$ee7a57f0$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/225402/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBV7K3OEQKGQEK7AX7NQ@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x240.google.com (mail-yh0-x240.google.com [IPv6:2607:f8b0:4002:c01::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AABC22C03A1 for <incoming@patchwork.ozlabs.org>; Wed, 6 Mar 2013 18:50:50 +1100 (EST) Received: by mail-yh0-f64.google.com with SMTP id z6sf3679715yhz.29 for <incoming@patchwork.ozlabs.org>; Tue, 05 Mar 2013 23:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=mlnEjzJrAqnWH+HbxwG5zVJpvqpKrd/oxTjClLOyyc0=; b=GLHcVgvXv7f0cmhCfKMowmPm6Rgl8SQvGCKRWL2kXIyBLuZzrfynGdvXR5h9A3JM4h kDgvGRC8i/gw5IhTwkThBWUXhuQA3KQy2VvgTp5dd7RWofVWXlUQopjK7TSFvGDZZVUR 44qE/1+8FFwQc9MZeeSwZtAyyj3lQ0KkH2rGlJP5pbPj2m5dYu292XrFb5vW/JOGaTMh mQfxn9Wml4UhZ1S5spG5v2CrdzMjGGhz5JuS/nZHbIfp4llwW7rwlvBaeArlYduSiCcQ CfS07mO7wbgsTQK5yRZxGxkMk1GKwoLV6qWh2HfW+dXtL7J4+ksmkf5wijMxQsF1i2rY FmTA== X-Received: by 10.50.160.132 with SMTP id xk4mr1784914igb.7.1362556247658; Tue, 05 Mar 2013 23:50:47 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.37.142 with SMTP id y14ls212624igj.37.canary; Tue, 05 Mar 2013 23:50:47 -0800 (PST) X-Received: by 10.68.136.104 with SMTP id pz8mr7410835pbb.3.1362556247288; Tue, 05 Mar 2013 23:50:47 -0800 (PST) X-Received: by 10.68.136.104 with SMTP id pz8mr7410834pbb.3.1362556247281; Tue, 05 Mar 2013 23:50:47 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ir9si6162929pbc.1.2013.03.05.23.50.47; Tue, 05 Mar 2013 23:50:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8002V9B47TGH0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:50:46 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 0E.E6.17763.655F6315; Wed, 06 Mar 2013 16:50:46 +0900 (KST) X-AuditID: cbfee690-b7f6b6d000004563-ac-5136f5568294 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id C3.95.03880.655F6315; Wed, 06 Mar 2013 16:50:46 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800BYOB4L9E00@mmp2.samsung.com>; Wed, 06 Mar 2013 16:50:45 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 10/30] rtc: rtc-imxdi: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:50:45 +0900 Message-id: <008401ce1a3f$4f7e1d50$ee7a57f0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAHexA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t8zQ92wr2aBBivPC1ksuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVMXXZFJaCvRwV/5Y2MjcwtrJ3MXJwSAiYSMye7NbFyAlkiklcuLeeDcQWEljGKLFq jgBE3ETi377njF2MXEDx6YwST56cZodwfjFKTHp1FKyDTUBN4suXw2BDRQT0JdpaNEBqmAV6 GSXO9O4GiwsJ2Er0zOMBKecUsJOYMvExO4gtLOAhsXVrNwuIzSKgKvFj9RMmkHJeoPLX7SEg YV4BQYkfk++BlTALaEms33mcCcKWl9i85i0zxCvqEo/+6oKERQSMJC5NecYGUSIise/FO7Dz JQTusUucalzFBLFKQOLb5EMsEL2yEpsOMEO8KylxcMUNlgmMErOQbJ6FZPMsJJtnIVmxgJFl FaNoakFyQXFSepGJXnFibnFpXrpecn7uJkZIjE7YwXjvgPUhxmSg9ROZpUST84ExnlcSb2hs bGJmYmpibmlqbkqasJI4r/wlmUAhgfTEktTs1NSC1KL4otKc1OJDjEwcnFINjFEcH2ZOE3vu 4uF77JSQdkyNa/jmN5Kn2t5NNfRJsZ1b9ZvBkKGjPvf+tAedMtnpYcLlIdsPrXi9+ZTopLKG god2ayuP6u5gtHrf9eDRo2+ZUg0zvkgs+rZ9/nuhe44m3UcMYuSmBjlZLXrTF54duSxp9obc U/d7825vcb/M5tx+ULOmZt4DfiWW4oxEQy3mouJEAElyHm/nAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQd2wr2aBBmem8lksuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmDF12RSWgr0cFf+WNjI3MLaydzFyckgImEj8 2/ecEcIWk7hwbz1bFyMXh5DAdEaJJ09Os0M4vxglJr06ygZSxSagJvHly2GgBAeHiIC+RFuL BkgNs0Avo8SZ3t1gcSEBW4meeTwg5ZwCdhJTJj4GWyYs4CGxdWs3C4jNIqAq8WP1EyaQcl6g 8tftISBhXgFBiR+T74GVMAtoSazfeZwJwpaX2LzmLTNIuYSAusSjv7ogYREBI4lLU56xQZSI SOx78Y5xAqPQLCSTZiGZNAvJpFlIWhYwsqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECE4C z6R3MK5qsDjEKMDBqMTDO0HFLFCINbGsuDL3EKMEB7OSCC/XGaAQb0piZVVqUX58UWlOavEh xmSgPycyS4km5wMTVF5JvKGxiZmRpZGZhZGJuTlpwkrivIynngQICaQnlqRmp6YWpBbBbGHi 4JRqYKy+8fuH3+MH4g5yK7trnwbb5r8PtVN6pX3UOlHa5PRL/zNxsVXSUqXPlPfwVZ/rWbfy dcL7RbMfqalr+1+0eXxPST88r4yZJXVt7J9vgqy7RS4kZ6lutlqVFWdcVb9a72rgnVqx5VV1 NSLBB0zWvuy2OJ318v3KntfuTecNzDguybC81PNQUmIpzkg01GIuKk4EALjnDXhGAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c index 73cf81c..33914e2 100644 --- a/drivers/rtc/rtc-imxdi.c +++ b/drivers/rtc/rtc-imxdi.c @@ -464,7 +464,7 @@ static int __init dryice_rtc_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, imxdi); - imxdi->rtc = rtc_device_register(pdev->name, &pdev->dev, + imxdi->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &dryice_rtc_ops, THIS_MODULE); if (IS_ERR(imxdi->rtc)) { rc = PTR_ERR(imxdi->rtc); @@ -488,8 +488,6 @@ static int __exit dryice_rtc_remove(struct platform_device *pdev) /* mask all interrupts */ __raw_writel(0, imxdi->ioaddr + DIER); - rtc_device_unregister(imxdi->rtc); - clk_disable_unprepare(imxdi->clk); return 0;
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-imxdi.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)