From patchwork Wed Mar 6 07:50:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225400 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f190.google.com (mail-vc0-f190.google.com [209.85.220.190]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id DC1FA2C03A1 for ; Wed, 6 Mar 2013 18:50:14 +1100 (EST) Received: by mail-vc0-f190.google.com with SMTP id fl15sf3379448vcb.17 for ; Tue, 05 Mar 2013 23:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=ULz7aXQEshVOV6xZsBMCpRn3HUHBD8No40wea3VLl44=; b=oGdcfSjq3qNy+xQDEPAuScV2+tHpQXy84eaiQ8EGuDVPm6zn62QlxBffvLge3YCeNr jo7MKs0dlvOUBIFblXZI3Q8OS2EsezUU9OOfbGcaZPghvKGfv53so1ODe+nCVX44+SEN cDaA4yhMt5MXfw5niwxt3BxFkR+SeFoZKrI8UmDW4uq1V5zrXpBDO8lsfNR7fXqwugsV cj2Khfrwp5t7sGHrWvpgUNIFGE9NQCPxj6dWviu687fV50P0LA5t5ySioUdqoPno4gNx Bgx2N2j9BuOeh+bXUGm7iJ8dzCY5TsT2g6NKqFhF2XD8xPrb7XDyNKTYXsPxXqboh9NR 9SYg== X-Received: by 10.50.187.133 with SMTP id fs5mr1781185igc.12.1362556211918; Tue, 05 Mar 2013 23:50:11 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.89.163 with SMTP id bp3ls231061igb.25.canary; Tue, 05 Mar 2013 23:50:11 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr7411798pbb.4.1362556211582; Tue, 05 Mar 2013 23:50:11 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr7411797pbb.4.1362556211574; Tue, 05 Mar 2013 23:50:11 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ir9si6162256pbc.1.2013.03.05.23.50.11; Tue, 05 Mar 2013 23:50:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800DZDAYJ4I90@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:50:10 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id C4.50.23273.035F6315; Wed, 06 Mar 2013 16:50:08 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-88-5136f530ffb1 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 66.0E.03918.035F6315; Wed, 06 Mar 2013 16:50:08 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800MDNB3KI630@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:50:08 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 08/30] rtc: rtc-ds1742: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:50:08 +0900 Message-id: <008201ce1a3f$38fe6120$aafb2360$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAGESg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zQ12Dr2aBBkdWiVvs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxry+5WwF27gqWs5sZGlgvMTRxcjJISFgIvHr3VVWCFtM4sK9 9WwgtpDAMkaJw+syYGreLtnD2MXIBRRfxCjR9Hg1O4Qzk0niZNNLdpAqNgE1iS9fDgPZHBwi AvoSbS0aIDXMAr2MEmd6d4PFhQRsJXrm8YCUcwrYSUyZ+BisVVjAU2LP6b0sIDaLgKpE3+Xb jCA2L1D5xrcPWSFsQYkfk++B1TALaEms33mcCcKWl9i85i0zyHgJAXWJR391QcIiAkYS91ev hCoRkdj34h3Y/RICi9glmuf8ZILYJSDxbfIhFoheWYlNB5gh/pWUOLjiBssERolZSDbPQrJ5 FpLNs5CsWMDIsopRNLUguaA4Kb3IVK84Mbe4NC9dLzk/dxMjJLIm7mC8f8D6EGMy0PqJzFKi yfnAyMwriTc0NjYxMzE1Mbc0NTclTVhJnFf+kkygkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6p Bsatk2Xs+dbdfp7x5ojrvrgfIi/YReoaF3nwZ9ZWPCzwmPTk8soE9diw0uf937/2t16asCds h1XHzLuLRX9YznzisuKD5JS6M4aLDoQkxm8x7rjQX20bHHqZ/9qv71GuITJ7d7vM7fi64eSH qXrxK7s2TXDUfjDvxxO7W1P3FfzlOp6x+LuRcMlMJZbijERDLeai4kQAbvrIkMICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgK7BV7NAg2dtwhb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmDGvbzlbwTauipYzG1ka GC9xdDFyckgImEi8XbKHEcIWk7hwbz1bFyMXh5DAIkaJpser2SGcmUwSJ5tesoNUsQmoSXz5 chjI5uAQEdCXaGvRAKlhFuhllDjTuxssLiRgK9EzjweknFPATmLKxMdgrcICnhJ7Tu9lAbFZ BFQl+i7fBlvMC1S+8e1DVghbUOLH5HtgNcwCWhLrdx5ngrDlJTavecsMMl5CQF3i0V9dkLCI gJHE/dUroUpEJPa9eMc4gVFoFpJJs5BMmoVk0iwkLQsYWVYxiqYWJBcUJ6XnGuoVJ+YWl+al 6yXn525iBEfuM6kdjCsbLA4xCnAwKvHwWiiZBQqxJpYVV+YeYpTgYFYS4eU6AxTiTUmsrEot yo8vKs1JLT7EmAz06ERmKdHkfGBSySuJNzQ2MTOyNDKzMDIxNydNWEmcl/HUkwAhgfTEktTs 1NSC1CKYLUwcnFINjCwX3ZY4Fi+cuizfuI1Tz772raRWuUT4ru+lrh2Hlv9SDT7r9sypzPP6 E8nA2/XTWCwOTl3Uek7t/fnaeg6bbVYlUb85g6fKTLh51cn5yUtfPpNHci21iXcKD+xbk8By 8d6KXax+GWfT81h2H0pMOXaDdan5d/57nIbnQngs51Z/+P0ku3jLbyWW4oxEQy3mouJEAAAZ B60gAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-ds1742.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c index 609c870..eccdc62 100644 --- a/drivers/rtc/rtc-ds1742.c +++ b/drivers/rtc/rtc-ds1742.c @@ -208,17 +208,14 @@ static int ds1742_rtc_probe(struct platform_device *pdev) pdata->last_jiffies = jiffies; platform_set_drvdata(pdev, pdata); - rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &ds1742_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); pdata->rtc = rtc; ret = sysfs_create_bin_file(&pdev->dev.kobj, &pdata->nvram_attr); - if (ret) { - dev_err(&pdev->dev, "creating nvram file in sysfs failed\n"); - rtc_device_unregister(rtc); - } + return ret; } @@ -227,7 +224,6 @@ static int ds1742_rtc_remove(struct platform_device *pdev) struct rtc_plat_data *pdata = platform_get_drvdata(pdev); sysfs_remove_bin_file(&pdev->dev.kobj, &pdata->nvram_attr); - rtc_device_unregister(pdata->rtc); return 0; }