| Submitter | Jingoo Han |
|---|---|
| Date | March 6, 2013, 7:48 a.m. |
| Message ID | <007e01ce1a3f$01b11f50$05135df0$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/225396/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBVPJ3OEQKGQEBDDFQ2A@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pb0-f55.google.com (mail-pb0-f55.google.com [209.85.160.55]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8EEF22C0348 for <incoming@patchwork.ozlabs.org>; Wed, 6 Mar 2013 18:48:39 +1100 (EST) Received: by mail-pb0-f55.google.com with SMTP id uo15sf3763564pbc.0 for <incoming@patchwork.ozlabs.org>; Tue, 05 Mar 2013 23:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=xAyMkRX2VnrATLijl+OuYvCR5pb3onQBAIiVeqIK3K4=; b=CMRJcy9NrPDRVcNb4dlObeH0neQA78droeHzQwqpDn+ZA/6qc2p75Xa8kqH8TAqaWB 24Z2k4FB0VYKPo7qz1b3F8F33dYoKGNaTtyqyBfQA8MDllBFohYkmjZVQPsqriBdgftl vcg48iLNMbuYipJScZ6Qn8Kubzd3D+0WEjLKQ1vGMNt15XERGaRdd3xZVko+FrMKdnTB h0GZAiUyaytI9l8SfCoyEWrwfS6rf8leQjVwIbBmc96CTDchy8JfhmnM70ECFby+IJzN CkWudaoVdpcySaNytSx8ch4voyDjHcuolyRg0/SJky+FqDzEXVJ177oATl6zem7dGiUo nMcg== X-Received: by 10.50.185.200 with SMTP id fe8mr1765487igc.0.1362556117144; Tue, 05 Mar 2013 23:48:37 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.12.198 with SMTP id a6ls220458igc.13.canary; Tue, 05 Mar 2013 23:48:36 -0800 (PST) X-Received: by 10.68.161.163 with SMTP id xt3mr2484818pbb.7.1362556116718; Tue, 05 Mar 2013 23:48:36 -0800 (PST) X-Received: by 10.68.161.163 with SMTP id xt3mr2484817pbb.7.1362556116708; Tue, 05 Mar 2013 23:48:36 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ir9si6159740pbc.1.2013.03.05.23.48.36; Tue, 05 Mar 2013 23:48:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800E6ZB0ZPPS0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:48:35 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id E8.91.18793.3D4F6315; Wed, 06 Mar 2013 16:48:35 +0900 (KST) X-AuditID: cbfee68f-b7f6a6d000004969-d0-5136f4d394e0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C3.9D.03918.3D4F6315; Wed, 06 Mar 2013 16:48:35 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ8009QBB0ZQE90@mmp2.samsung.com>; Wed, 06 Mar 2013 16:48:35 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 04/30] rtc: rtc-da9055: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:48:35 +0900 Message-id: <007e01ce1a3f$01b11f50$05135df0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAACfwQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zfd3LX8wCDf626FgsuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CV8XpTD2vBUo6Kzoff2BoYP7F1MXJySAiYSHSv+M8OYYtJXLi3HijOxSEksIxRYs/i N8wwRRumtbOA2EIC0xklZp4OhSj6xSjx/9lMVpAEm4CaxJcvh4EmcXCICOhLtLVogNQwC/Qy Spzp3Q0WFxKwleiZxwNSzilgJzFl4mOwsLCAp0TTCn+QMIuAqsSfOa/AbuMFqn60o50VwhaU +DH5HtgJzAJaEut3HmeCsOUlNq95ywwyRkJAXeLRX12QsIiAkcTF9e/YIUpEJPa9eMcIco2E wD12iUW9V1ghdglIfJt8iAWiV1Zi0wGobyUlDq64wTKBUWIWks2zkGyehWTzLCQrFjCyrGIU TS1ILihOSi8y1itOzC0uzUvXS87P3cQIidL+HYx3D1gfYkwGWj+RWUo0OR8Y5Xkl8YbGxiZm JqYm5pam5qakCSuJ88pfkgkUEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwGjF2HTOdnvb9m9v GfNT05R+cN2u5dm8QbLmtU2jHveGBbEv3QtU3Ce/PHYhJO9Lwt7qH2GHU1fZcQcxL0hv+8eS qjpFwSCqbtfpcoOFRXkr5yaXa+9+NneG4EeH8oanG5pZgy5zMzl3vZbYsWjTzBdNCT/Y92j4 LnyUZvX5v9Hv3fZF2wvexiqxFGckGmoxFxUnAgA83gF36AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jQd3LX8wCDV5eUbdYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMeP1ph7WgqUcFZ0Pv7E1MH5i62Lk5JAQMJHY MK2dBcIWk7hwbz1YXEhgOqPEzNOhXYxcQPYvRon/z2aygiTYBNQkvnw5zN7FyMEhIqAv0dai AVLDLNDLKHGmdzdYXEjAVqJnHg9IOaeAncSUiY/BwsICnhJNK/xBwiwCqhJ/5rwCW8ULVP1o RzsrhC0o8WPyPbBzmAW0JNbvPM4EYctLbF7zlhlkjISAusSjv7ogYREBI4mL69+xQ5SISOx7 8Y5xAqPQLCSTZiGZNAvJpFlIWhYwsqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECE4Bz6R2 MK5ssDjEKMDBqMTDa6FkFijEmlhWXJl7iFGCg1lJhJfrDFCINyWxsiq1KD++qDQntfgQYzLQ oxOZpUST84HpKa8k3tDYxMzI0sjMwsjE3Jw0YSVxXsZTTwKEBNITS1KzU1MLUotgtjBxcEo1 MJZz5EofCipJsZDdVHztSGnWx7Wqov0LC8S6jjSx7Vn1OM0jV+tu4s6F+ewP/3LmLotdyBDy zypu1tL9LwIT5m6/+VIwNf267ZFLL4J+Oj40ebhBZGbSimi/1b3BEs8PflQW3nP82OTfbJ7Z jnLBvTGKAhd+VPyJu+83g/3EydV61y8xcvY9maHEUpyRaKjFXFScCABwTu9ERQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-da9055.c b/drivers/rtc/rtc-da9055.c index 8f0dcfe..73858ca 100644 --- a/drivers/rtc/rtc-da9055.c +++ b/drivers/rtc/rtc-da9055.c @@ -294,7 +294,7 @@ static int da9055_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &da9055_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { ret = PTR_ERR(rtc->rtc); @@ -317,9 +317,6 @@ err_rtc: static int da9055_rtc_remove(struct platform_device *pdev) { - struct da9055_rtc *rtc = pdev->dev.platform_data; - - rtc_device_unregister(rtc->rtc); platform_set_drvdata(pdev, NULL); return 0;
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-da9055.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)