| Submitter | Jingoo Han |
|---|---|
| Date | March 6, 2013, 7:48 a.m. |
| Message ID | <007d01ce1a3e$f4b2b4d0$de181e70$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/225395/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBP7J3OEQKGQEYI7SAGY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gg0-x238.google.com (mail-gg0-x238.google.com [IPv6:2607:f8b0:4002:c02::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0AFEF2C0348 for <incoming@patchwork.ozlabs.org>; Wed, 6 Mar 2013 18:48:18 +1100 (EST) Received: by mail-gg0-f184.google.com with SMTP id v1sf3683858ggn.1 for <incoming@patchwork.ozlabs.org>; Tue, 05 Mar 2013 23:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=/D+oPtUXdAcONZITFlXbxLR8fwoV0jJGSAMtT8dV324=; b=tzicG6eXfn+r3njekpPRQ/CPCvprVtBKXtamlkb+yVS/Q/PkEvRY/AoYoDCNdWXR2+ 3xszhVJdVEGqeHu0iHuZRB8NOABdR3I2Txm0CM0bFwaYTycXw2fUHD5xTWZBFRwyQ7XH DerB52UCUzu6AWEENsU/PDg9e0zR+AmXldpuiX5ueWox8Me1EDW0mCH6LXpbeg76Uz73 XCShf8mI9uCXmiSGUgGl9pZgkH+4POn/a8ZUk4pJlNqdjaognv6OKTxs/7JUbCutMdPt uazmS7PuCaqOvtUMUCGU4rn5t6tFXZ3xegJpOqN7UiDjaB8NSTBoMzu8aDc3EEg9ltGp U3hQ== X-Received: by 10.50.180.197 with SMTP id dq5mr1774503igc.17.1362556095274; Tue, 05 Mar 2013 23:48:15 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.209.69 with SMTP id mk5ls208166igc.37.gmail; Tue, 05 Mar 2013 23:48:15 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7410968pbc.0.1362556094915; Tue, 05 Mar 2013 23:48:14 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7410967pbc.0.1362556094906; Tue, 05 Mar 2013 23:48:14 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id tj3si7762579pbc.0.2013.03.05.23.48.14; Tue, 05 Mar 2013 23:48:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8008AMB0B6OO0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:48:13 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 16.92.02494.DB4F6315; Wed, 06 Mar 2013 16:48:13 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-e0-5136f4bd880a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 65.C4.03880.DB4F6315; Wed, 06 Mar 2013 16:48:13 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ80094YB0DY790@mmp2.samsung.com>; Wed, 06 Mar 2013 16:48:13 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 03/30] rtc: rtc-da9052: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:48:13 +0900 Message-id: <007d01ce1a3e$f4b2b4d0$de181e70$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAABoLg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zY929X8wCDe5eM7FYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANYrLJiU1J7Ms tUjfLoErY9qKt6wFxzkq1q9fxNzA2MXexcjJISFgIrFr7x4mCFtM4sK99WxdjFwcQgLLGCU6 DjWzwRQtPdfGAmILCUxnlNjSmg9R9ItRYsqNnawgCTYBNYkvXw4DTeXgEBHQl2hr0QCpYRbo ZZQ407sbLC4kYCvRM48HpJxTwE5iysTHYEcIC3hKtG95AHYEi4CqxJGpt8FsXqDynVsa2CFs QYkfk++B3cAsoCWxfudxJghbXmLzmrfMIOMlBNQlHv3VBQmLCBhJLPjxFapERGLfi3eMIOdI CNxilzjw6gwbxC4BiW+TD7FA9MpKbDrADPGupMTBFTdYJjBKzEKyeRaSzbOQbJ6FZMUCRpZV jKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmbGCFx2ruD8fYB60OMyUDrJzJLiSbnA+M8ryTe0NjY xMzE1MTc0tTclDRhJXFeuUsygUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYtafc2vmt/833 11+NVmd7v723+VLI4QL1GYGG2ln/WLyc7q0o4mnx4eDV+Noq1z5XeZcPT7R8bfzGpe8Ff9/n fiS9aJ277bVl+7ZK3LeXPfDtdc4S35/qojbGDvpvtp6/5GMcndzxjiFyg9u33pttTy4s/yNr MGtRgF2uxxn5niXJC39M41Z2U2Ipzkg01GIuKk4EACWqioHpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQd29X8wCDb5MNrBYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPairesBcc5KtavX8TcwNjF3sXIySEhYCKx 9FwbC4QtJnHh3no2EFtIYDqjxJbW/C5GLiD7F6PElBs7WUESbAJqEl++HAZq5uAQEdCXaGvR AKlhFuhllDjTuxssLiRgK9EzjweknFPATmLKxMdgu4QFPCXatzxgArFZBFQljky9DWbzApXv 3NLADmELSvyYfA/sHmYBLYn1O48zQdjyEpvXvGUGGS8hoC7x6K8uSFhEwEhiwY+vUCUiEvte vGOcwCg0C8mkWUgmzUIyaRaSlgWMLKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgpPAM+kd jKsaLA4xCnAwKvHwTlAxCxRiTSwrrsw9xCjBwawkwst1BijEm5JYWZValB9fVJqTWnyIMRno 0YnMUqLJ+cAElVcSb2hsYmZkaWRmYWRibk6asJI4L+OpJwFCAumJJanZqakFqUUwW5g4OKUa GBnKwiM6Zaev3mlhvHDzhk7B6dfn8q6Ma/qdd+nSz3sWDgmiH9InsERcale3FbvUsq12TbNZ 8sr33U2931fvmX71SExK8pY7aff+sC/aEfu5KX7VpoNMCo4+N4qYGE5PEDKMkuuucj8/33fm xsas2rd+MbYKlRt0WZ/k9N78vHTj/gcZ6p9dNJRYijMSDbWYi4oTAdOgP5tGAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c index 0dde688..c4d12d9 100644 --- a/drivers/rtc/rtc-da9052.c +++ b/drivers/rtc/rtc-da9052.c @@ -249,7 +249,7 @@ static int da9052_rtc_probe(struct platform_device *pdev) return ret; } - rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &da9052_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) return PTR_ERR(rtc->rtc); @@ -259,9 +259,6 @@ static int da9052_rtc_probe(struct platform_device *pdev) static int da9052_rtc_remove(struct platform_device *pdev) { - struct da9052_rtc *rtc = pdev->dev.platform_data; - - rtc_device_unregister(rtc->rtc); platform_set_drvdata(pdev, NULL); return 0;
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-da9052.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)