From patchwork Wed Mar 6 07:47:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qe0-f55.google.com (mail-qe0-f55.google.com [209.85.128.55]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 2DF872C0348 for ; Wed, 6 Mar 2013 18:47:53 +1100 (EST) Received: by mail-qe0-f55.google.com with SMTP id 1sf3286960qee.0 for ; Tue, 05 Mar 2013 23:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=Rh9Xkyq06ryp1LBJDa39QYSMY+P0cRzJStdgj7GkO5c=; b=B5N7wHyI91FCAxP1uB+wfJTBn8ekqjnzodfmEHJpcYJhovIQ+egmJF/sBlRUzIpEMo e2uLfQBX3KeTelnX9MZczfJufEqdL4mnzodSRTcA2Xzqm6GqSRpy3o3fEgNGLI4eUZ6+ vK2k7IQJD5ENAuxZ4LHl6dGvtzH0yROQkiNYcaDYebdyJbrGllup1zjosyCPxjoX74Qd orl2UNvYUdacxQ2mzRHawcnZ3z0J1fnNf4WAXCclDizOdu+lzqpgIrGEPq8wDWdTDiAN QHkCQ8+ZBF+BWEttMydm9TGPcl0FMBvZuwErEAhSUSrtKpXh08QvTUD69iOH+lX4vyNH EhuA== X-Received: by 10.50.236.40 with SMTP id ur8mr1771890igc.6.1362556071627; Tue, 05 Mar 2013 23:47:51 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.157.170 with SMTP id wn10ls198132igb.31.gmail; Tue, 05 Mar 2013 23:47:51 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7410714pbb.8.1362556071136; Tue, 05 Mar 2013 23:47:51 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7410713pbb.8.1362556071128; Tue, 05 Mar 2013 23:47:51 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ka10si7761445pbb.2.2013.03.05.23.47.50; Tue, 05 Mar 2013 23:47:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800DZDAYJ4I90@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:47:50 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 01.4F.23273.6A4F6315; Wed, 06 Mar 2013 16:47:50 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-7f-5136f4a6f332 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7C.94.03880.5A4F6315; Wed, 06 Mar 2013 16:47:49 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800MZ9AZPI620@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 16:47:49 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> In-reply-to: <007b01ce1a3e$cd9f3260$68dd9720$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 02/30] rtc: rtc-coh90133: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 16:47:49 +0900 Message-id: <007c01ce1a3e$e6847ce0$b38d76a0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aPs2G+X8TED9/S2OjRUc7S5yKjAAAAqyw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zfd1lX8wCDT5dZbLY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujKuTbzIWbOGsaJmwh62B8R17FyMnh4SAicTbti1QtpjEhXvr 2boYuTiEBJYxSmw708ECU7RvbQc7RGIRo8SZ9XdZIZyZTBLf3rcxgVSxCahJfPlyGKiKg0NE QF+irUUDpIZZoBeooXc3WFxIwFaiZx4PSDmngJ3ElImPwTYLC3hLvNq1jQ3EZhFQlWh6M5sR xOYFKj81YRoLhC0o8WPyPTCbWUBLYv3O40wQtrzE5jVvmUHGSwioSzz6qwsSFhEwktiyfQsb RImIxL4X7xhBzpEQWMQu8XXNO6hdAhLfJh9igeiVldh0gBniX0mJgytusExglJiFZPMsJJtn Idk8C8mKBYwsqxhFUwuSC4qT0otM9YoTc4tL89L1kvNzNzFCYmviDsb7B6wPMSYDrZ/ILCWa nA+MzbySeENjYxMzE1MTc0tTc1PShJXEeeUvyQQKCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRq YFyiNoHzve3780/sjqtZHNv18zebYbiOw7zqRzN/HZza4nDG7fMc2bfz9+QGx4rEfNnZ5yJj pKZ5NcNzlYGTL29ZxsyAIz/nSFQ7v3n/IyRptvbJT5cXhi7mt100PW/vc7HZZ3adjq9On9i1 eMJj52kcf4+Jbv689uPUQrnGplWylmeS4s78vhOrxFKckWioxVxUnAgAqxS05sMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgO7SL2aBBq/6rSz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePq5JuMBVs4K1om7GFr YHzH3sXIySEhYCKxb20HlC0mceHeerYuRi4OIYFFjBJn1t9lhXBmMkl8e9/GBFLFJqAm8eXL YaAODg4RAX2JthYNkBpmgV6ght7dYHEhAVuJnnk8IOWcAnYSUyY+BlsgLOAt8WrXNjYQm0VA VaLpzWxGEJsXqPzUhGksELagxI/J98BsZgEtifU7jzNB2PISm9e8ZQYZLyGgLvHory5IWETA SGLL9i1sECUiEvtevGOcwCg0C8mkWUgmzUIyaRaSlgWMLKsYRVMLkguKk9JzjfSKE3OLS/PS 9ZLzczcxgiP3mfQOxlUNFocYBTgYlXh4J6iYBQqxJpYVV+YeYpTgYFYS4eU6AxTiTUmsrEot yo8vKs1JLT7EmAz06ERmKdHkfGBSySuJNzQ2MTOyNDKzMDIxNydNWEmcl/HUkwAhgfTEktTs 1NSC1CKYLUwcnFINjE53D65tkuN6MmXH6be3cu0OXcvpv/v/O//Lxn3vXvNWFe86wyuRUPzB WOlZmbm8NeOv1rfn7SorV7e3CNo8W+/Keq172Qb+TEPVC4/btq/qrzqzyPO9daZL4syqDi6+ 8MeiK+YHKmq1MWizXd2ef0yhOEjwwrS7Fz+6KiU51JoJN/879/fHBCWW4oxEQy3mouJEADI5 jcUgAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- Changes since v1: - used 'struct device *dev' as the first argument drivers/rtc/rtc-coh901331.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c index 2d28ec1a..78393a2 100644 --- a/drivers/rtc/rtc-coh901331.c +++ b/drivers/rtc/rtc-coh901331.c @@ -155,7 +155,6 @@ static int __exit coh901331_remove(struct platform_device *pdev) struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev); if (rtap) { - rtc_device_unregister(rtap->rtc); clk_unprepare(rtap->clk); platform_set_drvdata(pdev, NULL); } @@ -211,8 +210,8 @@ static int __init coh901331_probe(struct platform_device *pdev) clk_disable(rtap->clk); platform_set_drvdata(pdev, rtap); - rtap->rtc = rtc_device_register("coh901331", &pdev->dev, &coh901331_ops, - THIS_MODULE); + rtap->rtc = devm_rtc_device_register(&pdev->dev, "coh901331", + &coh901331_ops, THIS_MODULE); if (IS_ERR(rtap->rtc)) { ret = PTR_ERR(rtap->rtc); goto out_no_rtc;