From patchwork Wed Mar 6 05:36:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225332 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f192.google.com (mail-vc0-f192.google.com [209.85.220.192]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id F0F062C0378 for ; Wed, 6 Mar 2013 16:36:11 +1100 (EST) Received: by mail-vc0-f192.google.com with SMTP id m8sf3777547vcd.9 for ; Tue, 05 Mar 2013 21:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=9HfGuZrWr7tfCDMeAVUtcMUbbe2gHn4WbsNiX5GDl64=; b=gWG7JGvyudQ5ss32/7xwILKxSN0ry60Ljc9QU1UvXOnSrcqxq7K5NwPs7+2LHmhQhm ADT/9OQSDG0WHTnkeIkiyvY1n+YMwwzIQ1+kM/1zqPsSRY4KdCXyqLPQh52lQfPGJnjh 0kzIdw1apvjsAsVERPbYCLdngr2tiogmfjWflRw9ArcnsZbEc27AJrFxP2snJyYpaa4o X9syEIIQYbdg2aCfwtWBnP4ksktNjr2dNtawkwtroVu8cK/nm/5j4UBpJoXlMdRADtNr x3P4mH6ptBk/5uClq6t5i0e4fWZO6F/yU3IG0tGnmVkd0eBiQ1tOhgq5a7ETMNhgN0BY nXnQ== X-Received: by 10.50.150.180 with SMTP id uj20mr1724691igb.7.1362548169385; Tue, 05 Mar 2013 21:36:09 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.94.229 with SMTP id df5ls162200igb.8.canary; Tue, 05 Mar 2013 21:36:09 -0800 (PST) X-Received: by 10.68.196.134 with SMTP id im6mr7189461pbc.5.1362548169064; Tue, 05 Mar 2013 21:36:09 -0800 (PST) X-Received: by 10.68.196.134 with SMTP id im6mr7189460pbc.5.1362548169055; Tue, 05 Mar 2013 21:36:09 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ir9si6000661pbc.1.2013.03.05.21.36.08; Tue, 05 Mar 2013 21:36:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8005K84W0LG80@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:36:08 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id C0.96.25214.8C5D6315; Wed, 06 Mar 2013 14:36:08 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-d2-5136d5c8c866 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E7.FB.03880.7C5D6315; Wed, 06 Mar 2013 14:36:07 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ80015Q4W7HBY0@mmp2.samsung.com>; Wed, 06 Mar 2013 14:36:07 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> In-reply-to: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> Subject: [rtc-linux] [PATCH 27/30] rtc: rtc-tps80031: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 14:36:07 +0900 Message-id: <005d01ce1a2c$8092a360$81b7ea20$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aKzqYzbgO1ZcaTfGsrpjfTnOAiQAATs5w X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t8zQ90TV80CDVquMVssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CV0bHiCFPBZK6Kp4uWsjYwrufoYuTkkBAwkbjWvp8NwhaTuHBvPZgtJLCMUWL7mmCY mgeH/zBCxKczSuyf59rFyAVk/2KU6HuwBizBJqAm8eXLYfYuRg4OEQF9ibYWDZAaZoFeRokz vbvZIZptJa52r2IGsTkF7CSWP57FAmILC3hIHHm5mAWkl0VAVeL+HWWQMC9Q+cqDt5khbEGJ H5PvgZUzC2hJrN95nAnClpfYvOYtM0irhIC6xKO/uiBhEQEjiV+71rJClIhI7HvxjhHilXvs Esd2hIHYLAICEt8mH2KBaJWV2HSAGaJEUuLgihssExglZiFZPAvJ4llIFs9CsmEBI8sqRtHU guSC4qT0IiO94sTc4tK8dL3k/NxNjJAY7dvBePOA9SHGZKD1E5mlRJPzgTGeVxJvaGxsYmZi amJuaWpuSpqwkjiv/CWZQCGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MeZmqZ2P8nlxm034b auz45o3v0vkX1ELnvuLYb1ucuiNly806nd2nNJetu7p+b3dU1eF3PLKeIm8ZAgLrZm1bH8qQ 3ipyYVPdosXS0VJFt9as0Nh+qfVV3QejPNfHzZlmEaFn+FKqHdrS7RX9tb7Nt03Rlrmz+ZzT 9N3afSUtMx9VTqy652ulxFKckWioxVxUnAgA2W8KJOcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQd3jV80CDeactrFYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMaNjxRGmgslcFU8XLWVtYFzP0cXIySEhYCLx 4PAfRghbTOLCvfVsILaQwHRGif3zXLsYuYDsX4wSfQ/WgBWxCahJfPlymL2LkYNDREBfoq1F A6SGWaCXUeJM7252iGZbiavdq5hBbE4BO4nlj2exgNjCAh4SR14uZgHpZRFQlbh/RxkkzAtU vvLgbWYIW1Dix+R7YOXMAloS63ceZ4Kw5SU2r3nLDNIqIaAu8eivLkhYRMBI4teutawQJSIS +168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGCk8Az 6R2MqxosDjEKcDAq8fBOUDELFGJNLCuuzD3EKMHBrCTCy3UGKMSbklhZlVqUH19UmpNafIgx GejPicxSosn5wASVVxJvaGxiZmRpZGZhZGJuTpqwkjgv46knAUIC6YklqdmpqQWpRTBbmDg4 pRoYl39TlezmS1acI7Vou21Zk9euWYZJbeW/+Fy3sumuvs7L7eWrpekTkbsn+s5Zo7sMq80m RHpPmOpSU71xW2iG7JFlex5pXGPbcci3YnubyaTGdSzb/qisvvVi+8/6q19k67Tl7wvnqpeZ PXx5er7w3fy8LjOvqRraXLyKb9+z7a27ceGbyIdOJZbijERDLeai4kQAi1W5TEYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-tps80031.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-tps80031.c b/drivers/rtc/rtc-tps80031.c index 9aaf8aa..f5f6c32 100644 --- a/drivers/rtc/rtc-tps80031.c +++ b/drivers/rtc/rtc-tps80031.c @@ -277,7 +277,7 @@ static int tps80031_rtc_probe(struct platform_device *pdev) return ret; } - rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc->rtc = devm_rtc_device_register(pdev->name, &pdev->dev, &tps80031_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { ret = PTR_ERR(rtc->rtc); @@ -292,7 +292,6 @@ static int tps80031_rtc_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "request IRQ:%d failed, err = %d\n", rtc->irq, ret); - rtc_device_unregister(rtc->rtc); return ret; } device_set_wakeup_capable(&pdev->dev, 1); @@ -301,9 +300,6 @@ static int tps80031_rtc_probe(struct platform_device *pdev) static int tps80031_rtc_remove(struct platform_device *pdev) { - struct tps80031_rtc *rtc = platform_get_drvdata(pdev); - - rtc_device_unregister(rtc->rtc); return 0; }