| Submitter | Jingoo Han |
|---|---|
| Date | March 6, 2013, 5:33 a.m. |
| Message ID | <005501ce1a2c$26892b50$739b81f0$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/225324/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBMVK3OEQKGQENGKVVQQ@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ye0-f189.google.com (mail-ye0-f189.google.com [209.85.213.189]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9E2BA2C037E for <incoming@patchwork.ozlabs.org>; Wed, 6 Mar 2013 16:33:41 +1100 (EST) Received: by mail-ye0-f189.google.com with SMTP id q1sf3777642yen.6 for <incoming@patchwork.ozlabs.org>; Tue, 05 Mar 2013 21:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=f0t9NO/7U3WEZMPFNNgxqOwOgnLOyHoU8WrilOIhjMY=; b=jgp6hJJo9swW8O3ypR8sGy1DPFTwRw5zw3IDtOVvZiM7dwDDy1gvblgXAQYGiwUEbe Fo57V57Ouz04664nSkGL34C6T+pnjJPbxOxGgPicOOehfbcrtu/UxDu9XewsB8o8+lXg oaTQOQRaHuk3Sy37D1zp+tobmSR9BVloHSw19jhvTpN/PN+6QZ1JODC6T6BahEVKQk7R XM6pfsD3MJXoYVbDQ8MXlRhvGbUEgOesDW3BNoqp/nGG56ckSm2he56Upnc0/zBFoal7 42vID0eMn0eOKw2iPQhZH8d6Kf7UCxVkwAKdkQaj6nQYh5h6Z+qDBZeZKf/UHmYKtWBq gAag== X-Received: by 10.50.186.133 with SMTP id fk5mr1722276igc.0.1362548018615; Tue, 05 Mar 2013 21:33:38 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.140.102 with SMTP id rf6ls161912igb.10.canary; Tue, 05 Mar 2013 21:33:38 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7187746pbb.8.1362548018189; Tue, 05 Mar 2013 21:33:38 -0800 (PST) X-Received: by 10.68.138.165 with SMTP id qr5mr7187745pbb.8.1362548018153; Tue, 05 Mar 2013 21:33:38 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ka10si7601215pbb.2.2013.03.05.21.33.37; Tue, 05 Mar 2013 21:33:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ8003BO4RL6XB0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:33:37 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 23.92.02494.135D6315; Wed, 06 Mar 2013 14:33:37 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-18-5136d531e5e1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E4.5B.03880.135D6315; Wed, 06 Mar 2013 14:33:37 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ8001I04S0HBX0@mmp2.samsung.com>; Wed, 06 Mar 2013 14:33:36 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> In-reply-to: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> Subject: [rtc-linux] [PATCH 19/30] rtc: rtc-pcf8523: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 14:33:36 +0900 Message-id: <005501ce1a2c$26892b50$739b81f0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aKzqYzbgO1ZcaTfGsrpjfTnOAiQAAN/0g X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zA13Dq2aBBkv38VgsuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVsaftMVPBC/aKS0eeMDUw7mDrYuTkkBAwkXiy6zEThC0mceHeeqA4F4eQwDJGiQlf NjDDFHVffssEkZjOKHF0zWmoql+MErvXb2YEqWITUJP48uUwexcjB4eIgL5EW4sGSA2zQC+j xJne3ewgNUICthJXu1eBTeUUsJNY/ngWC4gtLOAu0bfpGAtIL4uAqsS6SSUgYV6g8vmfF7JC 2IISPybfAytnFtCSWL/zOBOELS+xec1bZpBWCQF1iUd/dUHCIgJGEtsmT2aDKBGR2PfiHSPI ORIC99glDs84BdbLIiAg8W3yIRaIXlmJTQeg/pWUOLjiBssERolZSDbPQrJ5FpLNs5CsWMDI sopRNLUguaA4Kb3IUK84Mbe4NC9dLzk/dxMjJFJ7dzDePmB9iDEZaP1EZinR5HxgpOeVxBsa G5uYmZiamFuampuSJqwkzit3SSZQSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA6OS3wT7mr11 6z/XfpzVsOdH22vxA16u2b36QQk5PzeK7yzMXOyR5hq4/uNKpeU287NEj368WrHRda1v3Ix1 9Xf/5DUlrXn9R0M4gGfhMtlr1zX6Tae/XL7zsIjuQo5b9ad/XZ8YvP1GZANf/m5T3nX5R01T rFqaX1hIVc/6c/A3Y+vhQ1sefnuvxFKckWioxVxUnAgA6SzhjeoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV3Dq2aBBg9bOCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzNjT9pip4AV7xaUjT5gaGHewdTFyckgImEh0 X37LBGGLSVy4tx4ozsUhJDCdUeLomtNQzi9Gid3rNzOCVLEJqEl8+XKYvYuRg0NEQF+irUUD pIZZoJdR4kzvbnaQGiEBW4mr3auYQWxOATuJ5Y9nsYDYwgLuEn2bjrGA9LIIqEqsm1QCEuYF Kp//eSErhC0o8WPyPbByZgEtifU7jzNB2PISm9e8ZQZplRBQl3j0VxckLCJgJLFt8mQ2iBIR iX0v3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5RnrFibnFpXnpesn5uZsYwWng mfQOxlUNFocYBTgYlXh4J6iYBQqxJpYVV+YeYpTgYFYS4eU6AxTiTUmsrEotyo8vKs1JLT7E mAz050RmKdHkfGCKyiuJNzQ2MTOyNDKzMDIxNydNWEmcl/HUkwAhgfTEktTs1NSC1CKYLUwc nFINjMxbMnxbxPk37Dt9+mbMAS1FnbPnyu0Mj2zzFWpn9WXIrVHlWL1HddGyn0mnL55jVNi9 6HFpF3NV/mmRle+jxSbfmL02MU14S+dDo8wsYZef6dn37kw0SLRVNM35FPrme3lm8ImdFzk2 NzO+2rq1blK6/BFGn/eOJmwZCzMPL1miXBusumyWjxJLcUaioRZzUXEiAEBde8FHAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 889e316..4c62793 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -307,7 +307,7 @@ static int pcf8523_probe(struct i2c_client *client, if (err < 0) return err; - pcf->rtc = rtc_device_register(DRIVER_NAME, &client->dev, + pcf->rtc = devm_rtc_device_register(DRIVER_NAME, &client->dev, &pcf8523_rtc_ops, THIS_MODULE); if (IS_ERR(pcf->rtc)) return PTR_ERR(pcf->rtc); @@ -319,10 +319,6 @@ static int pcf8523_probe(struct i2c_client *client, static int pcf8523_remove(struct i2c_client *client) { - struct pcf8523 *pcf = i2c_get_clientdata(client); - - rtc_device_unregister(pcf->rtc); - return 0; }
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-pcf8523.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)