From patchwork Wed Mar 6 05:31:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225317 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ia0-x23e.google.com (mail-ia0-x23e.google.com [IPv6:2607:f8b0:4001:c02::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 323ED2C0378 for ; Wed, 6 Mar 2013 16:31:38 +1100 (EST) Received: by mail-ia0-f190.google.com with SMTP id z3sf3696628iad.17 for ; Tue, 05 Mar 2013 21:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=nbemDFhrzXK1FNutgH3qX6hqU4IA2UddRXqGdQGX6KQ=; b=lLdKov+Ex/3+2eRNPSa3YqFs6Bz6YYKW56uCzlWVrC+KRUqix4VcOVMiTRi7wW1i08 XiRt1Zn29nDtZxCrz99RTyCo/uA/ZGp8X/O0vp7tNEqseuzvpXx1psAvfA7PsePv3eSV jcIRpD1PdUA0tBzKKz66Y/NjRIxJ+SSojwSbFGerIvbk6dU8PPjlSDchJUnbnVZnk145 DVA3wij4LlbxXWFVo1FYtr9dIVhI3lHnUdpxaX9uSdYXwN0UIVlIb/c3r1JV6jx70jd1 rks2t60byow1TrapxGIfw8yOe8euIU3RnGh8PivCIOuLaHdY3qmos9KPDnLDFEFKDv5H 6w/Q== X-Received: by 10.50.6.135 with SMTP id b7mr1734735iga.9.1362547896903; Tue, 05 Mar 2013 21:31:36 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.154.137 with SMTP id vo9ls154406igb.28.canary; Tue, 05 Mar 2013 21:31:36 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7184779pbc.0.1362547896533; Tue, 05 Mar 2013 21:31:36 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7184778pbc.0.1362547896521; Tue, 05 Mar 2013 21:31:36 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ka10si7599159pbb.2.2013.03.05.21.31.36; Tue, 05 Mar 2013 21:31:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800EDJ4O6PPK0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:31:35 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id D1.35.17763.7B4D6315; Wed, 06 Mar 2013 14:31:35 +0900 (KST) X-AuditID: cbfee690-b7f6b6d000004563-10-5136d4b7cd0a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 4D.BA.03880.7B4D6315; Wed, 06 Mar 2013 14:31:35 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ8001ZX4OM9YX0@mmp2.samsung.com>; Wed, 06 Mar 2013 14:31:34 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> In-reply-to: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> Subject: [rtc-linux] [PATCH 13/30] rtc: rtc-max77686: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 14:31:34 +0900 Message-id: <004f01ce1a2b$ddf219b0$99d64d10$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aKzqYzbgO1ZcaTfGsrpjfTnOAiQAAJegQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zY93tV8wCDb6c5LFYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANYrLJiU1J7Ms tUjfLoErY/LzvywF93gqph6ZyNTAeI6ri5GTQ0LAROLfibOMELaYxIV769lAbCGBZYwSTXcN YGr+tD8BquECik9nlHg7dzcrhPOLUeLlvCnMIFVsAmoSX74cZu9i5OAQEdCXaGvRAKlhFuhl lDjTu5sdYqqtxNXuVWD1nAJ2Essfz2IBsYUFPCQmTLrDBGKzCKhKzN01EayeF6i+5+RtRghb UOLH5Htg9cwCWhLrdx5ngrDlJTavecsMsldCQF3i0V9dkLCIgJHE8/ZprBAlIhL7XrwDe0BC 4BG7xNubq9kgdglIfJt8iAWiV1Zi0wFmiIclJQ6uuMEygVFiFpLNs5BsnoVk8ywkKxYwsqxi FE0tSC4oTkovMtErTswtLs1L10vOz93ECInUCTsY7x2wPsSYDLR+IrOUaHI+MNLzSuINjY1N zExMTcwtTc1NSRNWEueVvyQTKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoEx8YmqSR77vw5R juDaDn3R2ZuZW766rC+SX++77r//G53du+uv+dtfu7OY+dJuKV2pmftsvm8Tay4LuMa6qyDW Y/P/v53sd8vy9y1y9L6srrl1Wvk/JkX7TZxvd6/f8ILb8Zr53iUnP781is85rl17RWF9/DfG /1eO5plWH10jVzdp4p/0Qq27SizFGYmGWsxFxYkA1dOnf+oCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsVy+t9jQd3tV8wCDV6/YLdYcvEqu8Wc9WvY LC4vvMRqcXnXHDaL/Z0djA6sHnsmnmTzODHjN4tH35ZVjB7T5/1k8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPy878sBfd4KqYemcjUwHiOq4uRk0NCwETi T/sTRghbTOLCvfVsXYxcHEIC0xkl3s7dzQrh/GKUeDlvCjNIFZuAmsSXL4fZuxg5OEQE9CXa WjRAapgFehklzvTuZgepERKwlbjavQqsnlPATmL541ksILawgIfEhEl3mEBsFgFVibm7JoLV 8wLV95y8zQhhC0r8mHwPrJ5ZQEti/c7jTBC2vMTmNW+ZQfZKCKhLPPqrCxIWETCSeN4+jRWi RERi34t3jBMYhWYhmTQLyaRZSCbNQtKygJFlFaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZw IngmvYNxVYPFIUYBDkYlHt4JKmaBQqyJZcWVuYcYJTiYlUR4uc4AhXhTEiurUovy44tKc1KL DzEmAz06kVlKNDkfmKTySuINjU3MjCyNzCyMTMzNSRNWEudlPPUkQEggPbEkNTs1tSC1CGYL EwenVANj8vzgpNYfp+97lkw0uJBcuqzHLlaMQ/KejqGUrNvSqwcv5MQzTj3CLL/riCDvw5/O sj29X2R9a+3/XvRr+dZwUaxwkt/HFUH55/X7Hq9pXX31THV35OSPldaCetaSKtmVxdViO+7Z vjtnfuvpzindj9gfzpuWvf3Bpl3CV9l+WYivn6jyr/aaEktxRqKhFnNRcSIAAVLX5EgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Also, this patch uses devm_request_threaded_irq(). Signed-off-by: Jingoo Han --- drivers/rtc/rtc-max77686.c | 15 ++++----------- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index df66bab..69524c8 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -538,8 +538,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - info->rtc_dev = rtc_device_register("max77686-rtc", &pdev->dev, - &max77686_rtc_ops, THIS_MODULE); + info->rtc_dev = devm_rtc_device_register("max77686-rtc", &pdev->dev, + &max77686_rtc_ops, THIS_MODULE); if (IS_ERR(info->rtc_dev)) { dev_info(&pdev->dev, "%s: fail\n", __func__); @@ -555,8 +555,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) goto err_rtc; info->virq = virq; - ret = request_threaded_irq(virq, NULL, max77686_rtc_alarm_irq, 0, - "rtc-alarm0", info); + ret = devm_request_threaded_irq(&pdev->dev, virq, NULL, + max77686_rtc_alarm_irq, 0, "rtc-alarm0", info); if (ret < 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); @@ -569,13 +569,6 @@ err_rtc: static int max77686_rtc_remove(struct platform_device *pdev) { - struct max77686_rtc_info *info = platform_get_drvdata(pdev); - - if (info) { - free_irq(info->virq, info); - rtc_device_unregister(info->rtc_dev); - } - return 0; }