From patchwork Wed Mar 6 05:30:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ve0-f191.google.com (mail-ve0-f191.google.com [209.85.128.191]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 78A0C2C037E for ; Wed, 6 Mar 2013 16:30:17 +1100 (EST) Received: by mail-ve0-f191.google.com with SMTP id m1sf3696353ves.28 for ; Tue, 05 Mar 2013 21:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=NruJVuDv0Sfxvty1JTfW0r88bP2YNxIDKwd/3MOtPCc=; b=eBwAt+EDbQXSdVnTkY44A/eK0mCzxGX9ssnmkgo001xeY1HLkxmoVIO6iCPuzCK4h8 M1YFJQyOj8+/RR4owUYUx9VU3Fr+Xui3nFozfYMiWi96Gvdk4iTUNTIm3w20zU1Pfijw 5C+P885XxVmtCVkT2DDiQafM6r3nsERRY/GdBAdE7/h53ufaA+EpJnqGTONBDfsXwSqG ggeQ/mgnUnogO/LL74Lb4jQ/w8fIDjW/BhkbClOxp52A7T38kcEAK47Qjwb+UILr0x60 fd8bvs+v7auHqlu0pSlESmk5OdYAD+KLKPC/9avhoqYePLWAXArfAkxQVH3wocvd8gJh l9WQ== X-Received: by 10.50.236.101 with SMTP id ut5mr1745027igc.17.1362547814861; Tue, 05 Mar 2013 21:30:14 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.89.163 with SMTP id bp3ls171200igb.25.canary; Tue, 05 Mar 2013 21:30:14 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7183052pbc.0.1362547814270; Tue, 05 Mar 2013 21:30:14 -0800 (PST) X-Received: by 10.68.242.193 with SMTP id ws1mr7183051pbc.0.1362547814260; Tue, 05 Mar 2013 21:30:14 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ka10si7597893pbb.2.2013.03.05.21.30.14; Tue, 05 Mar 2013 21:30:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800AQ64LT6O40@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:30:13 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 9E.3F.23273.464D6315; Wed, 06 Mar 2013 14:30:12 +0900 (KST) X-AuditID: cbfee691-b7faa6d000005ae9-fe-5136d464952f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F6.2A.03880.464D6315; Wed, 06 Mar 2013 14:30:12 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800G4N4MC8V30@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:30:12 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> In-reply-to: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> Subject: [rtc-linux] [PATCH 09/30] rtc: rtc-ep93xx: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 14:30:11 +0900 Message-id: <004b01ce1a2b$ac8de7a0$05a9b6e0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aKzqYzbgO1ZcaTfGsrpjfTnOAiQAAGcJA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zA92UK2aBBt+btS32d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoEr48Tr78wFL7kr7kzazt7A+JOzi5GDQ0LARGLD58IuRk4gU0zi wr31bF2MXBxCAssYJbZOvcMEkTCReHLwHDtEYhGjxKb7DSwQzkwmiebtm5hBqtgE1CS+fDnM DjJVREBfoq1FA6SGWaCXUeJM7252kBohAVuJq92rwOo5Bewklj+exQJiCwu4SRze+BpsG4uA qsS+A9PAbF6g+kc/NzBC2IISPybfA6tnFtCSWL/zOBOELS+xec1bZohv1CUe/dUFCYsIGEns 3/YCqkREYt+Ld4wg90gILGOXWNw0kxlil4DEt8mHWCB6ZSU2HWCGeFhS4uCKGywTGCVmIdk8 C8nmWUg2z0KyYgEjyypG0dSC5ILipPQiU73ixNzi0rx0veT83E2MkNiauIPx/gHrQ4zJQOsn MkuJJucDYzOvJN7Q2NjEzMTUxNzS1NyUNGElcV75SzKBQgLpiSWp2ampBalF8UWlOanFhxiZ ODilGhjTeS5LuU4RfRavKnvo2sSzSb8OtM8xE5j8YYL7OtU71yYdyP3b7V369DrvImsG3Y7T UpFSAY/l9zHsO9zsuHFHIJ9d1YEbB2dd12ZNtPu76db0VTLsRhL6ocz91ctOKKyS+FGTcGn9 jRyX0x/a+JNKO3jMZ+xgOhWzmjM9v7T3g7SgpMgyt04lluKMREMt5qLiRAAmpRjwwwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xgG7KFbNAg/4t6hb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHHi9XfmgpfcFXcmbWdv YPzJ2cXIySEhYCLx5OA5dghbTOLCvfVsXYxcHEICixglNt1vYIFwZjJJNG/fxAxSxSagJvHl y2GgDg4OEQF9ibYWDZAaZoFeRokzvbvBJgkJ2Epc7V4FVs8pYCex/PEsFhBbWMBN4vDG10wg NouAqsS+A9PAbF6g+kc/NzBC2IISPybfA6tnFtCSWL/zOBOELS+xec1bZpC9EgLqEo/+6oKE RQSMJPZvewFVIiKx78U7xgmMQrOQTJqFZNIsJJNmIWlZwMiyilE0tSC5oDgpPddIrzgxt7g0 L10vOT93EyM4dp9J72Bc1WBxiFGAg1GJh3eCilmgEGtiWXFl7iFGCQ5mJRFerjNAId6UxMqq 1KL8+KLSnNTiQ4zJQI9OZJYSTc4HppW8knhDYxMzI0sjMwsjE3Nz0oSVxHkZTz0JEBJITyxJ zU5NLUgtgtnCxMEp1cBY9PNVdX+S2Loiw5SMzkXTlEJyOmL+hm56eLLjwuMvUr9YrXMK1y3Y t33pay2vK/Onq0Y+U5lcIz5zMWflnooav5lb7DW/mEotmi+u9EIvrH3NmqMXBW7XPKvQv6K2 f7LD5l6rl7e9uhfdCrS+tZQpYU2+ioyLv5NsRnzoE56/Rzm43rBX51kpsRRnJBpqMRcVJwIA 8kdeSCEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-ep93xx.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1a4e5e4..6d24349 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -153,7 +153,7 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) pdev->dev.platform_data = ep93xx_rtc; platform_set_drvdata(pdev, ep93xx_rtc); - ep93xx_rtc->rtc = rtc_device_register(pdev->name, + ep93xx_rtc->rtc = devm_rtc_device_register(pdev->name, &pdev->dev, &ep93xx_rtc_ops, THIS_MODULE); if (IS_ERR(ep93xx_rtc->rtc)) { err = PTR_ERR(ep93xx_rtc->rtc); @@ -162,12 +162,10 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) err = sysfs_create_group(&pdev->dev.kobj, &ep93xx_rtc_sysfs_files); if (err) - goto fail; + goto exit; return 0; -fail: - rtc_device_unregister(ep93xx_rtc->rtc); exit: platform_set_drvdata(pdev, NULL); pdev->dev.platform_data = NULL; @@ -176,11 +174,8 @@ exit: static int ep93xx_rtc_remove(struct platform_device *pdev) { - struct ep93xx_rtc *ep93xx_rtc = platform_get_drvdata(pdev); - sysfs_remove_group(&pdev->dev.kobj, &ep93xx_rtc_sysfs_files); platform_set_drvdata(pdev, NULL); - rtc_device_unregister(ep93xx_rtc->rtc); pdev->dev.platform_data = NULL; return 0;