From patchwork Wed Mar 6 05:29:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 225311 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oa0-f62.google.com (mail-oa0-f62.google.com [209.85.219.62]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id F3DEF2C0370 for ; Wed, 6 Mar 2013 16:29:33 +1100 (EST) Received: by mail-oa0-f62.google.com with SMTP id l10sf3695014oag.17 for ; Tue, 05 Mar 2013 21:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=pmmL5m1Jp0dJ5ZnGOEL9L6C8rP0CXXw1yCfJrIilv2w=; b=N+m5RjLxX2sQT3/NqYYQKXSIFu8KGBmI8n/BtKmFzPgcn2s/zPJgp4QL1xOssJy1TA HHqa1R83MiQnFVB4WNEaU+E/rZ1vJ1z4Ka8Jn4eKdc2KqU4jV+VZuP+rgg3LvbFf1G9k 7CT+ElsxEpYEwG0eRXkJGo9IpZjXZmX0h7oVLYWOWn5dvIx+9fWcUvLG0frvl2pwwC17 DnAJAZzPC+ulBWsgjoMil4izYUgY5ppEojHwG9zAuB7MxQecPADmiQuiyBNbdNUZ2eve pc/MnlfZiqObFOVmGV5CLg/TXtgFPc7XkkyX9IVniHf7Pz+ivDoqXfkzrZ0X/5IwIDUg 7IoQ== X-Received: by 10.50.6.135 with SMTP id b7mr1734477iga.9.1362547770810; Tue, 05 Mar 2013 21:29:30 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.213.5 with SMTP id no5ls183117igc.14.canary; Tue, 05 Mar 2013 21:29:30 -0800 (PST) X-Received: by 10.68.161.163 with SMTP id xt3mr2255294pbb.7.1362547770360; Tue, 05 Mar 2013 21:29:30 -0800 (PST) X-Received: by 10.68.161.163 with SMTP id xt3mr2255292pbb.7.1362547770351; Tue, 05 Mar 2013 21:29:30 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ir9si5994568pbc.1.2013.03.05.21.29.30; Tue, 05 Mar 2013 21:29:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJ800BL34KYTU30@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:29:29 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 42.93.25214.934D6315; Wed, 06 Mar 2013 14:29:29 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-ad-5136d4397a0c Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 4C.F9.03880.934D6315; Wed, 06 Mar 2013 14:29:29 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJ800GJR4L58K20@mmp1.samsung.com> for rtc-linux@googlegroups.com; Wed, 06 Mar 2013 14:29:29 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> In-reply-to: <004301ce1a2b$3ad77e00$b0867a00$%han@samsung.com> Subject: [rtc-linux] [PATCH 07/30] rtc: rtc-ds1553: use devm_rtc_device_register() Date: Wed, 06 Mar 2013 14:29:29 +0900 Message-id: <004901ce1a2b$92f8fc30$b8eaf490$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4aKzqYzbgO1ZcaTfGsrpjfTnOAiQAAEwOQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zA13LK2aBBid3SFrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxt4bFQVLOSt23tvD3MB4g72LkZNDQsBE4tqm58wQtpjEhXvr 2UBsIYFljBJH5xTC1Mx8cpyxi5ELKL6IUeLU/IssEM5MJon5V6aBdbAJqEl8+XIYaCoHh4iA vkRbiwZIDbNAL6PEmd7d7BBTbSWudq8C28YpYCex/PEsFhBbWMBNYvreZiYQm0VAVWLn1tlg Ni9Q/eWTn1ggbEGJH5PvgdnMAloS63ceZ4Kw5SU2r3nLDLJXQkBd4tFfXZCwiICRxPYte9kg SkQk9r14B/aAhMAydolDxzazQewSkPg2+RALRK+sxKYD0ICQlDi44gbLBEaJWUg2z0KyeRaS zbOQrFjAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIySy+nYw3jxgfYgxGWj9RGYp0eR8 YGTmlcQbGhubmJmYmphbmpqbkiasJM4rf0kmUEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOj jVN9qPNV02l6q+39jk7I2eru8DXM4eSyX4vUedNtHbxUPZ5wn5l6v43ttPDcaN/TD1bZv+K4 /klBxHDr5jWRbnPPFMRkXeGRtL2a6XE4Y9/Z0P/31kXHeE2Kuf/uXunS98djBJZavDZz+fVV uu/0rLu1f1OtH09ddduIIdxcKitybQiX7d4tSizFGYmGWsxFxYkA0kJilMICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgK7lFbNAg67nohb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLH3RkXBUs6Knff2MDcw 3mDvYuTkkBAwkZj55DgjhC0mceHeerYuRi4OIYFFjBKn5l9kgXBmMknMvzKNDaSKTUBN4suX w0DdHBwiAvoSbS0aIDXMAr2MEmd6d4NNFRKwlbjavYoZxOYUsJNY/ngWC4gtLOAmMX1vMxOI zSKgKrFz62wwmxeo/vLJTywQtqDEj8n3wGxmAS2J9TuPM0HY8hKb17xlBtkrIaAu8eivLkhY RMBIYvuWvWwQJSIS+168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL 89L1kvNzNzGCI/eZ9A7GVQ0WhxgFOBiVeHgnqJgFCrEmlhVX5h5ilOBgVhLh5ToDFOJNSays Si3Kjy8qzUktPsSYDPToRGYp0eR8YFLJK4k3NDYxM7I0MrMwMjE3J01YSZyX8dSTACGB9MSS 1OzU1ILUIpgtTBycUg2MrKFfPtuxP1jHFvWJOXMOd2ZdZt/bV1b3ntWrf5cwlzF+Z6l+p2zr y7mHpzKHrr38YeOmk7dKfdhmRhxbtYl1Q/lR4ZB3Fyu8XzDdmTHBoMp609ONW26cumUzafKG 2lX3pzKUrPu963xWxcu4M/bWEi9Xpayq93rftYXprkpiu3xJtdvtu46Tc5RYijMSDbWYi4oT ATucTKEgAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-ds1553.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 25ce062..387289b 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -326,15 +326,14 @@ static int ds1553_rtc_probe(struct platform_device *pdev) } } - rtc = rtc_device_register(pdev->name, &pdev->dev, + rtc = devm_rtc_device_register(pdev->name, &pdev->dev, &ds1553_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); pdata->rtc = rtc; ret = sysfs_create_bin_file(&pdev->dev.kobj, &ds1553_nvram_attr); - if (ret) - rtc_device_unregister(rtc); + return ret; } @@ -343,7 +342,6 @@ static int ds1553_rtc_remove(struct platform_device *pdev) struct rtc_plat_data *pdata = platform_get_drvdata(pdev); sysfs_remove_bin_file(&pdev->dev.kobj, &ds1553_nvram_attr); - rtc_device_unregister(pdata->rtc); if (pdata->irq > 0) writeb(0, pdata->ioaddr + RTC_INTERRUPTS); return 0;