Patchwork [U-Boot,v6,27/31] avr32: Fix cast warning in board.c

login
register
mail settings
Submitter Simon Glass
Date March 6, 2013, 12:40 a.m.
Message ID <1362530405-10824-28-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/225225/
State Accepted, archived
Delegated to: Tom Rini
Headers show

Comments

Simon Glass - March 6, 2013, 12:40 a.m.
The frame buffer pointer in global_data is not a pointer, so we should
remove these casts.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v6:
- Add new patch to correct avr32 compile error caused by global_data chnage

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 arch/avr32/lib/board.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Andreas Bießmann - March 7, 2013, 11:12 a.m.
Dear Simon Glass,

On 06.03.13 01:40, Simon Glass wrote:
> The frame buffer pointer in global_data is not a pointer, so we should
> remove these casts.

Is this series intended for 2013.04?
I'm asking cause there is still a patch [1] in patchwork which I would
apply then. If this series will make it into 2013.04 I will give you my

Acked-by: Andreas Bießmann <andreas.devel@googlemail.com>

and set the other patch to superseded.

A runtime test of this series on avr32 would be good (cause of the
section changes). I try my best to do it these days.

Best regards

Andreas Bießmann

[1] http://patchwork.ozlabs.org/patch/220413/

Patch

diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index 5a3f752..57e07df 100644
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -211,11 +211,11 @@  void board_init_f(ulong board_type)
 #ifdef CONFIG_FB_ADDR
 	printf("LCD: Frame buffer allocated at preset 0x%08x\n",
 	       CONFIG_FB_ADDR);
-	gd->fb_base = (void *)CONFIG_FB_ADDR;
+	gd->fb_base = CONFIG_FB_ADDR;
 #else
 	addr = lcd_setmem(addr);
 	printf("LCD: Frame buffer allocated at 0x%08lx\n", addr);
-	gd->fb_base = (void *)addr;
+	gd->fb_base = addr;
 #endif /* CONFIG_FB_ADDR */
 #endif /* CONFIG_LCD */