From patchwork Tue Mar 5 17:59:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 225133 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 321142C0329 for ; Wed, 6 Mar 2013 04:59:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542Ab3CER7p (ORCPT ); Tue, 5 Mar 2013 12:59:45 -0500 Received: from li9-11.members.linode.com ([67.18.176.11]:51423 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755208Ab3CER7p (ORCPT ); Tue, 5 Mar 2013 12:59:45 -0500 Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1UCw9P-0008Jj-AW; Tue, 05 Mar 2013 17:59:43 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 333392406A8; Tue, 5 Mar 2013 12:59:42 -0500 (EST) From: Theodore Ts'o To: xfs@oss.sgi.com Cc: Ext4 Developers List , Theodore Ts'o Subject: [PATCH] xfstests: don't assume that falloc_punch implies falloc in test 255 Date: Tue, 5 Mar 2013 12:59:42 -0500 Message-Id: <1362506382-26974-1-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 1.7.12.rc0.22.gcdd159b X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org As of Linux 3.9-rc1, ext4 will support the punch operation on file systems using indirect blocks, but it can not support the fallocate operation (since there is no way to mark a block as uninitialized using indirect block scheme). This caused test 255 to fail, since it only used _require_xfS_io_falloc_punch assuming that all file systems which supported punch can also support fallocate. Fix this. Signed-off-by: "Theodore Ts'o" Reviewed-by: Rich Johnston Reviewed-by: Eric Sandeen --- 255 | 1 + 1 file changed, 1 insertion(+) diff --git a/255 b/255 index 0083963..ae1d8e0 100755 --- a/255 +++ b/255 @@ -48,6 +48,7 @@ _supported_fs generic _supported_os Linux _require_xfs_io_falloc_punch +_require_xfs_io_falloc _require_xfs_io_fiemap testfile=$TEST_DIR/255.$$