Patchwork [2/2] Revert "gdbstub: Do not kill target in system emulation mode"

login
register
mail settings
Submitter Fabien Chouteau
Date March 5, 2013, 4:03 p.m.
Message ID <1362499399-19475-2-git-send-email-chouteau@adacore.com>
Download mbox | patch
Permalink /patch/225067/
State New
Headers show

Comments

Fabien Chouteau - March 5, 2013, 4:03 p.m.
This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
 gdbstub.c |    2 --
 1 file changed, 2 deletions(-)
Jan Kiszka - March 5, 2013, 4:07 p.m.
On 2013-03-05 17:03, Fabien Chouteau wrote:
> This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.

Should also tell us why (by pointing to the other commit e.g.).

Will give this a try ASAP!

Thanks,
Jan

> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
>  gdbstub.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index c0686a9..22078df 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2181,11 +2181,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>              goto unknown_command;
>          }
>      case 'k':
> -#ifdef CONFIG_USER_ONLY
>          /* Kill the target */
>          fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
>          exit(0);
> -#endif
>      case 'D':
>          /* Detach packet */
>          gdb_breakpoint_remove_all();
>
Fabien Chouteau - March 5, 2013, 4:30 p.m.
On 03/05/2013 05:07 PM, Jan Kiszka wrote:
> On 2013-03-05 17:03, Fabien Chouteau wrote:
>> This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.
> 
> Should also tell us why (by pointing to the other commit e.g.).
> 

Yea, I should have put them together.

> Will give this a try ASAP!
> 

Thanks,

Patch

diff --git a/gdbstub.c b/gdbstub.c
index c0686a9..22078df 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2181,11 +2181,9 @@  static int gdb_handle_packet(GDBState *s, const char *line_buf)
             goto unknown_command;
         }
     case 'k':
-#ifdef CONFIG_USER_ONLY
         /* Kill the target */
         fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
         exit(0);
-#endif
     case 'D':
         /* Detach packet */
         gdb_breakpoint_remove_all();