From patchwork Tue Sep 9 20:58:14 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuji Mano X-Patchwork-Id: 225 X-Patchwork-Delegate: yuji.mano@am.sony.com Return-Path: X-Original-To: patchwork@ozlabs.org Delivered-To: patchwork@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 52C4ADE7D6 for ; Wed, 10 Sep 2008 06:59:33 +1000 (EST) X-Original-To: cbe-oss-dev@ozlabs.org Delivered-To: cbe-oss-dev@ozlabs.org Received: from SG2EHSOBE003.bigfish.com (outbound-sin.frontbridge.com [207.46.51.80]) by ozlabs.org (Postfix) with ESMTP id 6184BDDF75 for ; Wed, 10 Sep 2008 06:58:56 +1000 (EST) Received: from mail19-sin-R.bigfish.com (10.3.40.3) by SG2EHSOBE003.bigfish.com (10.3.40.23) with Microsoft SMTP Server id 8.1.291.1; Tue, 9 Sep 2008 20:58:53 +0000 Received: from mail19-sin (localhost.localdomain [127.0.0.1]) by mail19-sin-R.bigfish.com (Postfix) with ESMTP id 48F88A001AB for ; Tue, 9 Sep 2008 20:58:53 +0000 (UTC) X-BigFish: VS3(zzzz10c0j10d3izzz2dh6bh62h) X-Spam-TCS-SCL: 1:0 Received: by mail19-sin (MessageSwitch) id 1220993932606409_8698; Tue, 9 Sep 2008 20:58:52 +0000 (UCT) Received: from mail8.fw-bc.sony.com (mail8.fw-bc.sony.com [160.33.98.75]) by mail19-sin.bigfish.com (Postfix) with ESMTP id 012ECF8061 for ; Tue, 9 Sep 2008 20:58:51 +0000 (UTC) Received: from mail3.sjc.in.sel.sony.com (mail3.sjc.in.sel.sony.com [43.134.1.211]) by mail8.fw-bc.sony.com (8.14.2/8.14.2) with ESMTP id m89Kwomu027921 for ; Tue, 9 Sep 2008 20:58:50 GMT Received: from USSDIXIM01.am.sony.com (ussdixim01.am.sony.com [43.130.140.33]) by mail3.sjc.in.sel.sony.com (8.12.11/8.12.11) with ESMTP id m89KwoQu022083 for ; Tue, 9 Sep 2008 20:58:50 GMT Received: from ussdixms03.am.sony.com ([43.130.140.23]) by USSDIXIM01.am.sony.com with Microsoft SMTPSVC(5.0.2195.6713); Tue, 9 Sep 2008 13:58:49 -0700 Received: from [43.135.148.175] ([43.135.148.175]) by ussdixms03.am.sony.com with Microsoft SMTPSVC(5.0.2195.6713); Tue, 9 Sep 2008 13:58:49 -0700 Message-ID: <48C6E366.4030304@am.sony.com> Date: Tue, 9 Sep 2008 13:58:14 -0700 From: Yuji Mano User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: CBE Development X-Enigmail-Version: 0.95.7 X-OriginalArrivalTime: 09 Sep 2008 20:58:49.0467 (UTC) FILETIME=[DBA1CCB0:01C912BE] X-SEL-encryption-scan: scanned Subject: [Cbe-oss-dev] [PATCH 2/2]MARS: fix dma list element initialization X-BeenThere: cbe-oss-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Discussion about Open Source Software for the Cell Broadband Engine List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org Errors-To: cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org This fixes a critical bug where the notify and reserved structure members of the dma list element are not properly initialized, causing random stalls after the dma completion. Signed-off-by: Yuji Mano Acked-by: Kazunori Asayama --- a/include/mpu/mars/mars_dma.h +++ b/include/mpu/mars/mars_dma.h @@ -67,6 +67,8 @@ static inline unsigned int _list_init(mf unsigned int block_size; block_size = (size < MARS_DMA_SIZE_MAX) ? size : MARS_DMA_SIZE_MAX; + list[count].notify = 0; + list[count].reserved = 0; list[count].size = block_size; list[count].eal = eal; size -= block_size;