Patchwork Silence up a false positive warning in libiberty (PR middle-end/56526)

login
register
mail settings
Submitter Jakub Jelinek
Date March 5, 2013, 10:52 a.m.
Message ID <20130305105205.GD12913@tucnak.redhat.com>
Download mbox | patch
Permalink /patch/224981/
State New
Headers show

Comments

Jakub Jelinek - March 5, 2013, 10:52 a.m.
Hi!

While wrapper_sect_offset is always initialized if
(gnu_sections_found & SOMO_WRAPPING) != 0 and used only guarded with that
same condition, as the PR says apparently we get a false positive maybe
uninitialized warning for it still.  I'd say it is a good programming style
to just initialize such vars, especially in performance non-critical code.

Ok for trunk?

2013-03-05  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/56526
	* simple-object-mach-o.c (simple_object_mach_o_segment): Initialize
	wrapper_sect_offset to avoid a warning.


	Jakub
Ian Taylor - March 5, 2013, 2:57 p.m.
On Tue, Mar 5, 2013 at 2:52 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>
> 2013-03-05  Jakub Jelinek  <jakub@redhat.com>
>
>         PR middle-end/56526
>         * simple-object-mach-o.c (simple_object_mach_o_segment): Initialize
>         wrapper_sect_offset to avoid a warning.

This is OK.

Thanks.

Ian

Patch

--- libiberty/simple-object-mach-o.c.jj	2013-01-07 14:14:46.000000000 +0100
+++ libiberty/simple-object-mach-o.c	2013-03-05 11:46:19.574157009 +0100
@@ -432,7 +432,7 @@  simple_object_mach_o_segment (simple_obj
   size_t index_size;
   unsigned int n_wrapped_sects;
   size_t wrapper_sect_size;
-  off_t wrapper_sect_offset;
+  off_t wrapper_sect_offset = 0;
 
   fetch_32 = (omr->is_big_endian
 	      ? simple_object_fetch_big_32